Xi Zhang
92df3e1844
* feat(cli): migrate command handling to CommandManager and enhance UI interactions * feat(cli): add /clear and /help commands to enhance user experience * feat(cli): implement /new and /resume commands with interactive session management * Refactor MCP and Skills Command Handling - Moved the interactive picker style to a centralized widget for consistency across MCP and Skills commands. - Updated the MCP command to remove the old command dispatch logic, delegating to the new InstallMCPCommand. - Enhanced the Skills command to utilize a new interactive picker for skill selection, improving user experience. - Implemented cancellation handling in the picker to differentiate between user cancellations and empty selections. - Added comprehensive tests for the new command structures and picker functionalities to ensure reliability. * refactor(cli): streamline CommandManager dispatch and remove deprecated command set * refactor(cli): enhance error handling and state management in ChannelCommand and RichCLICommandUI * refactor(cli): update lifecycle callback terminology and improve async prompt handling in RichCLICommandUI * refactor(cli): enhance SlashCommandCompleter to dynamically fetch workspace directory for autocompletion * refactor(cli): unify quit handling in RichCLICommandUI with shared _stop helper * refactor(cli): remove hardcoded slash commands and utilize command manager for dynamic completion * refactor(cli): update MCP and skills command files for improved clarity and organization * refactor(mcp_ui): remove unnecessary newline in _show_mcp_config function
143 lines
5.1 KiB
Python
143 lines
5.1 KiB
Python
"""Tests for the /resume command."""
|
|
|
|
from contextlib import ExitStack
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
from tests.conftest import run_async as _run
|
|
|
|
|
|
def _ctx(thread_id="current", workspace_dir="/ws"):
|
|
from EvoScientist.commands.base import CommandContext
|
|
|
|
ui = MagicMock()
|
|
ui.supports_interactive = True
|
|
ui.wait_for_thread_pick = AsyncMock()
|
|
ui.handle_session_resume = AsyncMock()
|
|
return CommandContext(
|
|
agent=None, thread_id=thread_id, ui=ui, workspace_dir=workspace_dir
|
|
), ui
|
|
|
|
|
|
def _patches(
|
|
*,
|
|
thread_exists=False,
|
|
similar=None,
|
|
threads=None,
|
|
metadata=None,
|
|
):
|
|
stack = ExitStack()
|
|
stack.enter_context(
|
|
patch(
|
|
"EvoScientist.sessions.thread_exists",
|
|
new=AsyncMock(return_value=thread_exists),
|
|
)
|
|
)
|
|
stack.enter_context(
|
|
patch(
|
|
"EvoScientist.sessions.find_similar_threads",
|
|
new=AsyncMock(return_value=similar or []),
|
|
)
|
|
)
|
|
stack.enter_context(
|
|
patch(
|
|
"EvoScientist.sessions.list_threads",
|
|
new=AsyncMock(return_value=threads or []),
|
|
)
|
|
)
|
|
stack.enter_context(
|
|
patch(
|
|
"EvoScientist.sessions.get_thread_metadata",
|
|
new=AsyncMock(return_value=metadata or {}),
|
|
)
|
|
)
|
|
return stack
|
|
|
|
|
|
class TestResumeCommand:
|
|
def test_with_arg_resolves_and_calls_ui(self):
|
|
from EvoScientist.commands.implementation.session import ResumeCommand
|
|
|
|
ctx, ui = _ctx()
|
|
with _patches(thread_exists=True, metadata={"workspace_dir": "/restored"}):
|
|
_run(ResumeCommand().execute(ctx, ["target-tid"]))
|
|
ui.handle_session_resume.assert_awaited_once_with("target-tid", "/restored")
|
|
# ctx mutations
|
|
assert ctx.thread_id == "target-tid"
|
|
assert ctx.workspace_dir == "/restored"
|
|
|
|
def test_no_arg_empty_threads_prints_message(self):
|
|
from EvoScientist.commands.implementation.session import ResumeCommand
|
|
|
|
ctx, ui = _ctx()
|
|
with _patches(threads=[]):
|
|
_run(ResumeCommand().execute(ctx, []))
|
|
msgs = [c.args[0] for c in ui.append_system.call_args_list]
|
|
assert any("No sessions to resume" in m for m in msgs)
|
|
ui.wait_for_thread_pick.assert_not_called()
|
|
ui.handle_session_resume.assert_not_called()
|
|
|
|
def test_no_arg_calls_picker(self):
|
|
from EvoScientist.commands.implementation.session import ResumeCommand
|
|
|
|
ctx, ui = _ctx()
|
|
ui.wait_for_thread_pick.return_value = "picked-tid"
|
|
threads = [{"thread_id": "picked-tid", "preview": "p", "message_count": 1}]
|
|
with _patches(thread_exists=True, threads=threads):
|
|
_run(ResumeCommand().execute(ctx, []))
|
|
ui.wait_for_thread_pick.assert_awaited_once()
|
|
ui.handle_session_resume.assert_awaited_once()
|
|
|
|
def test_picker_cancel_returns(self):
|
|
from EvoScientist.commands.implementation.session import ResumeCommand
|
|
|
|
ctx, ui = _ctx()
|
|
ui.wait_for_thread_pick.return_value = None
|
|
threads = [{"thread_id": "t1", "preview": "", "message_count": 0}]
|
|
with _patches(threads=threads):
|
|
_run(ResumeCommand().execute(ctx, []))
|
|
ui.handle_session_resume.assert_not_called()
|
|
|
|
def test_ambiguous_prefix(self):
|
|
from EvoScientist.commands.implementation.session import ResumeCommand
|
|
|
|
ctx, ui = _ctx()
|
|
with _patches(thread_exists=False, similar=["abc-one", "abc-two"]):
|
|
_run(ResumeCommand().execute(ctx, ["abc"]))
|
|
msgs = [c.args[0] for c in ui.append_system.call_args_list]
|
|
assert any("Ambiguous" in m for m in msgs)
|
|
ui.handle_session_resume.assert_not_called()
|
|
|
|
def test_not_found(self):
|
|
from EvoScientist.commands.implementation.session import ResumeCommand
|
|
|
|
ctx, ui = _ctx()
|
|
with _patches(thread_exists=False, similar=[]):
|
|
_run(ResumeCommand().execute(ctx, ["missing"]))
|
|
msgs = [c.args[0] for c in ui.append_system.call_args_list]
|
|
assert any("not found" in m for m in msgs)
|
|
ui.handle_session_resume.assert_not_called()
|
|
|
|
def test_prefix_resolves_to_unique_match(self):
|
|
from EvoScientist.commands.implementation.session import ResumeCommand
|
|
|
|
ctx, ui = _ctx()
|
|
with _patches(
|
|
thread_exists=False,
|
|
similar=["abc-one"],
|
|
metadata={"workspace_dir": "/ws1"},
|
|
):
|
|
_run(ResumeCommand().execute(ctx, ["abc"]))
|
|
ui.handle_session_resume.assert_awaited_once_with("abc-one", "/ws1")
|
|
assert ctx.thread_id == "abc-one"
|
|
|
|
def test_empty_workspace_metadata_preserves_ctx_workspace(self):
|
|
from EvoScientist.commands.implementation.session import ResumeCommand
|
|
|
|
ctx, ui = _ctx(workspace_dir="/keep")
|
|
with _patches(thread_exists=True, metadata={}):
|
|
_run(ResumeCommand().execute(ctx, ["tid"]))
|
|
# ResumeCommand only overwrites ctx.workspace_dir if metadata has one
|
|
assert ctx.workspace_dir == "/keep"
|
|
# Callback still fires with the metadata value (empty string)
|
|
ui.handle_session_resume.assert_awaited_once_with("tid", "")
|