dinos
690b903f85
* chore: add pytest-asyncio in auto mode * test: migrate channel and stream tests to native async Convert run_async() wrapper tests to plain 'async def test_*' under pytest-asyncio auto mode. collect_events() in stream_v3_fakes becomes a coroutine awaited at every call site. * test: migrate command and model/middleware tests to native async Convert run_async() wrappers (import, alias, and fixture forms) to plain 'async def test_*'. Multi-call tests merge onto one loop as sequential awaits; none asserted on loop identity. * test: migrate TUI, notifier, gateway, and session tests to native async TUI/notifier/gateway files convert run_async wrappers to plain async tests. test_sessions.py's unittest.TestCase classes move to unittest.IsolatedAsyncioTestCase (pytest-asyncio does not await async methods on plain TestCase; converting blindly would have made ~70 tests silently vacuous). Its setUpClass keeps a one-shot asyncio.run() since IsolatedAsyncioTestCase has no async class-level hook. TestLoadingWidget in test_tui_widgets.py drops its TestCase base for the same reason. * test: replace direct asyncio.run() calls with native async tests Convert tests that called asyncio.run() (directly or via a local _run helper) to plain 'async def test_*'; delete the local helpers. * test: drop undeclared anyio markers and delete run_async helper The @pytest.mark.anyio tests relied on anyio being a transitive dep of httpx; auto-mode pytest-asyncio collects them natively. run_async() and its fixture are unreferenced after the migration, so remove them — pytest-asyncio's per-test loop teardown covers the pending-task cancellation the helper existed for (verified: full suite runs with no 'Event loop is closed' errors or destroyed-task warnings).
202 lines
6.5 KiB
Python
202 lines
6.5 KiB
Python
"""Tests for the /channel command (ChannelCommand)."""
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
|
|
def _ctx():
|
|
from EvoScientist.commands.base import ChannelRuntime, CommandContext
|
|
|
|
ui = MagicMock()
|
|
ui.supports_interactive = True
|
|
runtime = ChannelRuntime()
|
|
ctx = CommandContext(
|
|
agent=object(),
|
|
thread_id="tid-42",
|
|
ui=ui,
|
|
workspace_dir="/ws",
|
|
channel_runtime=runtime,
|
|
)
|
|
return ctx, ui
|
|
|
|
|
|
class TestNeedsAgent:
|
|
"""status + stop must not require the agent (recovery from broken load)."""
|
|
|
|
def test_status_does_not_need_agent(self):
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
assert ChannelCommand().needs_agent(["status"]) is False
|
|
|
|
def test_stop_does_not_need_agent(self):
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
assert ChannelCommand().needs_agent(["stop"]) is False
|
|
|
|
def test_stop_with_target_does_not_need_agent(self):
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
assert ChannelCommand().needs_agent(["stop", "telegram"]) is False
|
|
|
|
def test_start_subcommand_needs_agent(self):
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
assert ChannelCommand().needs_agent(["telegram"]) is True
|
|
|
|
def test_no_args_needs_agent(self):
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
# no subcmd → falls through to start flow, needs agent
|
|
assert ChannelCommand().needs_agent([]) is True
|
|
|
|
|
|
class TestStartPath:
|
|
"""Start flow must propagate agent/thread_id globals."""
|
|
|
|
async def test_start_binds_channel_runtime(self):
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
ctx, _ui = _ctx()
|
|
config = SimpleNamespace(
|
|
channel_enabled="telegram",
|
|
channel_send_thinking=True,
|
|
)
|
|
|
|
with (
|
|
patch(
|
|
"EvoScientist.cli.channel._channels_is_running",
|
|
return_value=False,
|
|
),
|
|
patch(
|
|
"EvoScientist.cli.channel._start_channels_bus_mode",
|
|
),
|
|
patch(
|
|
"EvoScientist.config.load_config",
|
|
return_value=config,
|
|
),
|
|
):
|
|
await ChannelCommand().execute(ctx, ["telegram"])
|
|
assert ctx.channel_runtime.agent is ctx.agent
|
|
assert ctx.channel_runtime.thread_id == "tid-42"
|
|
|
|
async def test_start_propagates_send_thinking(self):
|
|
"""send_thinking flag must reach _start_channels_bus_mode."""
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
ctx, _ui = _ctx()
|
|
config = SimpleNamespace(
|
|
channel_enabled="telegram",
|
|
channel_send_thinking=False,
|
|
)
|
|
captured = {}
|
|
|
|
def _fake_start(cfg, agent, thread_id, *, send_thinking=None):
|
|
captured["agent"] = agent
|
|
captured["thread_id"] = thread_id
|
|
captured["send_thinking"] = send_thinking
|
|
|
|
with (
|
|
patch(
|
|
"EvoScientist.cli.channel._channels_is_running",
|
|
return_value=False,
|
|
),
|
|
patch(
|
|
"EvoScientist.cli.channel._start_channels_bus_mode",
|
|
_fake_start,
|
|
),
|
|
patch(
|
|
"EvoScientist.config.load_config",
|
|
return_value=config,
|
|
),
|
|
):
|
|
await ChannelCommand().execute(ctx, ["telegram"])
|
|
assert captured["agent"] is ctx.agent
|
|
assert captured["thread_id"] == "tid-42"
|
|
assert captured["send_thinking"] is False
|
|
|
|
|
|
class TestAddToRunningPath:
|
|
async def test_add_to_running_binds_channel_runtime(self):
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
ctx, _ui = _ctx()
|
|
config = SimpleNamespace(
|
|
channel_enabled="telegram",
|
|
channel_send_thinking=False,
|
|
)
|
|
|
|
with (
|
|
patch(
|
|
"EvoScientist.cli.channel._channels_is_running",
|
|
return_value=True,
|
|
),
|
|
patch(
|
|
"EvoScientist.cli.channel._add_channel_to_running_bus",
|
|
),
|
|
patch(
|
|
"EvoScientist.config.load_config",
|
|
return_value=config,
|
|
),
|
|
):
|
|
await ChannelCommand().execute(ctx, ["discord"])
|
|
assert ctx.channel_runtime.agent is ctx.agent
|
|
assert ctx.channel_runtime.thread_id == "tid-42"
|
|
|
|
async def test_add_to_running_propagates_send_thinking(self):
|
|
"""Adding to a running bus must honor config.channel_send_thinking."""
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
ctx, _ui = _ctx()
|
|
config = SimpleNamespace(
|
|
channel_enabled="telegram",
|
|
channel_send_thinking=True,
|
|
)
|
|
captured = {}
|
|
|
|
def _fake_add(channel_type, cfg, *, send_thinking=None):
|
|
captured["channel_type"] = channel_type
|
|
captured["send_thinking"] = send_thinking
|
|
|
|
with (
|
|
patch(
|
|
"EvoScientist.cli.channel._channels_is_running",
|
|
return_value=True,
|
|
),
|
|
patch(
|
|
"EvoScientist.cli.channel._add_channel_to_running_bus",
|
|
_fake_add,
|
|
),
|
|
patch(
|
|
"EvoScientist.config.load_config",
|
|
return_value=config,
|
|
),
|
|
):
|
|
await ChannelCommand().execute(ctx, ["discord"])
|
|
assert captured["channel_type"] == "discord"
|
|
assert captured["send_thinking"] is True
|
|
|
|
|
|
class TestStatusPath:
|
|
async def test_status_without_running_channels(self):
|
|
from EvoScientist.commands.implementation.channel import ChannelCommand
|
|
|
|
ctx, ui = _ctx()
|
|
config = SimpleNamespace(channel_enabled="", channel_send_thinking=False)
|
|
with (
|
|
patch(
|
|
"EvoScientist.cli.channel._channels_is_running",
|
|
return_value=False,
|
|
),
|
|
patch(
|
|
"EvoScientist.cli.channel._channels_running_list",
|
|
return_value=[],
|
|
),
|
|
patch(
|
|
"EvoScientist.config.load_config",
|
|
return_value=config,
|
|
),
|
|
):
|
|
await ChannelCommand().execute(ctx, ["status"])
|
|
msgs = [c.args[0] for c in ui.append_system.call_args_list]
|
|
assert any("No messaging channels" in m for m in msgs)
|