ouyangbo/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 12 Packages Projects Releases Wiki Activity

fix: hindsight update-time dep resolution survives a BOM in config.json

Browse Source 
`_provider_pip_dependencies` still read ~/.hermes/hindsight/config.json with
strict utf-8 inside a bare `except Exception`, so a Windows-editor BOM made the
`mode` lookup silently fail and `hermes update` reinstalled only
`hindsight-client`, leaving the embedded daemon broken — the exact #70636
symptom this helper exists to prevent. Route it through the shared
`read_json_or_empty` (utf-8-sig, {} on missing/corrupt) like the other memory
readers in this PR, and add the reader to the parametrized BOM invariant.
This commit is contained in:
teknium1
2026-09-14 21:07:23 -07:00
committed by Teknium
parent c97e36db3f
commit 021ab58a23
2 changed files with 22 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/plugins/memory/test_bom_tolerant_config_reads.py
+16 -6
View File
@@ -19,17 +19,24 @@ def _write_bom_json(path: Path, payload: dict) -> Path:
return path
def _via_shared_reader(p: Path) -> dict:
def _via_shared_reader(p: Path, monkeypatch) -> dict:
from utils import read_json_or_empty # mem0 / hindsight / honcho CLI all read through this
return read_json_or_empty(p)
def _via_supermemory(p: Path) -> dict:
def _via_supermemory(p: Path, monkeypatch) -> dict:
from plugins.memory.supermemory import _load_supermemory_config
return _load_supermemory_config(str(p.parent))
def _via_honcho_client(p: Path) -> dict:
def _via_hindsight_runtime_deps(p: Path, monkeypatch) -> dict:
import hermes_cli.memory_setup as ms
monkeypatch.setattr(ms, "get_hermes_home", lambda: p.parent.parent) # <home>/hindsight/config.json
deps = ms._provider_pip_dependencies("hindsight", ["hindsight-client"])
return {"workspace": "bom-ws" if "hindsight-all" in deps else None, "container_tag": None}
def _via_honcho_client(p: Path, monkeypatch) -> dict:
from plugins.memory.honcho.client import HonchoClientConfig
cfg = HonchoClientConfig.from_global_config(config_path=p)
return {"workspace": cfg.workspace_id, "container_tag": None}
@@ -39,10 +46,13 @@ def _via_honcho_client(p: Path) -> dict:
("mem0.json", _via_shared_reader),
("supermemory.json", _via_supermemory),
("honcho.json", _via_honcho_client),
("hindsight/config.json", _via_hindsight_runtime_deps),
])
def test_plugin_config_json_tolerates_bom(tmp_path, filename, loader):
_write_bom_json(tmp_path / filename, {"workspace": "bom-ws", "container_tag": "bom-tag", "enabled": True})
loaded = loader(tmp_path / filename)
def test_plugin_config_json_tolerates_bom(tmp_path, monkeypatch, filename, loader):
target = tmp_path / filename
target.parent.mkdir(parents=True, exist_ok=True)
_write_bom_json(target, {"workspace": "bom-ws", "container_tag": "bom-tag", "enabled": True, "mode": "local_embedded"})
loaded = loader(target, monkeypatch)
assert "bom" in str(loaded.get("workspace") or loaded.get("container_tag"))