ouyangbo/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 12 Packages Projects Releases Wiki Activity

test: modal integration test imports terminal helpers from their defining modules

Browse Source 
It side-loaded tools/terminal_tool.py via importlib.spec_from_file_location under the bare name
'terminal_tool', which bypassed both the package and scripts/check_compat_pointers.py, then read
cleanup_vm through the compat pointer. Found by running the suite with HermesPluginCompatWarning
promoted to an error — the only in-tree resolution through a pointer across 44,7k tests.
This commit is contained in:
Teknium
2026-09-04 00:53:42 -07:00
parent d63e380324
commit 1392e4b857
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/test_modal_terminal.py
+2 -11
View File
@@ -42,17 +42,8 @@ except ImportError:
parent_dir = Path(__file__).parent.parent.parent
sys.path.insert(0, str(parent_dir))
# Import terminal_tool module directly using importlib to avoid tools/__init__.py
import importlib.util
terminal_tool_path = parent_dir / "tools" / "terminal_tool.py"
spec = importlib.util.spec_from_file_location("terminal_tool", terminal_tool_path)
terminal_module = importlib.util.module_from_spec(spec)
spec.loader.exec_module(terminal_module)
terminal_tool = terminal_module.terminal_tool
check_terminal_requirements = terminal_module.check_terminal_requirements
_get_env_config = terminal_module._get_env_config
cleanup_vm = terminal_module.cleanup_vm
from tools.terminal_tool import terminal_tool, check_terminal_requirements, _get_env_config # noqa: E402
from tools.terminal_tool_lifecycle import cleanup_vm # noqa: E402
def test_modal_requirements():