test: run os-specific tests on their real host, not a faked one

many tests patched sys.platform or a module's _IS_WINDOWS flag, then
ran on linux ci. the patch selects the branch under test, but the host
does not have the behavior the branch exists for. the test proves the
patch, not the platform. some gated assertions never ran on any host.

this commit adds three markers: linux_only, macos_only, windows_only.
a conftest hook skips a marked test on the other hosts, with a clear
reason. no test fakes a host now. two documented fakes remain
(android/termux, freebsd) because no ci runner exists for them.

each fake site got one of four treatments:
- gate it: the real host supplies the platform; mocks cover real
  dependencies only, never host identity
- patch the module's own probe when the subject is the probe's consumer
- assert against the real host when the fake stood in for any non-x host
- delete the patch when it set the value the host already has

bare skipif(sys.platform != ...) guards became markers too. the lane
model skips these on linux and never imports them on windows, so they
ran on no host. platform parametrize tables are now one marked test
per os.

running on real hosts found real errors: a chrome-sandbox failure in
test_gui_command that main hides, and two windows failures fixed here.
the agents.md testing section now documents the policy.
This commit is contained in:
ethernet
2026-08-04 16:52:52 -04:00
parent 3bd844edf1
commit 30da5d0a89
66 changed files with 1530 additions and 769 deletions
+7 -11
View File
@@ -403,8 +403,8 @@ class TestAliasCollision:
def test_windows_checks_bat_extension(self, profile_env, monkeypatch):
monkeypatch.setattr("sys.platform", "win32")
@pytest.mark.windows_only
def test_windows_checks_bat_extension(self, profile_env):
wrapper_dir = profile_env / ".local" / "bin"
wrapper_dir.mkdir(parents=True, exist_ok=True)
bat_path = wrapper_dir / "mybot.bat"
@@ -433,7 +433,6 @@ class TestWrapperScript:
"""Tests for create_wrapper_script() and remove_wrapper_script()."""
def test_creates_sh_on_posix(self, profile_env, monkeypatch):
monkeypatch.setattr("sys.platform", "darwin")
monkeypatch.setattr("hermes_cli.profiles.shutil.which", lambda name: "/opt/hermes/bin/hermes")
from hermes_cli.profiles import create_wrapper_script
wrapper = create_wrapper_script("mybot")
@@ -444,8 +443,8 @@ class TestWrapperScript:
assert "exec /opt/hermes/bin/hermes -p mybot" in content
def test_remove_finds_bat_on_windows(self, profile_env, monkeypatch):
monkeypatch.setattr("sys.platform", "win32")
@pytest.mark.windows_only
def test_remove_finds_bat_on_windows(self, profile_env):
from hermes_cli.profiles import create_wrapper_script, remove_wrapper_script
wrapper = create_wrapper_script("mybot")
assert wrapper is not None
@@ -492,16 +491,14 @@ class TestWrapperScriptSecurity:
class TestFindAliasForProfile:
"""Tests for find_alias_for_profile() and alias display in list/show."""
def test_profile_named_alias(self, profile_env, monkeypatch):
monkeypatch.setattr("sys.platform", "darwin")
def test_profile_named_alias(self, profile_env):
from hermes_cli.profiles import create_wrapper_script, find_alias_for_profile
create_wrapper_script("steve")
assert find_alias_for_profile("steve") == "steve"
def test_ignores_unrelated_files(self, profile_env, monkeypatch):
def test_ignores_unrelated_files(self, profile_env):
# ~/.local/bin commonly holds unrelated binaries; they must not match.
monkeypatch.setattr("sys.platform", "darwin")
from hermes_cli.profiles import _get_wrapper_dir, find_alias_for_profile
wrapper_dir = _get_wrapper_dir()
wrapper_dir.mkdir(parents=True, exist_ok=True)
@@ -509,8 +506,7 @@ class TestFindAliasForProfile:
assert find_alias_for_profile("steve") is None
def test_list_profiles_surfaces_custom_alias(self, profile_env, monkeypatch):
monkeypatch.setattr("sys.platform", "darwin")
def test_list_profiles_surfaces_custom_alias(self, profile_env):
from hermes_cli.profiles import (
create_profile,
create_wrapper_script,