From 40da71dbb4be140f757048637943f5f448fb2542 Mon Sep 17 00:00:00 2001 From: kshitijk4poor <82637225+kshitijk4poor@users.noreply.github.com> Date: Mon, 7 Sep 2026 12:51:03 +0530 Subject: [PATCH] docs(kanban): name the legacy-attachments cutoff (#35395) in the type comment Desktop AGENTS.md requires a compat fallback to be 'tied to an identified older runtime' so a future cleanup knows when it can be deleted. The original comment said only 'older backend plugins'; name the actual boundary: backends before #35395 (May 2026) omit the attachments key. Review follow-up on the salvage of #104529. --- apps/desktop/src/plugins/kanban/types.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/desktop/src/plugins/kanban/types.ts b/apps/desktop/src/plugins/kanban/types.ts index 607e08d820..6d1b07b21f 100644 --- a/apps/desktop/src/plugins/kanban/types.ts +++ b/apps/desktop/src/plugins/kanban/types.ts @@ -117,7 +117,9 @@ export interface KanbanTaskDetail { task: KanbanTaskFull comments: KanbanComment[] events: KanbanEvent[] - /** Older backend plugins omit this collection and have no attachment endpoints. */ + /** Kanban backends before attachments landed (#35395, May 2026) omit this + * key and have no /tasks/{id}/attachments endpoints; absent/null hides the + * section instead of offering uploads the backend would 404 on. */ attachments?: KanbanAttachment[] | null links: { parents: string[]; children: string[] } runs: KanbanRun[]