fix(install-e2e): review follow-ups — harness needle, per-matrix cap wording, typo

The harness asserted the driver still throws 'not implemented yet' for
the desktop-installer@latest update route; that arm is implemented now
(Invoke-PhaseInstallGui -Mode "update"), so the check failed against
its own tree. It asserts the implemented contract instead.

The 256-job cap wording in the workflow comment and README now states
the scope GitHub applies it at: each per-OS matrix separately, not the
combined leg count. At the 10-tag bound the largest matrix is windows
at 180.

e2e-screen-record comment: hhttps -> https.
This commit is contained in:
yoniebans
2026-09-03 10:15:53 +02:00
parent cd39b3535c
commit 49a5c440c5
4 changed files with 8 additions and 7 deletions
+1 -1
View File
@@ -59,7 +59,7 @@ runs:
command -v ffmpeg >/dev/null 2>&1 || brew install --quiet ffmpeg
# until new runner image is published by github, we have to hack on screen record approvals
# see hhttps://github.com/actions/runner-images/issues/14474 - as of this hermes agent commit,
# see https://github.com/actions/runner-images/issues/14474 - as of this hermes agent commit,
# it's merged but the image isn't updated.
approvalsPlist="$HOME/Library/Group Containers/group.com.apple.replayd/ScreenCaptureApprovals.plist"
mkdir -p "$(dirname "$approvalsPlist")"
+4 -3
View File
@@ -97,9 +97,10 @@ jobs:
- id: pick
env:
# Dispatch inputs never touch shell syntax directly: TAG_COUNT
# arrives via the environment, is validated decimal-only (bash
# arithmetic reads a leading zero as octal), and is capped below
# the 256-job matrix limit (15 tags = 270 windows entries).
# arrives via the environment and is validated decimal-only (bash
# arithmetic reads a leading zero as octal). GitHub's 256-job cap
# applies to each per-OS matrix separately; at 10 tags the largest
# is windows at 180 (first over the cap at 15 tags = 270).
TAG_COUNT: ${{ inputs.tag-count || 2 }}
run: |
set -euo pipefail