From 552c5b62ca22bad45914341408ac4ee7c5a4feac Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Wed, 2 Sep 2026 19:31:18 -0700 Subject: [PATCH] refactor(agent/relay_runtime): remove dead emit_mark (module fn + RelayRuntime method; only a test asserted its False path) --- agent/relay_runtime.py | 22 ------------------- .../test_relay_shared_metrics_runtime.py | 1 - 2 files changed, 23 deletions(-) diff --git a/agent/relay_runtime.py b/agent/relay_runtime.py index e292f931e9..f14b5551dd 100644 --- a/agent/relay_runtime.py +++ b/agent/relay_runtime.py @@ -692,16 +692,6 @@ class RelayRuntime: self._begin_operation() return RelayOperationLease(self) - def emit_mark(self, name: str, event: dict[str, Any], *, data: Any = None, metadata: Any = None) -> bool: - """Emit a mark parented to the Hermes session identified by ``event``.""" - session = self.ensure_session(event) - if session is None: - return False - self.run_in_session( - session, self.relay.scope.event, name, handle=session.handle, data=data, metadata=metadata, - ) - return True - def apply_tool_request_intercepts( self, *, session_id: str, tool_name: str, args: dict[str, Any] ) -> dict[str, Any]: @@ -1345,18 +1335,6 @@ def resolve_execution_context(session_id: str) -> tuple[RelayRuntime | None, Rel return runtime, session, None if session is None else session.handle -def emit_mark(name: str, *, session_id: str, data: Any = None, metadata: Any = None) -> bool: - """Emit a fail-open Relay mark under a Hermes session.""" - runtime = get_runtime(create=False) - if runtime is None: - return False - try: - return runtime.emit_mark(name, {"session_id": session_id}, data=data, metadata=metadata) - except Exception: - logger.warning("Hermes Relay mark failed: %s", name, exc_info=True) - return False - - def apply_tool_request_intercepts(*, session_id: str, tool_name: str, args: dict[str, Any]) -> dict[str, Any]: """Return Relay-rewritten arguments at Hermes's authorization boundary.""" if not session_id: diff --git a/tests/hermes_cli/test_relay_shared_metrics_runtime.py b/tests/hermes_cli/test_relay_shared_metrics_runtime.py index c800862ba0..5520ec8612 100644 --- a/tests/hermes_cli/test_relay_shared_metrics_runtime.py +++ b/tests/hermes_cli/test_relay_shared_metrics_runtime.py @@ -967,7 +967,6 @@ def test_core_runtime_is_fail_open_without_a_published_binding(monkeypatch, capl tool_name="terminal", args={"command": "true"}, ) == {"command": "true"} - assert not relay_runtime.emit_mark("hermes.probe", session_id="s1") assert "Hermes Relay runtime initialization failed" in caplog.text relay_runtime._reset_for_tests()