fix(telemetry): close the consent window on the config transition
Fourth independent review. Two more consent leaks, both reproduced through the real relay entry point before and after the fix. Both are failures of my own round-3 fix, which recorded revocation in the wrong place. BLOCKER 1 - revoking while idle recorded nothing. _record_revocation lived inside send_pending's loop, but _send_exported_packages returns early when send is false, before a sender is ever constructed. The dominant case is a user turning sending off while no pass is running, so the loop that was meant to observe the revocation could never run. Reproduced: 6 periods collected during a refused window were transmitted on re-enable. The window now closes on the observed config EDGE, before the early return. Last-seen send state is persisted because each hook fires in a fresh process, so a true->false transition is only visible by comparison. The rising edge also opens the window explicitly: the sender only runs when there is something to send, so a user who opts in and out before any package exists would otherwise have no window for record_revoked to close. BLOCKER 2 - turning COLLECTION off never recorded revocation. The not-enabled branch in setup.py force-set send=false and returned without calling _record_send_consent_change, so `hermes tools` -> disable shared metrics silently dropped consent while leaving the window open. Same retroactive release on re-enable. Both consent surfaces now record, and setup keeps the relay's edge detector in step. Also, from the same review's mutation sweep: - the scheme check is now pinned as an allowlist. Replacing the http test with `if True` survived the entire suite, because every non-http case targeted a REMOTE host where the loopback branch rejects anyway. Only a non-http scheme on loopback distinguishes the two. Shipped behaviour was already correct; nothing guarded it. - A.3 no longer claims rotation bounds long-term linkability outright. Measured against 11 real packages: resource is a stable low-entropy tuple and periods are contiguous across a rotation, so for a RARE configuration those can bridge windows. The honest claim is that rotation raises the cost, not that it makes correlation impossible. Two mutants are documented as unkillable rather than papered over with tests that only appear to cover them: the _defer clamp is unreachable from any current caller, and widening the falling-edge check to an unconditional else is behaviourally equivalent because record_revoked is idempotent and no-ops without an open window. An earlier version of the anti-spurious-revocation test could not fail either - it used a never-consented store, where record_revoked no-ops regardless. Rewritten to opt in, revoke, re-enable, and then assert that a steady enabled state does not re-close the reopened window. 259 tests pass. Staging E2E re-run: both packages 202.
This commit is contained in:
@@ -357,6 +357,21 @@ Rotation bounds long-term linkability without destroying short-term cohort
|
||||
analysis. A profile is one identity for the length of a window, and an
|
||||
unrelated identity after it.
|
||||
|
||||
**What rotation does not bound.** The identifier changes; the rest of the
|
||||
envelope does not. `resource` (`os_family`, `architecture`, `install_method`,
|
||||
`hermes_version`) is stable and low-entropy, and `period_start` /
|
||||
`period_end` are contiguous across a rotation boundary. For a common
|
||||
configuration this is no help to an observer — measured against the 11 real
|
||||
packages in a development outbox, every one shares the same
|
||||
`arm64 / macos / git` tuple. For a **rare** configuration it is a plausible
|
||||
re-identification aid: an unusual architecture or install method, combined
|
||||
with an uninterrupted daily period sequence, can bridge two windows. The
|
||||
claim this design makes is therefore "rotation raises the cost of long-term
|
||||
correlation", not "rotation makes it impossible". Narrowing that residue
|
||||
would mean coarsening `resource` or jittering period boundaries, and neither
|
||||
is worth the analytical loss today — but it should be a conscious decision,
|
||||
not an unexamined one.
|
||||
|
||||
### A.4 Reset behavior
|
||||
|
||||
Removing `$HERMES_HOME/telemetry/shared_metrics` still resets local identity,
|
||||
|
||||
Reference in New Issue
Block a user