ouyangbo/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 10 Packages Projects Releases Wiki Activity

fix(tools): every sandbox creator uses the shared container_config shaper (#76906, #87995, #84027, #100019)

Browse Source 
The prompt backend-probe and execute_code each kept a private (key, default) table for
container_config and drifted from the terminal tool's: the probe omitted docker_network, so
under docker_network: false it started a bridge-networked container; execute_code omitted
docker_extra_args, docker_forward_env and docker_env, so a sandbox created from that path
lost the operator's settings. Both now call terminal_tool_backends._container_config_from_config.

Salvaged from #62023 by @sagitario-jpn (the probe docker_network fix), widened to the whole class.
This commit is contained in:
Sagitario JPN
2026-09-05 18:25:05 +05:30
committed by kshitij
parent 41b88ba68a
commit 7cad5da0f0
2 changed files with 8 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/code_execution_tool.py
+4 -9
View File
@@ -394,17 +394,10 @@ def _call(tool_name, args):
# ---- Remote execution support (file-based RPC via terminal backend) ----
# execute_code's container_config keys (a subset of terminal_tool's; the create path fills the rest).
_CONTAINER_CONFIG_DEFAULTS = (
("container_cpu", 1), ("container_memory", 5120), ("container_disk", 51200), ("container_persistent", True),
("vercel_runtime", ""), ("docker_volumes", []), ("docker_run_as_host_user", False), ("docker_network", True),
)
def _get_or_create_env(task_id: str):
"""``(env, env_type)`` — the environment the terminal/file tools share for *task_id*, created on
first use (same double-checked per-task lock pattern as file_tools._get_file_ops)."""
from tools.terminal_tool_backends import _create_environment, _ssh_config_from_config
from tools.terminal_tool_backends import _container_config_from_config, _create_environment, _ssh_config_from_config
from tools.terminal_tool import (
_active_environments, _env_lock, _get_env_config, _last_activity,
_start_cleanup_thread, _creation_locks, _creation_locks_lock, _task_env_overrides,
@@ -431,7 +424,9 @@ def _get_or_create_env(task_id: str):
overrides = _task_env_overrides.get(effective_task_id, {})
container_config = None
if _is_container_backend(env_type):
container_config = {key: config.get(key, default) for key, default in _CONTAINER_CONFIG_DEFAULTS}
# Shared shaper: execute_code's own key subset dropped docker_extra_args / docker_forward_env /
# docker_env, so a sandbox created from this path lost the operator's configured settings.
container_config = _container_config_from_config(config)
logger.info("Creating new %s environment for execute_code task %s...",
env_type, effective_task_id[:8])
env = _create_environment(