diff --git a/tests/gateway/test_remote_media_fetch.py b/tests/gateway/test_remote_media_fetch.py new file mode 100644 index 0000000000..9398a783c6 --- /dev/null +++ b/tests/gateway/test_remote_media_fetch.py @@ -0,0 +1,92 @@ +"""MEDIA tags pointing into a remote terminal sandbox are fetched for delivery (#466). + +The host cannot see files an agent writes inside an ssh/modal/daytona sandbox, so +``filter_media_delivery_paths`` used to drop them silently. With a remote backend active the path is +pulled through the environment's ``fetch_file`` into the document cache — after the SAME denylist +the host applies, so a sandbox path (or a symlink) at ``~/.ssh/...`` never crosses. +""" + +from pathlib import Path + +import pytest + +import gateway.media_fetch as media_fetch +from gateway.platforms.base import BasePlatformAdapter +from tools.environments.base import BaseEnvironment, FileFetchError + + +class _FakeRemoteEnv: + """Stands in for a live SSHEnvironment: a tiny remote filesystem + symlink table.""" + + _remote_home = "/home/agent" + + def __init__(self): + self.files = {"/home/agent/out/report.txt": b"hello from sandbox", + "/home/agent/.ssh/id_rsa": b"SECRET"} + self.links = {"/home/agent/out/innocent.txt": "/home/agent/.ssh/id_rsa"} + self.fetched: list = [] + + def fetch_realpath(self, remote_path): + return self.links.get(remote_path, remote_path) + + def fetch_file(self, remote_path, local_dest, *, max_bytes): + self.fetched.append(remote_path) + if remote_path not in self.files: + raise FileFetchError("missing") + Path(local_dest).write_bytes(self.files[remote_path]) + + +@pytest.fixture +def remote_env(monkeypatch, tmp_path): + env = _FakeRemoteEnv() + monkeypatch.setattr(media_fetch, "_active_remote_env", lambda: env) + monkeypatch.setattr("gateway.platforms.base.DOCUMENT_CACHE_DIR", tmp_path / "cache" / "documents") + monkeypatch.setattr("gateway.platforms.base.MEDIA_DELIVERY_SAFE_ROOTS", (tmp_path / "cache" / "documents",)) + return env + + +def test_sandbox_artifact_is_fetched_but_credentials_and_symlinks_to_them_are_not(remote_env): + media = [("/home/agent/out/report.txt", False), ("/home/agent/out/innocent.txt", False), + ("/home/agent/.ssh/id_rsa", False), ("~/out/report.txt", False)] + delivered = BasePlatformAdapter.filter_media_delivery_paths(media) + + assert [Path(p).read_bytes() for p, _ in delivered] == [b"hello from sandbox", b"hello from sandbox"] + assert all(Path(p).name.endswith("_report.txt") for p, _ in delivered) + # The credential file and the symlink that resolves to it were refused BEFORE any bytes moved. + assert remote_env.fetched == ["/home/agent/out/report.txt", "/home/agent/out/report.txt"] + + +def test_local_backend_does_not_fetch(monkeypatch, tmp_path): + monkeypatch.setattr(media_fetch, "_active_remote_env", lambda: None) + assert BasePlatformAdapter.filter_media_delivery_paths([(str(tmp_path / "nope.txt"), False)]) == [] + + +class _ScriptedEnv(BaseEnvironment): + """Runs the fetch command through a real shell so the transport (marker fencing, in-sandbox + size bound, base64 round-trip) is exercised end to end.""" + + def __init__(self): + pass + + def cleanup(self): + pass + + def execute(self, command, cwd="", **kwargs): + import subprocess + proc = subprocess.run(["bash", "-c", command], capture_output=True, text=True) + return {"output": "echo login-noise\n" + proc.stdout + proc.stderr, "returncode": proc.returncode} + + +def test_fetch_file_round_trips_bytes_and_enforces_the_in_sandbox_size_cap(tmp_path): + src = tmp_path / "artifact.bin" + src.write_bytes(bytes(range(256)) * 40) + dest = tmp_path / "copy.bin" + env = _ScriptedEnv() + + env.fetch_file(str(src), dest, max_bytes=len(src.read_bytes())) + assert dest.read_bytes() == src.read_bytes() + + with pytest.raises(FileFetchError, match="exceeds"): + env.fetch_file(str(src), dest, max_bytes=100) + with pytest.raises(FileFetchError, match="could not read"): + env.fetch_file(str(tmp_path), dest, max_bytes=100) # a directory is not a regular file