From 9ce95929a27de239b65299754bfb0b10f555a3e2 Mon Sep 17 00:00:00 2001
From: teknium1 <teknium1@users.noreply.github.com>
Date: Tue, 1 Sep 2026 08:29:31 -0700
Subject: [PATCH] =?UTF-8?q?ci:=20re-enable=20the=20Desktop=20E2E=20lane=20?=
 =?UTF-8?q?=E2=80=94=20harness=20root-fixed=20by=20#99671?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The lane was disabled Aug 2 2026 (#76627) because the mock-backend
Electron window never got a title after the Aug 1 engines/npm churn
(#76499/#76562/#76575), failing every PR identically. #99671 fixed the
root cause: per-platform/layout Electron binary resolution in the e2e
harness (apps/desktop/e2e/electron-binary.ts). The suite is green again
on Node 26 + npm 12 — delete the temporary `false &&` guard and update
the stale comment block.

Fixes #76627
---
 .github/workflows/ci.yaml | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 2f3798346b..3cc6b24d62 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -122,14 +122,13 @@ jobs:
     # Tests-only PRs (~17% of commits) skip this 5-minute job — the longest
     # single job in the workflow — while still running the full pytest lanes.
     #
-    # ⛔ TEMPORARILY DISABLED (Aug 2, 2026, Teknium) — the suite is red on
-    # every PR and on main itself since the Aug 1 night engines/npm churn
-    # (#76499 → #76562 → #76575): the mock-backend Electron window never
-    # gets a title, so boot/chat/setup/interim specs all fail identically
-    # regardless of the PR's diff (verified on #76573 and the docs-only
-    # #76582). Tracking issue: #76627 (assigned: Ari). To re-enable,
-    # delete the `false &&` below — nothing else changed.
-    if: ${{ false && (needs.detect.outputs.python_prod == 'true' || needs.detect.outputs.frontend == 'true') }}
+    # Re-enabled (Sep 2026, #76627): the Aug 2 disable ("mock-backend
+    # Electron window never gets a title" after the Aug 1 engines/npm
+    # churn #76499/#76562/#76575) was root-fixed by #99671, which made
+    # the e2e harness resolve the Electron binary per platform/layout
+    # (apps/desktop/e2e/electron-binary.ts). The suite is green again on
+    # Node 26 + npm 12 — no runner rollback needed.
+    if: ${{ needs.detect.outputs.python_prod == 'true' || needs.detect.outputs.frontend == 'true' }}
     uses: ./.github/workflows/e2e-desktop.yml
 
   docs-site: