test(telegram): two invariant tests for JSON-string allowlists, under the plugin's test mirror

Trim the salvaged suite to the two invariants the fix guarantees: every Telegram allowlist key (the five `_extra_str_set` readers plus `ignored_threads`) decodes a JSON-encoded string and the group gate then admits the listed chat; comma strings, native lists and malformed JSON keep the legacy split. Moved from tests/gateway/ to tests/plugins/platforms/telegram/ to mirror the source path.
2026-09-13 12:38:55 -07:00
parent 5cc9b31b7a
commit a3b4d70ea2
2 changed files with 52 additions and 83 deletions
@@ -0,0 +1,52 @@
+"""``hermes config set telegram.allowed_chats '["a","b"]'`` stores a JSON-encoded *string*; every
+Telegram allowlist reader must decode it instead of comma-splitting the brackets onto the ids."""
+
+from types import SimpleNamespace
+
+from gateway.config import Platform, PlatformConfig
+
+
+def _adapter(extra):
+    from plugins.platforms.telegram.adapter import TelegramAdapter
+
+    adapter = object.__new__(TelegramAdapter)
+    adapter.platform = Platform.TELEGRAM
+    adapter.config = PlatformConfig(enabled=True, token="***", extra=extra)
+    adapter._bot = SimpleNamespace(id=999, username="hermes_bot")
+    return adapter
+
+
+def _group_msg(chat_id):
+    return SimpleNamespace(
+        message_id=42, text="hello", caption=None, entities=[], caption_entities=[],
+        message_thread_id=None, reply_to_message=None, date=None,
+        chat=SimpleNamespace(id=chat_id, type="group", title="G", is_forum=False),
+        from_user=SimpleNamespace(id=111, full_name="A B", first_name="A"),
+    )
+
+
+def test_json_string_allowlists_decode_across_every_key():
+    adapter = _adapter({
+        "allowed_chats": '["-100","-200"]',
+        "group_allowed_chats": '["-300"]',
+        "allowed_topics": '["5"]',
+        "free_response_chats": '["-400"]',
+        "free_response_topics": '["-100:3"]',
+        "ignored_threads": '["7", "9"]',
+    })
+    assert adapter._telegram_allowed_chats() == {"-100", "-200"}
+    assert adapter._telegram_group_allowed_chats() == {"-300"}
+    assert adapter._telegram_allowed_topics() == {"5"}
+    assert adapter._telegram_free_response_chats() == {"-400"}
+    assert adapter._telegram_free_response_topics() == {"-100:3"}
+    assert adapter._telegram_ignored_threads() == {7, 9}
+    # The user-visible symptom: a JSON-string allowlist dropped every group message.
+    gated = _adapter({"allowed_chats": '["-100","-200"]'})
+    assert gated._should_process_message(_group_msg(-100)) is True
+    assert gated._should_process_message(_group_msg(-999)) is False
+
+
+def test_comma_and_malformed_strings_keep_the_legacy_split():
+    assert _adapter({"allowed_chats": "-100, -200"})._telegram_allowed_chats() == {"-100", "-200"}
+    assert _adapter({"allowed_chats": ["-100", "-200"]})._telegram_allowed_chats() == {"-100", "-200"}
+    assert _adapter({"allowed_chats": '["-100", "-200'})._telegram_allowed_chats() == {'["-100"', '"-200'}