ouyangbo/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 9 Packages Projects Releases Wiki Activity

Merge updated model metrics into tool metrics

Browse Source 
# Conflicts:
#	hermes_cli/observability/shared_metrics_contract.py
#	hermes_cli/observability/shared_metrics_subscriber.py
#	scripts/smoke_nemo_relay_shared_metrics.py
#	tests/hermes_cli/test_plugins.py
#	tests/hermes_cli/test_relay_shared_metrics.py
#	tests/hermes_cli/test_relay_shared_metrics_runtime.py
#	tests/run_agent/test_run_agent.py
#	tests/test_model_tools.py
#	tests/tools/test_approval.py
This commit is contained in:
Alex Fournier
2026-07-31 07:18:02 -07:00
parent 8502e464a8 0558ea0c48
commit aef76ba398
2642 changed files with 61174 additions and 392094 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/tools/test_request_tool_approval.py
-34
View File
@@ -95,32 +95,6 @@ class TestRequestToolApproval:
assert calls["session"] == ["plugin_rule:ssh-writes"]
assert calls["permanent"] == [] # session != always
def test_cli_always_persists_permanent(self, monkeypatch):
monkeypatch.setattr(approval, "_is_interactive_cli", lambda: True)
monkeypatch.setattr(approval, "_is_gateway_approval_context", lambda: False)
monkeypatch.setattr(approval, "prompt_dangerous_approval", lambda *a, **k: "always")
persisted = {}
monkeypatch.setattr(approval, "approve_session", lambda sk, pk: None)
monkeypatch.setattr(approval, "approve_permanent",
lambda pk: persisted.setdefault("key", pk))
monkeypatch.setattr(approval, "save_permanent_allowlist",
lambda x: persisted.setdefault("saved", True))
res = request_tool_approval("write_file", "reason", rule_key="ssh-writes")
assert res["approved"] is True
assert persisted["key"] == "plugin_rule:ssh-writes"
assert persisted["saved"] is True
def test_gateway_path_submits_pending_and_defers(self, monkeypatch):
monkeypatch.setattr(approval, "_is_interactive_cli", lambda: False)
monkeypatch.setattr(approval, "_is_gateway_approval_context", lambda: True)
submitted = {}
monkeypatch.setattr(approval, "submit_pending",
lambda sk, data: submitted.update(data))
res = request_tool_approval("browser_navigate", "external URL",
rule_key="ext-nav")
assert res["approved"] is False
assert res["status"] == "approval_required"
assert submitted["pattern_key"] == "plugin_rule:ext-nav"
def test_cron_deny_mode_blocks(self, monkeypatch):
monkeypatch.setattr(approval, "_is_interactive_cli", lambda: False)
@@ -141,14 +115,6 @@ class TestRequestToolApproval:
res = request_tool_approval("terminal", "smtp send")
assert res["approved"] is True
def test_rule_key_derived_from_tool_and_reason(self, monkeypatch):
"""With no explicit rule_key, the pattern key is derived from
tool + a hash of the reason (so distinct reasons persist apart)."""
monkeypatch.setattr(approval, "_is_interactive_cli", lambda: True)
monkeypatch.setattr(approval, "_is_gateway_approval_context", lambda: False)
monkeypatch.setattr(approval, "prompt_dangerous_approval", lambda *a, **k: "deny")
res = request_tool_approval("patch", "reason") # no rule_key
assert res["pattern_key"].startswith("plugin_rule:patch:")
def test_distinct_reasons_get_distinct_keys(self, monkeypatch):
"""Two different reasons on the SAME tool must not share an [a]lways