fix(ci): review comment poller deadlocked on its own run

The poller job set GITHUB_RUN_ID in env: to point at the CI run. The Actions runner sets the GITHUB_* defaults itself and ignores the override. Thus the poller read its own run id and watched itself. Its own run stays in_progress while the poller runs, so runs_all_completed() was never true. The comment froze at 'waiting for jobs to start' and the job burned its full 3000s timeout on every PR. Rename the variable to CI_RUN_ID. Also drop the GITHUB_REPOSITORY override — it was a no-op for the same reason, and the runner default already holds the correct value.
2026-08-10 12:52:53 -04:00
parent 7e04718ec3
commit d5ddd442d7
2 changed files with 15 additions and 7 deletions
@@ -58,9 +58,12 @@ jobs:
      - name: Run live comment poller
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          GITHUB_REPOSITORY: ${{ github.repository }}
-          # The CI run to report on — not this run.
-          GITHUB_RUN_ID: ${{ github.event.workflow_run.id }}
+          # The CI run to report on — not this run. The name must not be
+          # GITHUB_RUN_ID: the runner sets the GITHUB_* defaults itself and
+          # ignores an env: override, so that name silently resolves to THIS
+          # run. The poller then watches itself, which stays in_progress for
+          # as long as the poller runs, and it waits out its whole timeout.
+          CI_RUN_ID: ${{ github.event.workflow_run.id }}
          # Sibling runs for the same commit that the comment also covers,
          # one workflow name per line (a name can contain a comma).
          # The poller resolves each name to its runs through the API.