From fae8e27a49136f758f5f3edeed29be451b1a2a06 Mon Sep 17 00:00:00 2001 From: Brooklyn Nicholson Date: Tue, 18 Aug 2026 06:09:11 -0500 Subject: [PATCH] fmt(desktop): eslint --fix import and JSX-prop ordering --- apps/desktop/electron/main.ts | 4 ++-- .../right-rail/preview-browser-bar.test.tsx | 1 + .../app/chat/right-rail/preview-pane.test.tsx | 2 +- .../src/app/chat/right-rail/preview-pane.tsx | 3 ++- apps/desktop/src/lib/external-link.tsx | 22 +++++++++---------- 5 files changed, 17 insertions(+), 15 deletions(-) diff --git a/apps/desktop/electron/main.ts b/apps/desktop/electron/main.ts index 77ab9d313d..be2bf019d8 100644 --- a/apps/desktop/electron/main.ts +++ b/apps/desktop/electron/main.ts @@ -14,6 +14,7 @@ import { clipboard, dialog, net as electronNet, + webContents as electronWebContents, globalShortcut, ipcMain, Menu, @@ -26,8 +27,7 @@ import { screen, session, shell, - systemPreferences, - webContents as electronWebContents + systemPreferences } from 'electron' import nodePty from 'node-pty' diff --git a/apps/desktop/src/app/chat/right-rail/preview-browser-bar.test.tsx b/apps/desktop/src/app/chat/right-rail/preview-browser-bar.test.tsx index 9f3da95489..e35ed0936f 100644 --- a/apps/desktop/src/app/chat/right-rail/preview-browser-bar.test.tsx +++ b/apps/desktop/src/app/chat/right-rail/preview-browser-bar.test.tsx @@ -112,6 +112,7 @@ describe('PreviewBrowserBar', () => { it('toggles the console and DevTools, and labels them by current state', () => { const onToggleConsole = vi.fn() const onToggleDevTools = vi.fn() + const rendered = render( ) diff --git a/apps/desktop/src/app/chat/right-rail/preview-pane.test.tsx b/apps/desktop/src/app/chat/right-rail/preview-pane.test.tsx index a35f4e4ae7..8d04b08c18 100644 --- a/apps/desktop/src/app/chat/right-rail/preview-pane.test.tsx +++ b/apps/desktop/src/app/chat/right-rail/preview-pane.test.tsx @@ -3,8 +3,8 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' import { $connection } from '@/store/session' -import { PreviewPane } from './preview-pane' import { forgetPreviewConsole, previewConsoleState } from './preview-console-store' +import { PreviewPane } from './preview-pane' function stubPdfObjectUrls() { const NativeUrl = URL diff --git a/apps/desktop/src/app/chat/right-rail/preview-pane.tsx b/apps/desktop/src/app/chat/right-rail/preview-pane.tsx index b614b266ee..813f560ff5 100644 --- a/apps/desktop/src/app/chat/right-rail/preview-pane.tsx +++ b/apps/desktop/src/app/chat/right-rail/preview-pane.tsx @@ -25,8 +25,8 @@ import { import { type ConsoleEntry } from './preview-console-state' import { previewConsoleState } from './preview-console-store' import { LocalFilePreview, PreviewEmptyState } from './preview-file' -import { registerPreviewPageReader } from './preview-reader' import { PREVIEW_BROWSER_ATTR, registerPreviewNav } from './preview-nav' +import { registerPreviewPageReader } from './preview-reader' type PreviewWebview = HTMLElement & { canGoBack?: () => boolean @@ -676,6 +676,7 @@ export function PreviewPane({ embedded = false, onRestartServer, reloadRequest = // buttons can't be left stale. syncHistory() } + // The WEBVIEW is the source of truth for DevTools, not our click handler: // closing the DevTools window itself fires devtools-closed with no click, // and the glyph was left stuck "on" when we tracked it locally. diff --git a/apps/desktop/src/lib/external-link.tsx b/apps/desktop/src/lib/external-link.tsx index 9a284f672b..f586a63a21 100644 --- a/apps/desktop/src/lib/external-link.tsx +++ b/apps/desktop/src/lib/external-link.tsx @@ -284,17 +284,6 @@ export function ExternalLink({ { - event.stopPropagation() - onClick?.(event) - - if (event.defaultPrevented) { - return - } - - event.preventDefault() - openLink(target, { native: wantsNativeBrowser(event.nativeEvent) }) - }} // Middle-click never fires `click`; it's the other half of the // open-elsewhere convention, so it has to be caught on its own. onAuxClick={event => { @@ -306,6 +295,17 @@ export function ExternalLink({ event.stopPropagation() openExternalLink(target) }} + onClick={event => { + event.stopPropagation() + onClick?.(event) + + if (event.defaultPrevented) { + return + } + + event.preventDefault() + openLink(target, { native: wantsNativeBrowser(event.nativeEvent) }) + }} rel="noopener noreferrer" target="_blank" {...rest}