hermes-agent

ouyangbo/hermes-agent

Fork 0

Commit Graph

Author	SHA1	Message	Date
fangliquanflq	37411f349a	fix(auth): rotate credentials for named custom providers after 401/429 Salvage of #93214 (5 commits squashed onto current main; agent_runtime_helpers.py diverged since the PR base and was 3-way reapplied). The credential-rotation guard in recover_with_credential_pool and both restore_primary_runtime paths only tolerated the custom-naming split when the agent carried the literal label 'custom', so a named custom provider (agent.provider='gemini-no-filter', pool 'custom:gemini-no-filter') tripped the mismatch guard and skipped rotation on every 401/429. Now all three guard sites use the canonical credential_pool_matches_provider boundary predicate + resolve_runtime_pool_key, which recognizes configured named-custom aliases and validates endpoints. Fixes #93188.	2026-08-23 20:01:18 -07:00
Teknium	6b81590c55	test: prune low-value tests suite-wide (wave 1) — 46,820 → 28,106 test functions Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).	2026-07-29 13:10:23 -07:00
Teknium	3803e5fc28	fix(agent): don't treat custom:<name> pools as cross-provider mismatch (#45289 ) Custom endpoints carry two naming conventions for the same provider: the agent's provider attribute is the generic 'custom' label while the pool is keyed 'custom:<normalized-name>'. The defensive guard in recover_with_credential_pool compared them literally, logged 'Credential pool provider mismatch: pool=custom:<name>, agent=custom', and skipped recovery — so 401 refresh and 429 rotation never ran for ANY custom-provider user (seen in the field on a Fireworks setup whose dead key burned full retry cycles every turn with the skip warning on each one). Accept the pair only when the agent's CURRENT base_url resolves to the same pool key via get_custom_provider_pool_key, preserving the guard's original purpose (#33088/#33163): a fallback provider or a different custom endpoint still skips pool mutation.	2026-06-13 02:01:09 -07:00

Author

SHA1

Message

Date

fangliquanflq

37411f349a

fix(auth): rotate credentials for named custom providers after 401/429

Salvage of #93214 (5 commits squashed onto current main; agent_runtime_helpers.py
diverged since the PR base and was 3-way reapplied). The credential-rotation
guard in recover_with_credential_pool and both restore_primary_runtime paths
only tolerated the custom-naming split when the agent carried the literal label
'custom', so a named custom provider (agent.provider='gemini-no-filter', pool
'custom:gemini-no-filter') tripped the mismatch guard and skipped rotation on
every 401/429. Now all three guard sites use the canonical
credential_pool_matches_provider boundary predicate + resolve_runtime_pool_key,
which recognizes configured named-custom aliases and validates endpoints.

Fixes #93188.

2026-08-23 20:01:18 -07:00

Teknium

6b81590c55

test: prune low-value tests suite-wide (wave 1) — 46,820 → 28,106 test functions

Systematic prune per AGENTS.md test policy, one pass over every major
test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli,
cron, tui_gateway, honcho/openviking, root-level):

- DELETE: source-reading tests (read_text/getsource on prod files),
  change-detector tests (exact catalog counts, model-name snapshots,
  config version literals), mock-echo tests (assert a mock returns what
  it was told), assertion-free/trivial tests, near-duplicate
  parametrizations (boundaries + one representative kept), async/sync
  twin duplicates, cosmetic within-file variations.
- KEEP (mandatory): security/redaction/approval guards, message-role
  alternation invariants, prompt-caching/deterministic-call-id
  invariants, issue-number regression tests (deduped), E2E tests.
- 6 test files deleted outright (script-style/no-assert or fully
  redundant); conftest.py, fakes/, fixtures/ untouched.
- tests/acp/conftest.py added: autouse fixture stubs the live
  models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server
  tests performed on every session create — test_server.py 147s → 3.4s,
  and the tests are now genuinely hermetic.
- Sleep-based slowness shrunk where safe (codex_ttfb_watchdog,
  compression_concurrent_fork, etc.); no wall-clock assertion tightened.

Verification: full hermetic suite via scripts/run_tests.sh —
2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall
(baseline: 583s wall, 13,564s subprocess CPU).

2026-07-29 13:10:23 -07:00

Teknium

3803e5fc28

fix(agent): don't treat custom:<name> pools as cross-provider mismatch (#45289 )

Custom endpoints carry two naming conventions for the same provider: the
agent's provider attribute is the generic 'custom' label while the pool
is keyed 'custom:<normalized-name>'. The defensive guard in
recover_with_credential_pool compared them literally, logged
'Credential pool provider mismatch: pool=custom:<name>, agent=custom',
and skipped recovery — so 401 refresh and 429 rotation never ran for
ANY custom-provider user (seen in the field on a Fireworks setup whose
dead key burned full retry cycles every turn with the skip warning on
each one).

Accept the pair only when the agent's CURRENT base_url resolves to the
same pool key via get_custom_provider_pool_key, preserving the guard's
original purpose (#33088/#33163): a fallback provider or a different
custom endpoint still skips pool mutation.

2026-06-13 02:01:09 -07:00

3 Commits