e83816a4d1
review-fix(comments): restore lost #NNNN rationale comments across non-test source (mechanical sweep, condensed, code unchanged)
...
For each issue anchor present in BASE 63279301bc
2026-09-03 09:44:26 -07:00
fd1a0594c1
refactor(tui_gateway): X2 wave3 — compute_host guarded frame handlers + session-build split, groups profile/kwargs folds, project_tree placement/auto-bucket compaction, projects row/policy folds, entry+oauth plumbing trims (2653->2437 LOC)
2026-09-03 04:15:06 -07:00
b279e45d7c
refactor(tui_gateway): entry discovery spawn helper, row/kwargs table tightening
...
- entry: _spawn_discovery + logged _mcp_startup_call replace the two duplicated
start_background_mcp_discovery try/except blocks (same log levels + messages);
docstrings/comments compacted keeping every signal/thread WHY.
- methods_projects/agent_callbacks: _project_tree_row and preview kwargs tightened.
Goldens identical; WIRE-PARITY-OK.
2026-09-03 00:05:29 -07:00
de227bdc34
refactor(tui_gateway): final compaction pass on r3-36 group G
...
- mcp_oauth_sessions: lift the probe+rollback block out of _worker (_probe_with_rollback).
- project_tree: lane group built from a field table; stamp_profile/_lane_key/_disambiguate
flattening. methods_projects: policy loader + scan loop tightened. agent_callbacks:
preview-history filter via _PREVIEW_HISTORY_ROLES. Blank-line squeeze after in-body
lazy imports (AST-identical). All goldens identical; WIRE-PARITY-OK.
2026-09-02 23:54:51 -07:00
aef127ad46
refactor(tui_gateway): projects mutator table, mcp_startup call helper, kwargs table in agent_callbacks
...
- methods_projects: update/add_folder/remove_folder/set_primary handlers registered from a
_PROJECT_MUTATORS table (same @method names, same 5062/5063/5061 mapping); _pick() for
params->kwargs; old-vs-new RPC golden (27 calls incl. error paths) identical.
- entry: _mcp_startup_call() replaces 5 lazy import+try/except ladders on hermes_cli.mcp_startup
(tests monkeypatch mcp_startup module attrs — still resolved at call time).
- agent_callbacks: _background_agent_kwargs built from key tables; drop unused _registry.
- docstring compaction (module docstrings <= 8 lines, WHYs kept).
WIRE-PARITY-OK.
2026-09-02 23:44:18 -07:00
79d0d3b600
refactor(tui_gateway): compact project_tree/methods_projects/agent_callbacks/entry/mcp_oauth_sessions (-16%)
...
- project_tree: split build_tree (207 LOC) into _auto_buckets/_home_project phase helpers;
_field() replaces 9 '(x.get(k) or "").strip()' ladders; _project_node takes wire-shaped
**flags; drop unused placement 'repo_path' and _strip_trailing_sep; _FolderIndex/
_project_for_session collapsed. Old-vs-new golden (67 synthetic build_tree runs) identical.
- methods_projects: _project_ok/_path_param unify 4 handler tails; _project_tree_row via
dict comprehensions; discovered-cache read via contextlib.nullcontext; policy loader
helpers. Golden over rows/policy/junk predicates identical.
- agent_callbacks: subagent mirror dispatch on a delta table; drop _render_personality_prompt
(single caller); getattr shorthand in _background_agent_kwargs.
- entry: _write_or_exit unifies 3 write-fail exits; suppress(); heartbeat/sweep start loop.
- mcp_oauth_sessions: suppress(), gc/listener/redirect compaction, docstrings.
WIRE-PARITY-OK; tests green.
2026-09-02 23:24:24 -07:00
646aae4ba6
refactor(tui): move the projects RPC surface (workspaces, repo discovery, sidebar tree) out of server.py into methods_projects.py
2026-09-02 14:09:13 -07:00
Teknium