53db597201
simplify(compat): hermes_state — drop 81 re-exports + 3 registry aliases + 3 shims, repoint 45 callers + 60 test files
...
hermes_state.py: delete every '# noqa: F401 (re-exported...)' import block (hermes_state_common/errors/guard/
readpool/sessions/fts/dbfile/wal/repair/registry + agent.context_compressor _DB_PERSISTED_MARKER_KEY); keep
only the names hermes_state.py itself uses, without noqa.
hermes_state_registry.py: drop get_shared_session_db/release_shared_session_db/close_shared_session_dbs
aliases; every caller (gateway/, tools/, tui_gateway/, cron/, mcp_serve, run_agent, tests) now imports
acquire/release/close_all/release_or_close from hermes_state_registry.
hermes_state_titles.py: drop set_auto_title_if_empty shim (title_generator keeps its getattr fallback).
Re-remove shim-only names restored by 34abf954bd
2026-09-03 13:46:50 -07:00
e83816a4d1
review-fix(comments): restore lost #NNNN rationale comments across non-test source (mechanical sweep, condensed, code unchanged)
...
For each issue anchor present in BASE 63279301bc
2026-09-03 09:44:26 -07:00
36b7fe14ee
refactor(state): hand-compact remaining long docstrings (all invariants kept)
2026-09-02 20:12:31 -07:00
28eb24eb3a
refactor(state): reflow full-line comment paragraphs to the 108-col budget (word-preserving)
2026-09-02 19:59:11 -07:00
2865973f9e
refactor(state): hoist chain-step SQL, fold cooldown/number readers in compression mixin
2026-09-02 19:53:54 -07:00
f731c63e89
refactor(state): drop blank separators around nested _do txn closures
2026-09-02 19:47:36 -07:00
3c615c48e9
refactor(state): AST-neutral bracket/string-literal layout pass on the six mixin modules
2026-09-02 19:45:18 -07:00
4de8710b74
refactor(state): unify _placeholders/_ended_by_compression/row-probe SQL into hermes_state_common
2026-09-02 19:43:49 -07:00
7d48a84acf
refactor(state): reflow prose docstrings to the 108-col budget (word-preserving)
2026-09-02 19:39:50 -07:00
af85e7c644
refactor(state): compact SessionGatewayMixin/SessionCompressionMixin — compose fail_handoff/lineage SQL, unify set_* writers, trim docstrings
2026-09-02 19:21:56 -07:00
831f2e542c
refactor(state): fold small get_messages/reaction/publish shapes; hug trailing closers (AST-identical)
2026-09-02 17:20:16 -07:00
1991695511
refactor(state): _cooldown_row shape helper; per-model usage kwargs via field set; small folds
2026-09-02 17:17:16 -07:00
8656cc31f2
refactor(state): table-driven _rows_to_conversation column copy; unify tool-call counting; collapse defensive locals
2026-09-02 16:59:58 -07:00
f54075e0bb
refactor(state): unify lock/lease claim (_claim_lease_row); finalize_orphaned via _write_rowcount
2026-09-02 16:52:21 -07:00
52d982281c
refactor(state): _stale_holder guard helper; join implicit-concat SQL fragments (AST-identical)
2026-09-02 16:44:38 -07:00
0d7acf67b5
refactor(state): pack hanging signatures/tuples in messages/compression/usage (AST-identical)
2026-09-02 16:38:21 -07:00
5c3acca66b
refactor(state): resume — verified messages/compression/titles/usage simplification
2026-09-02 16:37:21 -07:00
d15c61b5dc
refactor(state): split SessionDB into domain mixins and free-function modules; unify SQL boilerplate
...
hermes_state.py 17,220 -> 6,442 LOC. Behavior-neutral: every moved body is
AST-identical to the original, verified per extraction.
SessionDB core
- _write_sql / _write_rowcount / _read_one / _read_all replace ~120 copies of
the `def _do(conn): conn.execute(...)` + `_execute_write(_do)` and
`with self._read_ctx() as conn: row = conn.execute(...).fetchone()` shapes.
- _set_lineage_column replaces four copies of the recursive compression-lineage
UPDATE (archived / pinned / hidden / last_read_at).
- _read_session_number unifies the three compression counter readers.
- Dead (zero refs repo-wide): restore_rewound, delete_gateway_routing_entries,
_is_duplicate_replayed_user_message, SessionPortabilityMixin.get_first_assistant_text.
New mixins bound onto SessionDB via the MRO (logger name stays "hermes_state"):
hermes_state_messages SessionMessagesMixin 48 methods
hermes_state_compression SessionCompressionMixin 30
hermes_state_gateway SessionGatewayMixin 26
hermes_state_maintenance SessionMaintenanceMixin 13
hermes_state_usage SessionUsageMixin 12
hermes_state_titles SessionTitlesMixin 13
hermes_state_telegram SessionTelegramTopicsMixin 11
Origin-internal symbols resolve through a lazy `from hermes_state import ...`
inside the few methods that need them (no import cycle).
New free-function modules, every name re-imported into hermes_state so
`hermes_state.<name>` (and test monkeypatches on it) keep working; intra-module
calls to patched helpers go through the lazy origin import:
hermes_state_repair repair/backup/preflight (43 defs)
hermes_state_wal journal-mode / PRAGMA policy (33 defs)
hermes_state_dbfile header probes, zeroed-db quarantine, stats, holders (21 defs)
Existing mixins: search — shared FTS MATCH/LIKE builders, unified rebuild
status/step/finish engines, state_meta helpers; schema — one legacy/v23 FTS init
branch, shared _live_pk_columns, Row/tuple dual access dropped; portability —
shared _PREVIEW_RAW_SUBQUERY_SQL and _rich_row; common — single
stat_db_file_identity (was 3 copies), AUTO_VACUUM_MIN_FREELIST_RATIO.
Docstrings/comments hand-compacted (AST-identical) keeping every invariant,
ordering rule, failure mode and WHY. Schema SQL, migration order and PRAGMAs
untouched. test_repair_path_has_no_bare_connects repointed to hermes_state_repair.
2026-09-02 13:32:13 -07:00
Teknium