Commit Graph

9 Commits

Author SHA1 Message Date
Teknium 14791b4d4e simplify(compat): approval — drop 43 facade re-exports + _command_detection_variants late-bind seam, repoint 30 callers + 46 test files
tools/approval.py no longer re-exports sibling names (approval_context/prompt/floors/detection/
human_wait/smart/gateway_wait); it imports only what it uses. Siblings reference sibling-defined
names directly (module-attribute reads on tools.approval_context so patching the defining module
still works); only facade-owned state (_lock, _gateway_queues, _permanent_approved, _denied,
_denial_breaker_addendum, _gateway_notify_cb) is still read back through tools.approval.
approval_detection calls its own _command_detection_variants instead of late-binding through the facade.
2026-09-03 13:49:57 -07:00
Teknium e83816a4d1 review-fix(comments): restore lost #NNNN rationale comments across non-test source (mechanical sweep, condensed, code unchanged)
For each issue anchor present in BASE 63279301bc non-test .py and absent on HEAD, the BASE comment/docstring block was re-attached at the HEAD location of the code it explained (matched by the distinctive code line / enclosing def). Sentences already covered by an existing HEAD comment were deduped; the issue number always survives. Insert-only: no code lines changed.
2026-09-03 09:44:26 -07:00
Teknium bcb9c63fc1 refactor(approval): AST-identical re-layout of leaf modules to 118 cols 2026-09-02 23:11:37 -07:00
Teknium 146323d2a1 refactor(approval): reflow comment blocks to 118 cols (word-identical, AST-identical) 2026-09-02 22:56:13 -07:00
Teknium 4a37db2269 refactor(approval): compact leaf docstrings/comments by hand, keep every invariant (1375->1310) 2026-09-02 21:51:25 -07:00
Teknium 16056b5d51 refactor(approval): densify leaf call sites and signatures, drop single-pass prompt loop (1462->1375) 2026-09-02 21:27:32 -07:00
Teknium aad348ce5e refactor(approval): share hardline RECOVERY prefix, fold allowlist scanner branches, inline smart observer hooks (249+211->228+164) 2026-09-02 21:06:19 -07:00
Teknium 325a505602 refactor(approval): move smart-verdict observer + elicitation consent to their leaf modules; hoist re-exports 2026-09-02 16:42:18 -07:00
Teknium 5c919161d0 refactor(tools/approval): split approval.py into smart/human-wait/gateway-wait modules; dedupe guards 2026-09-02 14:44:14 -07:00