hermes-agent

ouyangbo/hermes-agent

Fork 0

Commit Graph

Author	SHA1	Message	Date
Teknium	13fb87af92	refactor(cron): decompose scheduler run_job/_deliver_result and dedupe delivery lanes cron/scheduler.py (8535 -> 6353): - _deliver_result split into per-target helpers: _resolve_target_transport (live/relay/standalone transport + enablement), _deliver_via_live_adapter (_live_route_metadata for Telegram DM-topic vs forum routing, _live_send_text with the cancel()-based timeout disambiguation, _live_send_media, _seed_live_delivery_sessions), _standalone_send/_deliver_standalone. The three interpreter-shutdown skip branches and the repeated log+append+continue pattern collapse into one _note_target_error / one shutdown message; _TargetDelivery carries per-target state. - Thread/channel session seeding unified into _seed_cron_session (was two near-identical functions). - run_job decomposed into _run_no_agent_job, _apply_monitor_gate, _load_cron_job_config (_CronJobConfig), _resolve_job_runtime, _check_model_drift, _open_cron_session_db, _run_agent_with_watchdog, _finalize_cron_session, plus one _run_doc_header and one _audit closure for the success/failure paths. - _run_one_job_body: ownership-lost bookkeeping, delivery composition and outcome classification extracted; tick: _acquire_tick_lock/_release_tick_lock, _maybe_reap_dead_owners, _sweep_stale_inflight_for_tick, _process_due_job, _submit_with_guard. - _build_job_prompt: context_from injection and skill loading extracted; one _prepend_context_block for the four fenced-data blocks. - One _start_heartbeat_thread for the script- and fire-claim heartbeat threads. - Dropped unreachable return in SharedRouteAdapters.get; boolean-return and nested-if shapes collapsed. - Comments/docstrings compacted by hand, rationale kept (fd-leak reason for the late SessionDB close callback, title-persistence rules, no_agent classification gate, inactivity-vs-provider timeout ordering, stale-claim force-release, interruption token keying).	2026-09-02 13:31:43 -07:00
Teknium	6b81590c55	test: prune low-value tests suite-wide (wave 1) — 46,820 → 28,106 test functions Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).	2026-07-29 13:10:23 -07:00
HexLab98	6d9eff28b7	test(cron): cover the interpreter-shutdown scheduling guard (#58720 ) Pins `_interpreter_shutting_down()` (finalizing flag + shutdown-error-text fallback) and asserts the standalone delivery path skips gracefully without scheduling a send when the interpreter is finalizing, while the normal non-finalizing path still delivers. Source guardrails keep the guard wired into both the dispatch (`_submit_with_guard`) and standalone-delivery sites.	2026-07-06 02:05:46 +05:30

Author

SHA1

Message

Date

Teknium

13fb87af92

refactor(cron): decompose scheduler run_job/_deliver_result and dedupe delivery lanes

cron/scheduler.py (8535 -> 6353):
- _deliver_result split into per-target helpers: _resolve_target_transport (live/relay/standalone
  transport + enablement), _deliver_via_live_adapter (_live_route_metadata for Telegram DM-topic
  vs forum routing, _live_send_text with the cancel()-based timeout disambiguation,
  _live_send_media, _seed_live_delivery_sessions), _standalone_send/_deliver_standalone. The
  three interpreter-shutdown skip branches and the repeated log+append+continue pattern collapse
  into one _note_target_error / one shutdown message; _TargetDelivery carries per-target state.
- Thread/channel session seeding unified into _seed_cron_session (was two near-identical
  functions).
- run_job decomposed into _run_no_agent_job, _apply_monitor_gate, _load_cron_job_config
  (_CronJobConfig), _resolve_job_runtime, _check_model_drift, _open_cron_session_db,
  _run_agent_with_watchdog, _finalize_cron_session, plus one _run_doc_header and one _audit
  closure for the success/failure paths.
- _run_one_job_body: ownership-lost bookkeeping, delivery composition and outcome classification
  extracted; tick: _acquire_tick_lock/_release_tick_lock, _maybe_reap_dead_owners,
  _sweep_stale_inflight_for_tick, _process_due_job, _submit_with_guard.
- _build_job_prompt: context_from injection and skill loading extracted; one
  _prepend_context_block for the four fenced-data blocks.
- One _start_heartbeat_thread for the script- and fire-claim heartbeat threads.
- Dropped unreachable return in SharedRouteAdapters.get; boolean-return and nested-if shapes
  collapsed.
- Comments/docstrings compacted by hand, rationale kept (fd-leak reason for the late SessionDB
  close callback, title-persistence rules, no_agent classification gate, inactivity-vs-provider
  timeout ordering, stale-claim force-release, interruption token keying).

2026-09-02 13:31:43 -07:00

Teknium

6b81590c55

test: prune low-value tests suite-wide (wave 1) — 46,820 → 28,106 test functions

Systematic prune per AGENTS.md test policy, one pass over every major
test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli,
cron, tui_gateway, honcho/openviking, root-level):

- DELETE: source-reading tests (read_text/getsource on prod files),
  change-detector tests (exact catalog counts, model-name snapshots,
  config version literals), mock-echo tests (assert a mock returns what
  it was told), assertion-free/trivial tests, near-duplicate
  parametrizations (boundaries + one representative kept), async/sync
  twin duplicates, cosmetic within-file variations.
- KEEP (mandatory): security/redaction/approval guards, message-role
  alternation invariants, prompt-caching/deterministic-call-id
  invariants, issue-number regression tests (deduped), E2E tests.
- 6 test files deleted outright (script-style/no-assert or fully
  redundant); conftest.py, fakes/, fixtures/ untouched.
- tests/acp/conftest.py added: autouse fixture stubs the live
  models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server
  tests performed on every session create — test_server.py 147s → 3.4s,
  and the tests are now genuinely hermetic.
- Sleep-based slowness shrunk where safe (codex_ttfb_watchdog,
  compression_concurrent_fork, etc.); no wall-clock assertion tightened.

Verification: full hermetic suite via scripts/run_tests.sh —
2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall
(baseline: 583s wall, 13,564s subprocess CPU).

2026-07-29 13:10:23 -07:00

HexLab98

6d9eff28b7

test(cron): cover the interpreter-shutdown scheduling guard (#58720 )

Pins `_interpreter_shutting_down()` (finalizing flag + shutdown-error-text
fallback) and asserts the standalone delivery path skips gracefully without
scheduling a send when the interpreter is finalizing, while the normal
non-finalizing path still delivers. Source guardrails keep the guard wired
into both the dispatch (`_submit_with_guard`) and standalone-delivery sites.

2026-07-06 02:05:46 +05:30

3 Commits