39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
84 lines
2.3 KiB
Python
84 lines
2.3 KiB
Python
import base64
|
|
|
|
import pytest
|
|
from acp.schema import (
|
|
BlobResourceContents,
|
|
EmbeddedResourceContentBlock,
|
|
ImageContentBlock,
|
|
ResourceContentBlock,
|
|
TextContentBlock,
|
|
TextResourceContents,
|
|
)
|
|
|
|
from acp_adapter.server import HermesACPAgent, _content_blocks_to_openai_user_content
|
|
|
|
|
|
def test_acp_image_blocks_convert_to_openai_multimodal_content():
|
|
content = _content_blocks_to_openai_user_content([
|
|
TextContentBlock(type="text", text="What is in this image?"),
|
|
ImageContentBlock(type="image", data="aGVsbG8=", mimeType="image/png"),
|
|
])
|
|
|
|
assert content == [
|
|
{"type": "text", "text": "What is in this image?"},
|
|
{
|
|
"type": "image_url",
|
|
"image_url": {"url": "data:image/png;base64,aGVsbG8="},
|
|
},
|
|
]
|
|
|
|
|
|
def test_text_only_acp_blocks_stay_string_for_legacy_prompt_path():
|
|
content = _content_blocks_to_openai_user_content([
|
|
TextContentBlock(type="text", text="/help"),
|
|
])
|
|
|
|
assert content == "/help"
|
|
|
|
|
|
def test_acp_resource_link_file_is_inlined_as_text(tmp_path):
|
|
attached = tmp_path / "notes.md"
|
|
attached.write_text("# Notes\n\nAttached file body", encoding="utf-8")
|
|
|
|
content = _content_blocks_to_openai_user_content([
|
|
TextContentBlock(type="text", text="Please read this file"),
|
|
ResourceContentBlock(
|
|
type="resource_link",
|
|
name="notes.md",
|
|
title="Project notes",
|
|
uri=attached.as_uri(),
|
|
mimeType="text/markdown",
|
|
),
|
|
])
|
|
|
|
assert content == (
|
|
"Please read this file\n"
|
|
"[Attached file: Project notes (notes.md)]\n"
|
|
f"URI: {attached.as_uri()}\n\n"
|
|
"# Notes\n\nAttached file body"
|
|
)
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_initialize_advertises_image_prompt_capability():
|
|
response = await HermesACPAgent().initialize()
|
|
|
|
assert response.agent_capabilities is not None
|
|
assert response.agent_capabilities.prompt_capabilities is not None
|
|
assert response.agent_capabilities.prompt_capabilities.image is True
|
|
|
|
|
|
# 1x1 transparent PNG — smallest valid image payload for inlining tests.
|
|
_ONE_PX_PNG = bytes.fromhex(
|
|
"89504e470d0a1a0a0000000d49484452000000010000000108060000001f15c4"
|
|
"890000000a49444154789c6300010000000500010d0a2db40000000049454e44ae426082"
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
|