teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
56 lines
1.8 KiB
Python
56 lines
1.8 KiB
Python
from unittest.mock import MagicMock, patch
|
|
from types import SimpleNamespace
|
|
|
|
from cli import HermesCLI
|
|
from hermes_cli.main_agent_cmds import cmd_insights
|
|
|
|
|
|
class _InsightsEngineStub:
|
|
calls = []
|
|
|
|
def __init__(self, db):
|
|
self.db = db
|
|
|
|
def generate(self, *, days=30, source=None):
|
|
self.calls.append({"days": days, "source": source})
|
|
return {"days": days, "source": source}
|
|
|
|
def format_terminal(self, report):
|
|
return f"days={report['days']} source={report['source']}"
|
|
|
|
|
|
def _run_show_insights(command: str):
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
db = MagicMock()
|
|
_InsightsEngineStub.calls = []
|
|
with patch("hermes_state.SessionDB", return_value=db), \
|
|
patch("agent.insights.InsightsEngine", _InsightsEngineStub):
|
|
cli_obj._show_insights(command)
|
|
return _InsightsEngineStub.calls, db
|
|
|
|
|
|
def test_cli_insights_accepts_positional_days(capsys):
|
|
calls, db = _run_show_insights("/insights 7")
|
|
|
|
assert calls == [{"days": 7, "source": None}]
|
|
db.close.assert_called_once()
|
|
assert "days=7 source=None" in capsys.readouterr().out
|
|
|
|
|
|
def test_cli_insights_keeps_days_flag_and_source(capsys):
|
|
calls, db = _run_show_insights("/insights --days 14 --source discord")
|
|
|
|
assert calls == [{"days": 14, "source": "discord"}]
|
|
db.close.assert_called_once()
|
|
assert "days=14 source=discord" in capsys.readouterr().out
|
|
|
|
|
|
def test_subcommand_insights_closes_database_when_generation_fails(capsys):
|
|
db = MagicMock()
|
|
with patch("hermes_state.SessionDB", return_value=db), \
|
|
patch("agent.insights.InsightsEngine", side_effect=RuntimeError("boom")):
|
|
cmd_insights(SimpleNamespace(days=30, source=None))
|
|
|
|
db.close.assert_called_once()
|
|
assert "Error generating insights: boom" in capsys.readouterr().out
|