Teknium
2ecca1e7d3
fix(windows): capture is not a no-window boundary; route flashing spawns through chokepoint ( #53829 )
...
Follow-up to #53791 addressing review feedback: the footgun checker treated
capture_output=/stdout=/stderr=/check_output as proof a subprocess can't pop a
Windows console. That invariant is false — stream redirection controls where a
child's output goes, not whether a console is allocated. From a console-less
parent (Desktop/Electron, pythonw.exe, detached gateway/cron) a console-subsystem
child still flashes a window even when fully captured.
- check-windows-footguns.py: capture/redirect/check_output is no longer a blanket
safe-pass. Added _WINDOWS_FLASHING_PROGRAMS (git/gh/npm/node/python/uv/ffmpeg/
docker/powershell/…); calls to those are flagged even when captured. Non-flashing
programs keep the capture exemption (no 271-site noise). _subprocess_compat.run/
popen calls are inherently safe (wrapper injects CREATE_NO_WINDOW).
- Routed the 35 genuine flashing git/gh/npm/uv/ffmpeg/docker spawns through the
_subprocess_compat.run/popen chokepoint (Brooklyn's wrapper from #53810 ) — the
durable fix, not per-site annotations. cmd.exe /c start stays # ok (intentional).
- Updated tests + CONTRIBUTING.md rule #17 to the corrected invariant.
2026-06-27 14:49:41 -07:00
..
2026-06-27 10:08:13 +10:00
2026-06-25 00:11:15 -07:00
2026-06-26 11:04:41 -07:00
2026-06-19 12:38:31 -07:00
2026-06-13 02:36:09 -07:00
2026-06-27 14:02:24 -07:00
2026-06-24 00:54:18 +05:30
2026-06-21 19:53:27 -07:00
2026-06-25 00:11:15 -07:00
2026-05-18 10:14:38 -07:00
2026-06-26 19:23:33 +05:30
2026-06-27 14:49:41 -07:00
2026-06-11 10:49:47 -07:00
2026-05-19 22:34:05 -07:00
2026-05-28 15:14:05 +10:00
2026-05-28 22:26:25 -07:00
2026-05-25 01:20:33 -07:00
2026-05-28 22:26:25 -07:00
2026-06-27 14:02:24 -07:00
2026-06-19 16:59:43 -07:00
2026-06-27 13:03:51 -07:00
2026-05-25 01:20:33 -07:00
2026-06-27 14:02:24 -07:00
2026-05-27 12:16:15 -07:00
2026-05-15 02:31:30 -07:00
2026-05-17 02:29:41 -07:00
2026-06-27 03:09:09 -07:00
2026-06-01 19:51:03 -07:00
2026-06-27 13:03:51 -07:00
2026-06-24 16:34:51 +10:00
2026-06-21 16:31:56 +05:30
2026-05-11 11:13:25 -07:00
2026-06-23 23:29:50 -07:00
2026-06-17 05:20:32 -07:00
2026-06-01 16:58:58 -07:00
2026-06-09 13:56:33 +10:00
2026-06-19 07:05:42 -07:00
2026-06-24 18:56:26 -07:00
2026-06-27 13:03:51 -07:00
2026-05-11 11:13:25 -07:00
2026-06-27 14:49:41 -07:00
2026-06-27 14:49:41 -07:00
2026-06-19 07:46:33 -07:00
2026-05-23 05:24:57 -07:00
2026-05-23 05:24:57 -07:00
2026-06-24 11:00:11 +10:00
2026-06-27 14:02:24 -07:00
2026-06-27 14:02:24 -07:00
2026-06-22 12:20:09 -07:00
2026-06-06 18:22:38 -07:00
2026-05-11 11:13:25 -07:00
2026-06-27 03:43:38 -07:00
2026-06-27 14:49:41 -07:00
2026-06-06 19:29:00 -07:00
2026-05-29 04:22:27 -07:00
2026-06-07 06:14:24 -07:00
2026-06-21 17:06:48 -07:00
2026-06-25 21:46:58 -07:00
2026-06-03 05:41:35 -07:00
2026-06-27 14:49:41 -07:00
2026-06-19 07:46:33 -07:00
2026-06-27 14:49:41 -07:00
2026-06-27 13:03:51 -07:00
2026-06-26 00:35:27 -07:00
2026-05-26 12:48:14 -07:00
2026-06-21 19:05:27 -07:00
2026-06-27 04:59:23 +05:30
2026-06-22 19:16:47 -05:00
2026-06-18 16:48:47 -05:00
2026-06-17 01:04:26 +08:00
2026-06-06 23:07:25 +05:30
2026-05-20 09:18:23 -07:00
2026-06-25 13:52:06 -07:00
2026-06-27 03:43:16 -07:00
2026-06-08 22:31:06 -07:00
2026-06-10 00:24:06 -07:00
2026-06-13 13:47:08 -07:00
2026-06-27 11:45:07 -07:00
2026-06-27 03:43:38 -07:00
2026-06-25 13:52:06 -07:00
2026-06-12 08:51:10 +00:00
2026-06-21 22:43:48 -07:00
2026-06-19 01:53:32 +05:30
2026-06-24 00:14:49 -07:00
2026-05-30 07:31:48 -07:00
2026-05-07 07:18:21 -07:00
2026-05-29 17:49:15 -07:00
2026-06-24 13:48:38 -05:00
2026-05-23 01:07:01 -04:00
2026-06-13 13:23:59 -07:00
2026-06-21 12:38:14 -07:00
2026-06-04 02:20:31 +05:30
2026-05-28 22:26:25 -07:00
2026-06-27 14:49:41 -07:00
2026-06-25 10:25:54 +10:00
2026-06-25 16:40:26 -05:00
2026-06-25 16:40:26 -05:00
2026-05-30 02:53:42 -07:00
2026-06-25 13:52:06 -07:00
2026-06-25 13:52:06 -07:00
2026-05-28 02:36:09 -07:00
2026-05-29 00:31:44 -07:00
2026-06-08 07:03:12 -07:00
2026-06-27 13:03:51 -07:00
2026-06-27 14:20:51 -07:00
2026-06-17 01:04:26 +08:00
2026-06-06 18:36:40 -07:00
2026-05-29 13:24:12 -07:00
2026-06-21 19:05:27 -07:00
2026-05-28 22:26:25 -07:00
2026-06-19 07:46:33 -07:00
2026-06-24 16:34:51 +10:00
2026-06-15 07:46:34 -07:00
2026-05-17 02:29:41 -07:00
2026-06-11 07:51:01 -07:00
2026-06-27 13:03:51 -07:00
2026-06-14 22:54:54 +05:30
2026-06-26 11:04:41 -07:00
2026-05-18 20:05:23 -07:00
2026-06-23 11:30:10 -07:00
2026-06-25 16:40:26 -05:00
2026-06-10 21:39:22 -04:00
2026-05-28 22:26:25 -07:00
2026-06-11 10:49:47 -07:00
2026-06-05 03:20:10 -07:00
2026-05-19 14:25:10 -07:00
2026-06-27 04:01:12 +05:30
2026-06-27 13:03:51 -07:00
2026-06-26 14:07:43 +05:30
2026-06-06 18:22:38 -07:00
2026-05-06 15:49:59 -07:00
2026-06-27 14:49:41 -07:00
2026-05-24 04:55:18 -07:00
2026-06-08 11:32:43 -07:00
2026-06-09 23:21:14 -07:00
2026-05-20 09:18:23 -07:00