27e3fc51ff
Two defects in tools/async_delegation.py: - _push_completion_event called _persist_completion unguarded before publishing onto completion_queue. One sqlite3 error (locked/full state.db) dropped the completion event, left the record parked on "finalizing" (a permanently leaked max_concurrent_children slot) and let recover_abandoned_delegations later rewrite a succeeded unit as "unknown". The write is now try/except: the failure is logged and the event is still delivered, so _finalize flips the status and frees the slot. A lost durable row is acceptable degradation; a lost result and a leaked slot are not. - _prune_completed_locked treated anything != "running" as finished, while the module's own _LIVE_STATES also names stalling/finalizing. A stalling record has no completed_at, so it sorted oldest and was the first eviction candidate once the retained cap overflowed; its late runner return then hit the missing-record path and the real result was dropped. The predicate is now `status not in _LIVE_STATES`. Slim redo of #76606 (earliest fix) and #112031: the converge/shield/ delete-row machinery both PRs built around the write is dropped as defense-in-depth; the two core hunks are ported as-is. Fixes #76605 Fixes #112030 Co-authored-by: luckystar2026 <1393268817@qq.com>
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.