Yiipu
2824899321
fix(terminal): correct off-by-one in _hermes_repo_root path resolution
...
_hermes_repo_root used parents[1] which resolves to tools/ instead of
the repository root. The file lives at tools/environments/local.py so it
needs parents[2] to reach the actual repo root that Electron injects
into PYTHONPATH.
The test test_repo_root_stripped reused the module constant under test
as its input. This made it pass regardless of what the constant pointed
at. The test now computes the real repo root independently from the
source file location. It fails with the old parents[1] code and passes
with the fix.
Reported by spfcraze in PR #78917 review.
2026-08-16 23:26:04 -07:00
..
2026-08-16 13:01:20 -07:00
2026-08-16 23:26:04 -07:00
2026-07-28 07:58:16 -07:00
2026-08-16 22:08:05 -07:00
2026-08-16 22:10:13 -07:00
2026-08-11 09:56:13 +10:00
2026-07-28 11:52:44 -07:00
2026-08-15 02:51:59 +05:30
2026-08-07 17:45:06 +05:30
2026-08-16 18:30:53 -07:00
2026-08-02 00:11:50 -07:00
2026-07-27 14:32:05 -07:00
2026-07-29 10:54:04 -07:00
2026-08-15 00:33:01 -07:00
2026-08-15 04:23:26 -07:00
2026-08-16 22:08:47 -07:00
2026-08-14 21:24:36 -07:00
2026-08-13 01:19:42 -05:00
2026-08-06 19:35:47 -06:00
2026-08-16 23:26:04 -07:00
2026-07-29 12:19:37 -07:00
2026-08-08 05:44:18 -07:00
2026-08-16 22:09:28 -07:00
2026-08-16 22:06:32 -07:00
2026-08-16 20:14:51 -07:00
2026-08-07 09:07:42 -07:00
2026-07-22 12:13:01 -05:00
2026-08-02 00:11:50 -07:00
2026-08-02 00:36:03 -07:00
2026-08-01 21:17:51 -04:00
2026-08-16 22:08:28 -07:00
2026-08-15 02:51:59 +05:30
2026-07-31 10:17:55 -04:00
2026-08-06 19:35:47 -06:00
2026-08-12 15:21:47 +05:30
2026-08-02 00:11:50 -07:00
2026-08-13 11:09:51 -07:00
2026-08-16 11:32:02 -07:00
2026-08-08 04:19:38 -07:00
2026-08-13 10:47:40 -07:00
2026-08-14 22:33:44 -07:00
2026-08-08 12:32:23 -07:00
2026-07-17 04:50:47 -07:00
2026-08-15 23:37:15 -07:00
2026-08-15 23:37:15 -07:00
2026-08-03 14:24:37 +05:30
2026-07-18 04:15:13 -07:00
2026-08-16 22:08:18 -07:00
2026-08-14 21:15:08 -07:00
2026-07-29 10:13:50 -07:00
2026-07-28 14:07:21 -07:00
2026-08-06 19:35:47 -06:00
2026-08-02 10:02:33 -07:00
2026-08-01 10:47:20 -07:00
2026-08-12 15:21:47 +05:30
2026-07-29 10:14:00 -07:00
2026-08-16 22:08:37 -07:00
2026-08-16 22:09:37 -07:00
2026-08-15 00:33:11 -07:00
2026-08-14 21:41:26 -07:00
2026-08-10 01:28:57 -07:00
2026-08-06 19:35:47 -06:00
2026-08-06 19:35:47 -06:00
2026-08-08 22:17:38 -05:00
2026-08-12 19:13:32 -07:00
2026-08-07 08:58:25 -07:00
2026-08-14 22:34:51 -07:00
2026-08-15 07:07:40 +05:30
2026-08-15 00:34:29 -07:00
2026-08-13 01:06:51 -05:00
2026-08-12 13:57:59 +05:30
2026-08-16 22:06:41 -07:00
2026-08-08 11:12:27 -07:00
2026-08-16 22:06:41 -07:00
2026-08-16 22:06:41 -07:00
2026-08-12 01:45:18 -07:00
2026-08-16 02:02:34 -07:00
2026-07-30 22:31:42 -07:00
2026-07-28 04:24:50 -05:00
2026-08-13 11:49:14 -07:00
2026-08-13 11:09:51 -07:00
2026-08-12 19:44:45 -07:00
2026-08-15 23:48:15 -07:00
2026-08-16 22:05:59 -07:00
2026-08-02 10:04:48 -07:00
2026-08-14 20:24:42 -07:00
2026-08-02 10:04:48 -07:00
2026-08-03 19:11:30 +05:30
2026-08-12 19:01:30 -07:00
2026-07-28 22:31:40 -07:00
2026-07-28 11:55:01 -07:00
2026-08-16 21:20:29 -07:00
2026-07-28 14:17:45 -07:00
2026-08-08 19:59:12 -04:00
2026-08-15 12:53:37 +05:30
2026-08-12 19:01:30 -07:00
2026-08-08 13:49:24 +05:30
2026-08-13 11:09:51 -07:00
2026-08-08 12:34:46 -07:00
2026-08-16 21:20:29 -07:00
2026-08-16 21:20:29 -07:00