d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
77 lines
2.0 KiB
Python
77 lines
2.0 KiB
Python
"""Tests for the ``_codex_silent_hang_hint`` heuristic.
|
|
|
|
The helper substitutes an actionable hint into the stale-call timeout
|
|
warning when the request matches a known Codex silent-reject pattern
|
|
(gpt-5.5 family on the ChatGPT Codex backend). See issue #21444 for
|
|
symptom history. The recommended workaround for ChatGPT Codex OAuth
|
|
accounts is `gpt-5.4` / `gpt-5.3-codex`, not `gpt-5.4-codex`.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
def _make_agent(tmp_path: Path, **overrides):
|
|
from run_agent import AIAgent
|
|
kwargs = dict(
|
|
model="gpt-5.5",
|
|
provider="openai-codex",
|
|
api_key="sk-dummy",
|
|
base_url="https://chatgpt.com/backend-api/codex",
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=True,
|
|
platform="cli",
|
|
)
|
|
kwargs.update(overrides)
|
|
return AIAgent(**kwargs)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate_hermes_home(monkeypatch, tmp_path):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
(tmp_path / ".env").write_text("", encoding="utf-8")
|
|
|
|
|
|
# ── positive cases: hint fires ─────────────────────────────────────────────
|
|
|
|
|
|
def test_hint_fires_for_bare_gpt_5_5_on_codex(tmp_path):
|
|
agent = _make_agent(tmp_path)
|
|
agent.api_mode = "codex_responses"
|
|
hint = agent._codex_silent_hang_hint(model="gpt-5.5")
|
|
assert hint is not None
|
|
assert "gpt-5.4" in hint
|
|
assert "gpt-5.3-codex" in hint
|
|
assert "gpt-5.4-codex" in hint
|
|
assert "fallback chain" in hint
|
|
|
|
|
|
def test_hint_fires_for_vendor_prefixed_gpt_5_5(tmp_path):
|
|
agent = _make_agent(tmp_path, model="openai/gpt-5.5")
|
|
agent.api_mode = "codex_responses"
|
|
hint = agent._codex_silent_hang_hint(model="openai/gpt-5.5")
|
|
assert hint is not None
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ── negative cases: hint stays None ────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|