ff88f27403
Partially reverts the newer-visible-session preference from #91791 (salvage of #91258), which made the pinned canonical Bot Chat unreachable. Fixes #92040. Canonical Bot Chats are ALWAYS hidden from the Sessions sidebar: session.create passes hidden:true unconditionally and hideOwnedBotSessions() sweeps any that were born visible (asserted in tests/hide-bot-chats.test.mjs). The bot row is therefore the ONLY entry point to a bot's forever-chat, so preferring the profile's freshest visible session did not re-order two equivalent doors — it removed the only one. Reported symptom: a 106-message bot-building conversation with no reachable entry point anywhere in the UI, while the row previewed one session and opened another (a regression of the preview/click identity #88200 established). The report behind #91791 was real but has a non-destructive answer: scratch sessions started via "New chat with this agent" are not plumbing-titled, so neither hideOwnedBotSessions() nor sweepBotProfileSessions() hides them (the sweep matches the exact titles 'Bot Chat' / 'Agent Inbox' / 'Group: …'). They stay listed in the Sessions sidebar and are reachable there; they simply are not what the bot row targets, which is by design. Changes: - openBotCanonicalChat: when the pin is alive and verified, open it directly. The newerVisibleBotChat preference is removed from that branch only; the helper stays for the dead-pin recovery path. - Drop the now-unused latestVisible parameter and its argument at the BotRow call site. The second call site already passed three args. - tests/bot-row-opens-latest.test.mjs -> tests/bot-row-opens-canonical-chat.test.mjs: the two tests that asserted the newer-session behaviour are rewritten rather than deleted, so the reasoning survives in the suite. Adds a source-level guard ("the healthy-pin branch never prefers a newer visible session") so this cannot silently regress. The deleted-newer-session fallback test covered a path that no longer exists; replaced with one asserting a failed open of a verified pin propagates instead of forking the forever-chat. The keepAllProfilesScope: false half of #91791 is untouched. Plugin suite: 392 pass, 0 fail.