54d7f75590
terminal_tool's approval gate answers `status: pending_approval` with an EMPTY `error` (#28323) and no `session_id`, so _spawn_delivery's specific branch (`if parsed.get("error")`) was skipped and every unanswered approval fell through to "Delivery to X failed to start: no process id returned" — blaming the spawn for an approval nobody in a non-interactive turn (api_server, `hermes peer dm`, cron) could grant. - _spawn_delivery: the pending shape gets its own message (the runner command needs terminal approval nobody in this turn can grant); a local/peer DM adds "nothing was sent — approve it or add it to command_allowlist and send again". Ownership is never transferred, so the existing finally still reclaims the plaintext DM file. - _try_relay_delivery: the envelope is queued on disk BEFORE the reply waiter spawns and the Desktop drains it independently, so ANY waiter spawn failure is a lost wake-up, not a failed delivery; reporting it as an error made the sender resend and deliver the message twice. The relay path now returns the shape _start_delivery's live-owner branch already uses (status queued + notification_error + "Do NOT resend") instead of inventing a new status value nothing reads. Slimmer redo of #92971 by @jonpol01 (same diagnosis, same relay/local split on `dm_file is None`); the source-text contract test and the `sent_no_reply_wake` status were dropped. Fixes #111716 Co-authored-by: John Paul Soliva <soliva.johnpaul@icloud.com>