20d33e385a
mount_spa's WEB_DIST.exists() check ran ONCE at mount time: a long-lived 'hermes dashboard --skip-build' that survived a git pull (or launched before the first build) installed a permanent no_frontend catch-all and answered 404 'Frontend not built' on every route forever — even after npm run build completed. Remote Desktop clients saw ERR_EMPTY_RESPONSE. The missing-dist branch is now reserved for the headless-serve contract only. The SPA routes mount unconditionally and already cope with a missing dist per-request (_serve_index returns the same 404 JSON when index.html is unreadable; the /assets mount gains check_dir=False so StaticFiles 404s instead of raising at mount). The dashboard recovers the moment a build lands on disk — no restart needed. Direction from #82666 by @codexbt (his PR's rebase dropped the product hunk, leaving only the test; the test is cherry-picked as-is and this commit restores the behavior it pins, adapted to the current mount_spa shape: headless guard preserved, per-request recovery instead of a per-request exists() check).
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.