Teknium
5b19c8ee55
fix(acp): make --acp probe tri-state, cached, and mock-safe
...
Salvage hardening on top of #87308 (thanks @Dudeman456):
- Tri-state verdict: inconclusive probes (binary missing, --help
failed/timed out) return None and fall through to the normal spawn
path, preserving the established 'Could not start Copilot ACP
command' error instead of masking it. This also fixes the two
test_copilot_acp_client HOME-env regressions that went red on the
PR: their mocked-Popen path was intercepted by the new unmocked
subprocess.run probe.
- Cache definitive verdicts per binary path so CLIs that DO support
--acp pay the ~50ms --help cost once per process, not per prompt.
- Skip the probe entirely when custom ACP args don't include --acp.
- Fix the help-text regex: the old pattern never matched '[--acp]'
(leading '[' is neither start-of-string nor whitespace) and \b
after 'p' matched '--acpfoo'.
- Hermeticity: stub subprocess.run in the two HOME-env tests; add 6
probe-specific tests (fast-fail, fall-through, caching, skip).
2026-08-16 06:31:46 -07:00
..
2026-08-01 21:17:51 -04:00
2026-08-08 18:11:02 -07:00
2026-08-15 00:33:01 -07:00
2026-07-24 11:45:57 -07:00
2026-08-15 13:28:14 -07:00
2026-08-16 02:00:54 -07:00
2026-08-07 10:11:05 -07:00
2026-05-28 00:20:11 -07:00
2026-07-22 10:58:22 -07:00
2026-08-15 22:36:31 -07:00
2026-08-16 14:34:30 +05:30
2026-08-14 21:27:05 -07:00
2026-07-18 20:01:55 +05:30
2026-07-16 04:23:12 -07:00
2026-08-15 03:16:21 -07:00
2026-08-02 10:02:33 -07:00
2026-07-26 23:41:54 -07:00
2026-08-09 16:13:52 +05:30
2026-07-21 13:54:11 -05:00
2026-08-15 12:47:27 +05:30
2026-07-22 18:08:59 -05:00
2026-07-29 11:53:39 -07:00
2026-07-29 11:53:39 -07:00
2026-07-05 14:00:20 -07:00
2026-08-10 10:45:44 -07:00
2026-08-12 19:13:32 -07:00
2026-08-16 01:55:00 -07:00
2026-08-14 10:39:25 -07:00
2026-08-15 01:04:19 -07:00
2026-07-29 15:28:15 -07:00
2026-08-15 03:16:21 -07:00
2026-07-26 18:06:21 -07:00
2026-08-16 02:01:41 -07:00
2026-08-08 23:09:45 +05:30
2026-08-12 18:41:59 -07:00
2026-08-15 23:37:22 -07:00
2026-08-16 01:55:51 -07:00
2026-08-16 06:31:46 -07:00
2026-07-02 13:17:41 -07:00
2026-08-14 21:54:56 -07:00
2026-08-08 12:32:23 -07:00
2026-07-28 21:36:23 +00:00
2026-08-08 15:10:35 +05:30
2026-08-03 18:21:17 +05:30
2026-08-13 13:53:39 +05:30
2026-08-06 03:16:26 +05:30
2026-08-13 09:34:36 -07:00
2026-08-14 21:54:56 -07:00
2026-07-17 13:49:12 -07:00
2026-08-08 05:21:09 -07:00
2026-08-12 11:04:45 -07:00
2026-08-16 02:00:54 -07:00
2026-07-26 20:59:16 -07:00
2026-07-29 15:28:15 -07:00
2026-08-08 14:49:28 -07:00
2026-08-12 19:13:32 -07:00
2026-08-14 03:31:22 +05:30
2026-08-14 02:04:24 +05:30
2026-08-02 22:15:20 +05:30
2026-07-26 12:54:45 -07:00
2026-05-28 00:20:11 -07:00
2026-07-14 16:47:33 +05:30
2026-08-08 05:09:43 -07:00
2026-07-29 11:53:39 -07:00
2026-07-01 16:25:48 -05:00
2026-06-30 15:16:21 -05:00
2026-07-16 07:57:51 -07:00
2026-07-23 08:19:14 -07:00
2026-08-13 23:43:15 +05:30
2026-08-13 23:15:25 +05:30
2026-06-19 15:23:41 +08:00
2026-08-15 01:04:19 -07:00
2026-08-15 01:04:19 -07:00
2026-08-13 23:10:16 +05:30
2026-08-13 23:10:16 +05:30
2026-08-15 01:04:19 -07:00
2026-08-14 03:31:22 +05:30
2026-07-20 11:05:52 -07:00
2026-08-13 03:04:45 -07:00
2026-07-24 17:10:39 -07:00
2026-07-22 12:10:58 -05:00
2026-06-23 08:01:50 +00:00
2026-08-02 15:01:11 -07:00
2026-08-12 16:25:20 -07:00
2026-08-12 18:38:25 -07:00
2026-07-16 01:13:43 -07:00
2026-07-05 03:14:55 -07:00
2026-08-15 15:04:32 -07:00
2026-08-09 15:25:12 +05:30
2026-08-15 11:09:56 +05:30
2026-08-13 15:24:47 +05:30
2026-07-10 05:41:59 -05:00
2026-08-06 22:02:37 -05:00
2026-08-12 13:37:04 -04:00
2026-08-13 23:10:16 +05:30
2026-08-15 00:33:01 -07:00
2026-08-15 00:33:01 -07:00
2026-08-08 23:46:17 -07:00
2026-08-16 01:55:51 -07:00
2026-07-19 08:25:35 +05:30
2026-07-29 10:13:50 -07:00
2026-07-16 04:32:23 -07:00
2026-08-02 09:59:52 -07:00
2026-08-02 16:16:36 -07:00
2026-08-15 23:03:52 -07:00
2026-07-29 12:20:34 -07:00
2026-08-09 15:25:12 +05:30
2026-07-29 15:28:15 -07:00
2026-08-16 06:24:56 -07:00
2026-08-08 15:10:24 +05:30
2026-07-02 04:51:56 +05:30
2026-05-28 04:53:27 -07:00
2026-07-17 18:31:09 +00:00
2026-08-02 22:15:20 +05:30
2026-08-03 20:43:34 +05:30
2026-07-22 08:11:09 +05:30
2026-08-16 01:57:59 -07:00
2026-07-16 01:07:29 +05:30
2026-06-25 19:00:48 -07:00
2026-08-15 00:33:01 -07:00
2026-08-09 04:33:58 -05:00
2026-08-15 01:04:19 -07:00
2026-08-15 23:03:52 -07:00
2026-08-13 09:34:36 -07:00
2026-07-11 05:41:58 -07:00
2026-08-14 21:41:26 -07:00
2026-08-12 19:01:30 -07:00
2026-08-12 19:13:32 -07:00
2026-05-24 18:04:54 -07:00
2026-08-12 19:13:32 -07:00
2026-08-15 01:04:19 -07:00
2026-08-16 01:56:18 -07:00
2026-08-08 11:24:45 -07:00
2026-07-26 17:47:51 -07:00
2026-08-14 22:04:16 -07:00
2026-08-16 00:14:58 -07:00
2026-08-12 01:15:25 -07:00
2026-06-30 00:59:29 -05:00
2026-07-02 06:07:56 +05:30
2026-08-08 14:49:28 -07:00
2026-08-12 19:13:32 -07:00
2026-07-06 02:42:24 -07:00
2026-08-12 19:13:32 -07:00