Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
75 lines
2.4 KiB
Python
75 lines
2.4 KiB
Python
"""Regression tests for the Tools & Keys GitHub PAT save/remove path (#40041).
|
|
|
|
Users following generic docs add ``export GITHUB_TOKEN=ghp_...`` to
|
|
``~/.hermes/.env``. ``load_env()`` parses the export prefix (#6659), so every
|
|
UI shows the token as set (green light) — but ``save_env_value`` /
|
|
``remove_env_value`` only matched plain ``KEY=`` lines. Result: the UI could
|
|
neither replace nor remove the token (delete 404s as "not found in .env";
|
|
save appends a duplicate line that a later delete removes while the export
|
|
line silently resurrects the old value).
|
|
|
|
Fake tokens are constructed at runtime — no key-shaped literals on disk.
|
|
"""
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
|
|
from hermes_cli.web_server import _SESSION_TOKEN, app
|
|
|
|
client = TestClient(app)
|
|
HEADERS = {"X-Hermes-Session-Token": _SESSION_TOKEN}
|
|
|
|
# Classic-PAT-shaped token, constructed at runtime (36 chars after prefix).
|
|
OLD_PAT = "ghp_" + "A" * 36
|
|
NEW_PAT = "ghp_" + "B" * 36
|
|
|
|
|
|
@pytest.fixture
|
|
def hermes_home(monkeypatch, tmp_path):
|
|
home = tmp_path / "pat_home"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
from hermes_cli.config import invalidate_env_cache
|
|
|
|
invalidate_env_cache()
|
|
return home
|
|
|
|
|
|
def _write_env_raw(home, text):
|
|
home.joinpath(".env").write_text(text, encoding="utf-8")
|
|
from hermes_cli.config import invalidate_env_cache
|
|
|
|
invalidate_env_cache()
|
|
|
|
|
|
def test_classic_pat_save_via_endpoint_succeeds(hermes_home):
|
|
"""Saving a ghp_* classic PAT through the env endpoint must not 500 —
|
|
GITHUB_TOKEN is a REST/Skills-Hub credential, not a Copilot one."""
|
|
resp = client.put(
|
|
"/api/env", json={"key": "GITHUB_TOKEN", "value": NEW_PAT}, headers=HEADERS
|
|
)
|
|
assert resp.status_code == 200, resp.text
|
|
|
|
from hermes_cli.config import load_env
|
|
|
|
assert load_env()["GITHUB_TOKEN"] == NEW_PAT
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_plain_line_save_and_remove_still_work(hermes_home):
|
|
"""Sanity: the ordinary KEY= path is unchanged."""
|
|
from hermes_cli.config import load_env, remove_env_value, save_env_value
|
|
|
|
save_env_value("GITHUB_TOKEN", OLD_PAT)
|
|
assert load_env()["GITHUB_TOKEN"] == OLD_PAT
|
|
save_env_value("GITHUB_TOKEN", NEW_PAT)
|
|
env_text = hermes_home.joinpath(".env").read_text(encoding="utf-8")
|
|
assert env_text.count("GITHUB_TOKEN") == 1
|
|
assert remove_env_value("GITHUB_TOKEN") is True
|
|
assert "GITHUB_TOKEN" not in load_env()
|
|
|
|
|