kshitij
1b1975781f
The subprocess import test was creating .tmp-hermes-exec-ask-import/ in the repo root without cleanup. Switch to pytest's tmp_path fixture so the temp directory is auto-cleaned and never appears as untracked.
117 lines
3.9 KiB
Python
117 lines
3.9 KiB
Python
"""Regression: interactive CLI must not lose the Dangerous Command panel.
|
|
|
|
When ``HERMES_EXEC_ASK`` leaks into a classic CLI process (historically via
|
|
``import gateway.run`` setting the flag at module import), the ask/gateway
|
|
branch used to return ``pending_approval`` immediately with no notify
|
|
listener and skip the CLI approval callback. Users saw tools "auto-block"
|
|
with no Approve/Deny UI.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
import tempfile
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
import tools.approval as approval_module
|
|
from tools.approval import check_all_command_guards
|
|
from tools.terminal_tool import set_approval_callback
|
|
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clean_approval_env(monkeypatch):
|
|
for key in (
|
|
"HERMES_EXEC_ASK",
|
|
"HERMES_GATEWAY_SESSION",
|
|
"HERMES_SESSION_PLATFORM",
|
|
"HERMES_CRON_SESSION",
|
|
"HERMES_YOLO_MODE",
|
|
):
|
|
monkeypatch.delenv(key, raising=False)
|
|
monkeypatch.setenv("HERMES_INTERACTIVE", "1")
|
|
monkeypatch.setattr(approval_module, "_YOLO_MODE_FROZEN", False)
|
|
monkeypatch.setattr(
|
|
approval_module,
|
|
"_get_approval_mode",
|
|
lambda: "manual",
|
|
)
|
|
monkeypatch.setattr(
|
|
"tools.tirith_security.check_command_security",
|
|
lambda _command: {"action": "allow", "findings": [], "summary": ""},
|
|
)
|
|
approval_module._session_approved.clear()
|
|
approval_module._permanent_approved.clear()
|
|
approval_module._pending.clear()
|
|
set_approval_callback(None)
|
|
yield
|
|
set_approval_callback(None)
|
|
|
|
|
|
class TestCliApprovalSurvivesExecAskLeak:
|
|
def test_cli_callback_used_when_exec_ask_set_without_notifier(self, monkeypatch):
|
|
"""Ask-mode with a CLI callback must prompt locally, not pending_approval."""
|
|
monkeypatch.setenv("HERMES_EXEC_ASK", "1")
|
|
calls = []
|
|
|
|
def _cb(command, description, **kwargs):
|
|
calls.append((command, description))
|
|
return "once"
|
|
|
|
set_approval_callback(_cb)
|
|
result = check_all_command_guards("rm -rf /tmp/testdir", "local")
|
|
|
|
assert calls, "CLI approval callback was never invoked"
|
|
assert result.get("status") != "pending_approval"
|
|
assert result.get("approval_pending") is not True
|
|
assert result.get("approved") is True
|
|
assert result.get("user_approved") is True
|
|
|
|
def test_pending_approval_still_used_without_cli_callback(self, monkeypatch):
|
|
"""Headless ask-mode without a CLI callback keeps the pending fallback."""
|
|
monkeypatch.setenv("HERMES_EXEC_ASK", "1")
|
|
monkeypatch.delenv("HERMES_INTERACTIVE", raising=False)
|
|
set_approval_callback(None)
|
|
|
|
result = check_all_command_guards("rm -rf /tmp/testdir", "local")
|
|
|
|
assert result.get("approved") is False
|
|
assert result.get("status") == "pending_approval"
|
|
assert result.get("approval_pending") is True
|
|
|
|
|
|
class TestGatewayRunImportDoesNotSetExecAsk:
|
|
def test_importing_gateway_run_does_not_set_exec_ask(self, tmp_path):
|
|
"""Incidental imports must not poison CLI ask-mode process-wide."""
|
|
script = r"""
|
|
import os, sys
|
|
os.environ.pop("HERMES_EXEC_ASK", None)
|
|
sys.path.insert(0, %r)
|
|
# Avoid starting the gateway; only import the module for _gateway_runner_ref
|
|
# style side imports.
|
|
import gateway.run # noqa: F401
|
|
print("EXEC_ASK=" + repr(os.environ.get("HERMES_EXEC_ASK")))
|
|
""" % (str(REPO_ROOT),)
|
|
hermes_home = tmp_path / "import-test-home"
|
|
proc = subprocess.run(
|
|
[sys.executable, "-c", script],
|
|
cwd=str(REPO_ROOT),
|
|
capture_output=True,
|
|
text=True,
|
|
env={
|
|
**os.environ,
|
|
"HERMES_HOME": str(hermes_home),
|
|
},
|
|
timeout=60,
|
|
)
|
|
assert proc.returncode == 0, proc.stderr
|
|
assert "EXEC_ASK=None" in proc.stdout, proc.stdout + proc.stderr
|