kshitijk4poor
9857bcba5c
Replace hardcoded /opt/hermes check with dynamic install-tree detection using Path(__file__).resolve().parent. This catches ALL install paths (Docker /opt/hermes, apt /usr/local/lib/hermes-agent, git clone, custom) instead of just the Docker image path. Also covers subdirectories of the install tree, not just the top-level dir. Add regression test test_install_tree_skipped to verify both the install root and subdirectories are excluded from chmod. Add contributor email mapping for bradmarshall987. Follow-up to PR #93050 by @bradmarshall987.
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.