6e2796b82d
Adolanium review §3 (Medium/Low). BASE shape at every steer/redirect/persist/agent-cache lock site was: lock = getattr(obj, "_x_lock", None); if lock is not None: with lock: <direct attribute read>; else: <getattr fallback for object.__new__ test stubs>. The refactor rewrote several of these as 'with getattr(...) or nullcontext(): getattr(slot, None)', which (a) turned a missing slot under the lock from a loud AttributeError into silent None and (b) in the gateway peek helper read the cache without any lock when the lock attribute was absent. Restored BASE semantics at: - agent/agent_runtime_helpers.py::_requeue_pending_steer - agent/interrupt_control.py: steer, redirect, clear_interrupt, _has_pending_redirect, _drain_pending_redirect, _drain_pending_steer (new _ic_slot helper: direct read under lock) - agent/session_persistence.py::_persist_lock (explicit None check + BASE rationale) - gateway/slash_commands.py::_cached_agent_for (BASE callers read ONLY under the lock; no lock -> None) - gateway/run_agent_cache.py::_evict_cached_agent (BASE: self._agent_cache direct under lock) - agent/client_lifecycle.py::_is_openai_client_closed: BASE body + docstring verbatim (outer is_closed first; inner _client.is_closed only when _client exists; else False) - agent/stream_delivery.py::_ensure_stream_writer_state: restore BASE rationale that the lock is created unconditionally in agent_init (_STREAM_STATE) and the lazy path is stub-only A/B (/tmp/rf/rev/ab_lock_fallbacks.py, ab_client_closed.py) is byte-identical BASE vs HEAD on the reviewer's inputs + edge cases. tests/agent/test_lock_fallback_base_semantics.py pins it (7 of 25 cases fail on the pre-fix tree).