6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
52 lines
1.5 KiB
Python
52 lines
1.5 KiB
Python
"""Per-provider ``extra_headers`` applied to the OpenAI client (#3526 salvage).
|
|
|
|
Custom providers (``providers`` / ``custom_providers`` in config.yaml) can
|
|
declare an ``extra_headers`` dict that must land on the OpenAI client's
|
|
``default_headers`` at construction and survive header re-application on
|
|
credential swaps / rebuilds. Values may carry credentials — the plumbing must
|
|
never log them.
|
|
"""
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from run_agent import AIAgent
|
|
|
|
_PROXY_URL = "https://llm.internal.example.com/v1"
|
|
_PROXY_CONFIG = {
|
|
"custom_providers": [
|
|
{
|
|
"name": "my-proxy",
|
|
"base_url": _PROXY_URL,
|
|
"api_key": "proxy-key",
|
|
"extra_headers": {
|
|
"CF-Access-Client-Id": "xxxx.access",
|
|
"X-Client-Name": "hermes-agent",
|
|
},
|
|
}
|
|
]
|
|
}
|
|
|
|
|
|
@patch("run_agent.OpenAI")
|
|
def test_custom_provider_extra_headers_applied_at_construction(mock_openai):
|
|
mock_openai.return_value = MagicMock()
|
|
with patch("hermes_cli.config.load_config", return_value=_PROXY_CONFIG):
|
|
agent = AIAgent(
|
|
api_key="proxy-key",
|
|
base_url=_PROXY_URL,
|
|
model="my-model",
|
|
provider="custom",
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=True,
|
|
)
|
|
|
|
headers = agent._client_kwargs["default_headers"]
|
|
assert headers["CF-Access-Client-Id"] == "xxxx.access"
|
|
assert headers["X-Client-Name"] == "hermes-agent"
|
|
|
|
|
|
|
|
|
|
|
|
|