Files
hermes-agent/apps/desktop/electron/window-connection-route.test.ts
T
liuhao1024 2afd17a9d7 fix(desktop): resolve v2 registry SSH terminals from the bootstrap pool key
The terminal pane's registry-scoped lookup keys sshConnections with
backendScopeKey(connectionId, profile), but the pool's single writer
publishes every tunnel under its per-profile bootstrap key with the
registry connection stamped on the entry. The lookup can never hit, so
a v2 registry SSH terminal pane stays 'pending' forever (#97345).

Fall back to the entry stamped with the window's connection id - the
same identity match managedSshScopeRole applies to pool entries - and
return the writer's actual scope so downstream getSshConnectionState
and teardown keep working.
2026-09-05 18:20:20 +05:30

141 lines
3.9 KiB
TypeScript

import assert from 'node:assert/strict'
import { test } from 'vitest'
import {
normalizeWindowConnectionRoute,
registrySshPoolScopeByConnectionId,
registrySshScopeForWindowRoute,
WindowConnectionRouteRegistry
} from './window-connection-route'
test('normalizes an exact registry-scoped connection and profile', () => {
assert.deepEqual(
normalizeWindowConnectionRoute({
connectionId: 'source-b',
profile: 'research',
registryScoped: true
}),
{
connectionId: 'source-b',
profile: 'research',
registryScoped: true
}
)
})
test('keeps legacy/profile-only routes distinct from registry identities', () => {
assert.deepEqual(normalizeWindowConnectionRoute({ profile: 'work' }), {
connectionId: null,
profile: 'work',
registryScoped: false
})
})
test('preserves a registry connection when no profile is selected', () => {
assert.deepEqual(
normalizeWindowConnectionRoute({
connectionId: 'source-b',
registryScoped: true
}),
{
connectionId: 'source-b',
profile: undefined,
registryScoped: true
}
)
})
test('isolates active routes by webContents id', () => {
const routes = new WindowConnectionRouteRegistry()
routes.set(11, { connectionId: 'source-a', profile: 'default', registryScoped: true })
routes.set(22, { connectionId: 'source-b', profile: 'worker', registryScoped: true })
assert.equal(routes.get(11)?.connectionId, 'source-a')
assert.equal(routes.get(22)?.connectionId, 'source-b')
routes.delete(11)
assert.equal(routes.get(11), null)
assert.equal(routes.get(22)?.connectionId, 'source-b')
})
test('invalid publications clear only the sender route', () => {
const routes = new WindowConnectionRouteRegistry()
routes.set(11, { connectionId: 'source-a', profile: 'default', registryScoped: true })
routes.set(22, { connectionId: 'source-b', profile: 'worker', registryScoped: true })
routes.set(11, null)
assert.equal(routes.get(11), null)
assert.equal(routes.get(22)?.connectionId, 'source-b')
})
test('routes a non-primary SSH connection independently from another window', () => {
const registry = {
primary: 'source-a',
connections: [
{ id: 'source-a', kind: 'ssh' },
{ id: 'source-b', kind: 'ssh' },
{ id: 'source-c', kind: 'remote' }
]
} as never
const routes = new WindowConnectionRouteRegistry()
routes.set(11, {
connectionId: 'source-b',
profile: 'worker',
registryScoped: true
})
routes.set(22, {
connectionId: 'source-c',
profile: 'default',
registryScoped: true
})
assert.equal(registrySshScopeForWindowRoute(routes.get(11), registry), 'conn:source-b::worker')
assert.equal(registrySshScopeForWindowRoute(routes.get(22), registry), null)
})
test('uses the canonical default profile scope when a registry SSH route has no profile', () => {
const registry = {
primary: 'source-a',
connections: [
{ id: 'source-a', kind: 'ssh' },
{ id: 'source-b', kind: 'ssh' }
]
} as never
assert.equal(
registrySshScopeForWindowRoute(
{
connectionId: 'source-b',
profile: undefined,
registryScoped: true
},
registry
),
'conn:source-b::default'
)
})
test('recovers the bootstrap pool key a registry SSH tunnel was published under', () => {
const pool = new Map<string, any>([['', { registryConnectionId: 'source-b', ssh: { alive: true } }]])
assert.equal(registrySshPoolScopeByConnectionId(pool, 'source-b'), '')
})
test('does not match another connection, an unlabelled entry, or a torn-down tunnel', () => {
const pool = new Map<string, any>([
['research', { registryConnectionId: 'source-a', ssh: { alive: true } }],
['', { registryConnectionId: '', ssh: { alive: true } }],
['worker', { registryConnectionId: 'source-b' }]
])
assert.equal(registrySshPoolScopeByConnectionId(pool, 'source-b'), null)
assert.equal(registrySshPoolScopeByConnectionId(pool, 'source-c'), null)
})