Teknium
d6f954f510
The salvaged detector recorded a second MONOSPACE range from a hand-rolled position walker and then had to rebase earlier ranges by the padding delta (the contributor's follow-up commit). Two range bookkeepers over one text is where the bugs were: a pipe table inside a fenced code block was realigned AND double-styled, because the walker ran after the fences were stripped and could no longer tell code from table. Run table realignment on the raw markdown instead, outside fences only, and wrap each aligned table in a fence. The existing code-block pass then emits exactly one MONOSPACE range per table and the existing removal/adjust machinery shifts every later range — no second offset model, no rebase loop. The contributor's fixup commit becomes unnecessary and is not carried. Tests trimmed to two invariants: a CJK/emoji table aligns by display width with correct UTF-16 offsets for the range and the style after it, and a fenced pipe table stays code while a real table before it keeps a later code range pointed at its own text (also covers the lone-pipe negative). Refs #106181
289 lines
11 KiB
Python
289 lines
11 KiB
Python
"""Tests for Signal markdown_to_signal() formatting.
|
|
|
|
Covers the markdown-to-bodyRanges conversion pipeline: bold, italic,
|
|
strikethrough, monospace, code blocks, headings, and — critically — the
|
|
false-positive regressions that caused spurious italics in production.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
from gateway.platforms.signal import SignalAdapter
|
|
from gateway.platforms.signal_format import markdown_to_signal
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Helper
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _m2s(text: str):
|
|
"""Shorthand: return (plain_text, styles)."""
|
|
return markdown_to_signal(text)
|
|
|
|
|
|
def _style_types(styles: list[str]) -> list[str]:
|
|
"""Extract just the STYLE part from '0:4:BOLD' strings."""
|
|
return [s.rsplit(":", 1)[1] for s in styles]
|
|
|
|
|
|
def _find_style(styles: list[str], style_type: str) -> list[str]:
|
|
"""Return only styles matching a given type."""
|
|
return [s for s in styles if s.endswith(f":{style_type}")]
|
|
|
|
|
|
# ===========================================================================
|
|
# Basic formatting
|
|
# ===========================================================================
|
|
|
|
class TestMarkdownToSignalBasic:
|
|
"""Core formatting: bold, italic, strikethrough, monospace."""
|
|
|
|
def test_bold_double_asterisk(self):
|
|
text, styles = _m2s("hello **world**")
|
|
assert text == "hello world"
|
|
assert len(styles) == 1
|
|
assert styles[0].endswith(":BOLD")
|
|
|
|
|
|
def test_italic_single_asterisk(self):
|
|
text, styles = _m2s("hello *world*")
|
|
assert text == "hello world"
|
|
assert len(styles) == 1
|
|
assert styles[0].endswith(":ITALIC")
|
|
|
|
|
|
def test_strikethrough(self):
|
|
text, styles = _m2s("hello ~~world~~")
|
|
assert text == "hello world"
|
|
assert len(styles) == 1
|
|
assert styles[0].endswith(":STRIKETHROUGH")
|
|
|
|
def test_inline_monospace(self):
|
|
text, styles = _m2s("run `ls -la` now")
|
|
assert text == "run ls -la now"
|
|
assert len(styles) == 1
|
|
assert styles[0].endswith(":MONOSPACE")
|
|
|
|
|
|
# ===========================================================================
|
|
# Italic false-positive regressions
|
|
# ===========================================================================
|
|
|
|
class TestItalicFalsePositives:
|
|
"""Regressions from signal-italic-false-positive-fix.md and
|
|
signal-italic-bullet-list-fix.md."""
|
|
|
|
# --- snake_case (original fix) ---
|
|
|
|
def test_snake_case_not_italic(self):
|
|
"""snake_case identifiers must NOT be italicized."""
|
|
text, styles = _m2s("the config_file is ready")
|
|
assert text == "the config_file is ready"
|
|
assert _find_style(styles, "ITALIC") == []
|
|
|
|
|
|
# --- Bullet lists (second fix) ---
|
|
|
|
|
|
def test_hyphen_bullet_list_uses_signal_safe_bullets(self):
|
|
"""Signal does not render Markdown list markers; normalize them."""
|
|
md = "- item one\n- item two"
|
|
text, styles = _m2s(md)
|
|
assert text == "• item one\n• item two"
|
|
assert styles == []
|
|
|
|
|
|
def test_bullet_list_file_paths(self):
|
|
"""Real-world case that triggered the bug."""
|
|
md = (
|
|
"* tools/delegate_tool.py — delegation\n"
|
|
"* tools/file_tools.py — file operations\n"
|
|
"* tools/web_tools.py — web operations"
|
|
)
|
|
text, styles = _m2s(md)
|
|
assert _find_style(styles, "ITALIC") == []
|
|
|
|
|
|
# --- Cross-line spans (DOTALL removal) ---
|
|
|
|
|
|
def test_underscore_italic_no_cross_line(self):
|
|
"""_foo\\nbar_ must NOT match as italic (no DOTALL)."""
|
|
text, styles = _m2s("_foo\nbar_")
|
|
assert _find_style(styles, "ITALIC") == []
|
|
|
|
def test_star_italic_multiline_response(self):
|
|
"""Multi-paragraph response with * should not false-positive."""
|
|
md = (
|
|
"I checked the following files:\n\n"
|
|
"* tools/delegate_tool.py — sub-agent delegation\n"
|
|
"* tools/file_tools.py — file read/write/search\n"
|
|
"* tools/web_tools.py — web search/extract\n\n"
|
|
"Everything looks good."
|
|
)
|
|
text, styles = _m2s(md)
|
|
assert _find_style(styles, "ITALIC") == []
|
|
|
|
# --- Legitimate italic still works ---
|
|
|
|
|
|
def test_multiple_italic_same_line(self):
|
|
text, styles = _m2s("*foo* and *bar* ok")
|
|
assert text == "foo and bar ok"
|
|
assert len(_find_style(styles, "ITALIC")) == 2
|
|
|
|
def test_italic_single_word(self):
|
|
text, styles = _m2s("*word*")
|
|
assert text == "word"
|
|
assert len(_find_style(styles, "ITALIC")) == 1
|
|
|
|
|
|
# ===========================================================================
|
|
# Style position accuracy
|
|
# ===========================================================================
|
|
|
|
class TestStylePositions:
|
|
"""Verify that start:length positions map to the correct text."""
|
|
|
|
def _extract(self, text: str, style_str: str) -> str:
|
|
"""Given 'start:length:STYLE', extract the substring from text."""
|
|
# Positions are UTF-16 code units; for ASCII they match code points
|
|
parts = style_str.split(":")
|
|
start, length = int(parts[0]), int(parts[1])
|
|
# Encode to UTF-16-LE, slice, decode back
|
|
encoded = text.encode("utf-16-le")
|
|
extracted = encoded[start * 2 : (start + length) * 2]
|
|
return extracted.decode("utf-16-le")
|
|
|
|
def test_bold_position(self):
|
|
text, styles = _m2s("hello **world** end")
|
|
assert len(styles) == 1
|
|
assert self._extract(text, styles[0]) == "world"
|
|
|
|
|
|
# ===========================================================================
|
|
# Edge cases
|
|
# ===========================================================================
|
|
|
|
class TestEdgeCases:
|
|
"""Tricky inputs that have caused issues or could regress."""
|
|
|
|
def test_bold_inside_bullet(self):
|
|
"""Bold inside a bullet list item."""
|
|
md = "* **important** item\n* normal item"
|
|
text, styles = _m2s(md)
|
|
assert len(_find_style(styles, "BOLD")) == 1
|
|
assert _find_style(styles, "ITALIC") == []
|
|
|
|
|
|
def test_lone_asterisk(self):
|
|
"""A single * with no pair should not cause issues."""
|
|
text, styles = _m2s("5 * 3 = 15")
|
|
# Should not crash; any italic match would be a false positive
|
|
assert "5" in text and "15" in text
|
|
|
|
|
|
# ===========================================================================
|
|
# signal-markdown-strip-patch: core conversion pipeline
|
|
# ===========================================================================
|
|
|
|
class TestMarkdownStripPatch:
|
|
"""Tests for the original signal-markdown-strip-patch.
|
|
|
|
Covers: fenced code blocks with language tags, links preserved,
|
|
headings converted to bold, multiple headings, UTF-16 correctness
|
|
for multi-byte characters, and marker stripping completeness.
|
|
"""
|
|
|
|
|
|
def test_fenced_code_block_multiline(self):
|
|
"""Multi-line code blocks preserve all lines."""
|
|
md = "```\nline1\nline2\nline3\n```"
|
|
text, styles = _m2s(md)
|
|
assert "line1" in text
|
|
assert "line2" in text
|
|
assert "line3" in text
|
|
assert "```" not in text
|
|
|
|
def test_links_preserved(self):
|
|
"""[text](url) links are kept as-is — Signal auto-linkifies."""
|
|
md = "Check [this link](https://example.com) for details"
|
|
text, styles = _m2s(md)
|
|
# Links should pass through — either as markdown or just preserved
|
|
assert "https://example.com" in text
|
|
|
|
def test_heading_h1(self):
|
|
"""# H1 becomes bold text."""
|
|
text, styles = _m2s("# Main Title")
|
|
assert text == "Main Title"
|
|
assert len(styles) == 1
|
|
assert styles[0].endswith(":BOLD")
|
|
|
|
|
|
def test_multiple_headings(self):
|
|
"""Multiple headings each become separate bold spans."""
|
|
md = "## First\n\nSome text\n\n## Second"
|
|
text, styles = _m2s(md)
|
|
assert "First" in text
|
|
assert "Second" in text
|
|
assert "##" not in text
|
|
bold_styles = _find_style(styles, "BOLD")
|
|
assert len(bold_styles) == 2
|
|
|
|
# ## at end might remain if not at line start — that's ok
|
|
# The important thing is styled markers are stripped
|
|
|
|
|
|
# ===========================================================================
|
|
# signal-streaming-patch: SUPPORTS_MESSAGE_EDITING and send() behavior
|
|
# ===========================================================================
|
|
|
|
class TestTableRealignment:
|
|
"""GFM pipe tables are re-aligned to a fixed monospace width and wrapped in a
|
|
single MONOSPACE style range, per the Signal table-rendering feature request."""
|
|
|
|
@staticmethod
|
|
def _u16_slice(text: str, style: str) -> str:
|
|
start, length = (int(p) for p in style.split(":")[:2])
|
|
u16 = text.encode("utf-16-le")
|
|
return u16[start * 2 : (start + length) * 2].decode("utf-16-le")
|
|
|
|
def test_wide_char_table_becomes_one_aligned_monospace_block(self):
|
|
"""Cells with CJK/emoji (2 display cells, 1-2 UTF-16 units) still produce pipes that line up
|
|
by display width, one MONOSPACE range covering exactly the block, and correct UTF-16 offsets
|
|
for styles after it."""
|
|
from wcwidth import wcswidth
|
|
|
|
text, styles = _m2s("| 名前 | Score |\n|---|---|\n| 東京 | 🚀 |\n| Bob | 1 |\n\n**tail**")
|
|
(mono,) = _find_style(styles, "MONOSPACE")
|
|
block = self._u16_slice(text, mono)
|
|
assert text == block + "\n\ntail"
|
|
rows = block.split("\n")
|
|
assert len(rows) == 4 and all(wcswidth(row) == wcswidth(rows[0]) for row in rows)
|
|
assert self._u16_slice(text, _find_style(styles, "BOLD")[0]) == "tail"
|
|
|
|
def test_fenced_pipe_table_is_code_and_later_code_range_survives_realignment(self):
|
|
"""A pipe table inside ``` is code and must not be realigned or double-styled; a table's
|
|
padding changes its length, and a code block after it still maps to its own text."""
|
|
text, styles = _m2s("| Name | Age |\n|---|---|\n| Alice | 30 |\n\n```\n| a | b |\n|---|---|\n| 1 | 22 |\n```")
|
|
mono = _find_style(styles, "MONOSPACE")
|
|
assert len(mono) == 2
|
|
assert self._u16_slice(text, mono[0]) == "| Name | Age |\n|-------|-----|\n| Alice | 30 |"
|
|
assert self._u16_slice(text, mono[1]) == "| a | b |\n|---|---|\n| 1 | 22 |"
|
|
assert "cost | value" == _m2s("cost | value\nnot a table")[0].split("\n")[0]
|
|
|
|
|
|
class TestSignalStreamingPatch:
|
|
"""Tests for signal-streaming-patch: cursor suppression and edit support.
|
|
|
|
These verify the adapter-level properties that prevent the streaming
|
|
cursor from leaking into Signal messages.
|
|
"""
|
|
|
|
def test_signal_does_not_support_editing(self, monkeypatch):
|
|
"""SignalAdapter.SUPPORTS_MESSAGE_EDITING must be False."""
|
|
monkeypatch.setenv("SIGNAL_GROUP_ALLOWED_USERS", "")
|
|
from gateway.platforms.signal import SignalAdapter
|
|
assert SignalAdapter.SUPPORTS_MESSAGE_EDITING is False
|
|
|