Ben
34c727c5c2
Bundles previously-separate Hindsight/memory PRs into a single review surface: - opt-in synchronous recall (recall_sync) — recall the injected memory in-turn instead of next-turn prefetch (#5820) - actionable error when local_embedded runtime is missing — tells the user which package to install (#7718) - default retain_source to 'hermes' so every stored memory self-identifies its provenance - offer a starter memory template during hermes memory setup, plus warn before overwriting an already-configured bank - warn when a configured memory provider reports unavailable (#2765) - deterministic 'recalled N memories' recall indicator — Hermes itself emits a status line when auto-recall injects memory - 'saving to memory' retain indicator — emitted the moment a turn is dispatched to the writer Authored by @benfrank241 (ben.bartholomew@vectorize.io). Salvaged from PR #74379.
57 lines
2.3 KiB
Python
57 lines
2.3 KiB
Python
"""NousResearch/hermes-agent#7718 — actionable message when local_embedded
|
|
runtime (`hindsight-all`) is missing.
|
|
|
|
`local_embedded` imports `from hindsight import HindsightEmbedded`, provided
|
|
only by `hindsight-all`. When it's absent the provider disables itself; the
|
|
disable warning should point the user at the fix rather than just echoing
|
|
`No module named 'hindsight'`.
|
|
"""
|
|
|
|
import sys
|
|
|
|
import plugins.memory.hindsight as hs
|
|
from plugins.memory.hindsight import HindsightMemoryProvider, _local_runtime_hint
|
|
|
|
|
|
def test_hint_for_missing_hindsight_all():
|
|
hint = _local_runtime_hint("No module named 'hindsight'")
|
|
assert "hindsight-all" in hint
|
|
assert "hermes memory setup" in hint
|
|
assert sys.executable in hint
|
|
|
|
|
|
def test_hint_for_missing_hindsight_embed():
|
|
hint = _local_runtime_hint("No module named 'hindsight_embed.daemon_embed_manager'")
|
|
assert "hindsight-all" in hint
|
|
|
|
|
|
def test_no_hint_for_unrelated_runtime_error():
|
|
# e.g. the NumPy-on-old-CPU failure _check_local_runtime also guards against
|
|
assert _local_runtime_hint("Illegal instruction (NumPy SIMD)") == ""
|
|
assert _local_runtime_hint(None) == ""
|
|
|
|
|
|
# unavailable_reason() — surfaces the hint through the reachable path (#7718):
|
|
# is_available() gates initialize() out, so the hint must come from here.
|
|
|
|
|
|
def test_unavailable_reason_surfaces_hint_for_local_embedded(monkeypatch):
|
|
monkeypatch.setattr(hs, "_load_config", lambda: {"mode": "local_embedded"})
|
|
monkeypatch.setattr(hs, "_check_local_runtime", lambda: (False, "No module named 'hindsight'"))
|
|
reason = HindsightMemoryProvider().unavailable_reason()
|
|
assert "hindsight-all" in reason
|
|
assert reason == reason.strip() # no leading/trailing whitespace
|
|
|
|
|
|
def test_unavailable_reason_empty_for_cloud(monkeypatch):
|
|
monkeypatch.setattr(hs, "_load_config", lambda: {"mode": "cloud"})
|
|
# Should not even probe the runtime for a cloud provider.
|
|
monkeypatch.setattr(hs, "_check_local_runtime", lambda: (_ for _ in ()).throw(AssertionError("probed")))
|
|
assert HindsightMemoryProvider().unavailable_reason() == ""
|
|
|
|
|
|
def test_unavailable_reason_empty_when_runtime_present(monkeypatch):
|
|
monkeypatch.setattr(hs, "_load_config", lambda: {"mode": "local_embedded"})
|
|
monkeypatch.setattr(hs, "_check_local_runtime", lambda: (True, None))
|
|
assert HindsightMemoryProvider().unavailable_reason() == ""
|