Teknium
53db597201
hermes_state.py: delete every '# noqa: F401 (re-exported...)' import block (hermes_state_common/errors/guard/
readpool/sessions/fts/dbfile/wal/repair/registry + agent.context_compressor _DB_PERSISTED_MARKER_KEY); keep
only the names hermes_state.py itself uses, without noqa.
hermes_state_registry.py: drop get_shared_session_db/release_shared_session_db/close_shared_session_dbs
aliases; every caller (gateway/, tools/, tui_gateway/, cron/, mcp_serve, run_agent, tests) now imports
acquire/release/close_all/release_or_close from hermes_state_registry.
hermes_state_titles.py: drop set_auto_title_if_empty shim (title_generator keeps its getattr fallback).
Re-remove shim-only names restored by 34abf954bd: latest_user_message_row_id (tests call
latest_message_row_id(key, role='user'); role-targeting assertions kept) and get_session_activity (tests
build the snapshot via agent.session_activity.build_activity_snapshot over db.get_session(sid)).
hermes_state_wal._log_once resolves its dedupe sets as module globals instead of via hermes_state;
hermes_state_repair helpers call module globals directly (tests patch hermes_state_repair.<name>).
Frozen updater surface untouched (update_cmd_maint imports only SessionDB from hermes_state).
78 lines
2.9 KiB
Python
78 lines
2.9 KiB
Python
"""The conftest WAL gate must agree with hermes_state, and must not import it.
|
|
|
|
``tests/conftest.py::_wal_is_usable`` duplicates the SQLite WAL-reset version
|
|
predicate instead of importing ``hermes_state``. That is deliberate: importing
|
|
``hermes_state`` during collection caches ``DEFAULT_DB_PATH`` from the real
|
|
``~/.hermes`` before the per-test ``HERMES_HOME`` redirect, which makes tests
|
|
read the developer's live production database.
|
|
|
|
Duplication needs a guard, so these tests pin the two implementations in
|
|
agreement across the documented upstream boundaries.
|
|
"""
|
|
|
|
import sqlite3
|
|
|
|
import pytest
|
|
|
|
from hermes_state_wal import is_sqlite_wal_reset_vulnerable
|
|
from tests.conftest import _wal_is_usable
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"version_info",
|
|
[
|
|
(3, 6, 23), # pre-WAL
|
|
(3, 7, 0), # first WAL release — vulnerable
|
|
(3, 44, 5), # below the 3.44 backport
|
|
(3, 44, 6), # 3.44 backport — fixed
|
|
(3, 45, 0), # next minor, back to vulnerable
|
|
(3, 50, 4), # the version that exposed this (repo .venv)
|
|
(3, 50, 6), # below the 3.50 backport
|
|
(3, 50, 7), # 3.50 backport — fixed
|
|
(3, 51, 2), # last vulnerable
|
|
(3, 51, 3), # fixed upstream
|
|
(3, 53, 1), # the managed runtime
|
|
],
|
|
)
|
|
def test_conftest_gate_agrees_with_hermes_state(version_info, monkeypatch):
|
|
"""``_wai_is_usable`` must be the exact inverse of the canonical predicate."""
|
|
monkeypatch.setattr(sqlite3, "sqlite_version_info", version_info)
|
|
assert _wal_is_usable() is not is_sqlite_wal_reset_vulnerable(version_info), (
|
|
f"conftest gate and hermes_state disagree for SQLite {version_info}"
|
|
)
|
|
|
|
|
|
def test_conftest_does_not_import_hermes_state_at_collection():
|
|
"""The gate must stay import-free of hermes_state.
|
|
|
|
Importing it during collection caches DEFAULT_DB_PATH from the real
|
|
~/.hermes, so tests read live production sessions instead of a tempdir.
|
|
Reading the source is not an option here (banned), so assert on behavior:
|
|
the gate must work with ``hermes_state`` absent from ``sys.modules`` and
|
|
blocked from being imported.
|
|
"""
|
|
import builtins
|
|
import sys
|
|
|
|
real_import = builtins.__import__
|
|
blocked: list[str] = []
|
|
|
|
def guard(name, *args, **kwargs):
|
|
if name == "hermes_state" or name.startswith("hermes_state."):
|
|
blocked.append(name)
|
|
raise AssertionError(
|
|
"conftest._wal_is_usable imported hermes_state — this caches "
|
|
"DEFAULT_DB_PATH from the real ~/.hermes during collection"
|
|
)
|
|
return real_import(name, *args, **kwargs)
|
|
|
|
saved = sys.modules.pop("hermes_state", None)
|
|
builtins.__import__ = guard
|
|
try:
|
|
_wal_is_usable() # must not raise
|
|
finally:
|
|
builtins.__import__ = real_import
|
|
if saved is not None:
|
|
sys.modules["hermes_state"] = saved
|
|
assert not blocked
|