9e6cfcda5a
Complements the cherry-picked contributor fixes and closes out the remaining sites of the 'missing explicit encoding' bug class, which is now permanently gated by ruff PLW1514 (enabled repo-wide in pyproject.toml and enforced by the blocking `ruff check .` step in .github/workflows/lint.yml): - tools/memory_tool.py: read MEMORY.md/USER.md via utf-8-sig so a Notepad BOM never glues U+FEFF onto the first entry (issue #10878, PR #10888 by @easyvibecoding — strict-decode contract of _read_raw_checked preserved rather than errors="replace", so undecodable files still refuse read-modify-write instead of being lossily rewritten). Regression tests included. - tools/skills_tool.py: SKILL.md and skill file reads pinned to utf-8-sig + errors="replace" — deterministic across platforms instead of the locale fallback proposed in PR #51701 (superseded: falling back to cp1252/GBK makes the same skill render differently per host); .env reader aligned with the canonical utf-8-sig dialect in hermes_cli/config.py. - agent/shell_hooks.py, hermes_cli/main.py, gateway/slash_commands.py: explicit utf-8 on the remaining fdopen/open text-mode sites flagged by the AlexFucuson9 sweep series (#56033 #56940 #65565 #66782 #66791). Co-authored-by: easyvibecoding <easyvibecoding@users.noreply.github.com> Co-authored-by: AlexFucuson9 <AlexFucuson9@users.noreply.github.com> Co-authored-by: flyingdoubleg <wangzhe00zju@gmail.com> Co-authored-by: LeonSGP43 <cine.dreamer.one@gmail.com>
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.