Michel Alexander e73257ccc1 feat(cli): filter MCP server spawning by -t/--toolsets flag + fix orphan subprocess leak ...

v5 — addresses GPT-5.5 fusion-judge SHIP_WITH_FIXES on v4.
One-line cosmetic fix: SIGTERM handler now uses cleanup-scope local
alias `_os_local.kill(_os_local.getpid(), signum)` instead of bare
`os.kill(os.getpid(), signum)`, completing the self-containment intent.
Behavior unchanged (verified: SIGTERM still exits 143, SIGINT still 130).

═══ Code review history ═══

- v1: qwen3-max single review → SHIP_WITH_FIXES
- v2: Fusion (Codex+Sonnet+Gemini, GPT-5.5 judge) → NEEDS_REWORK (7 fixes)
- v3: Fusion → SHIP_WITH_FIXES (3 required + 4 hardening fixes)
- v4: Fusion → SHIP_WITH_FIXES (1 cosmetic — use _os_local in SIGTERM)
- v5 (this commit): cosmetic fix applied; behavior verified unchanged

═══ Final fix tracking ═══

| v2 required fix                       | Final |
|---------------------------------------|-------|
| 1. Fail-open import behavior          | FIXED |
| 2. SIGTERM exit code 143              | FIXED |
| 3. Unmatched -t warning logic         | FIXED |
| 4. _stdio_pids robustness             | FIXED |
| 5. time/os imports verified           | FIXED |
| 6. Poll-loop logger.debug             | FIXED |
| 7. Idempotency guard                  | FIXED |
| 8. SIGTERM uses self-contained _os    | FIXED (v5) |

═══ Verified locally (final) ═══

  hermes -z "ACK" -t web        : 4.8s wall (was 65s — 93% reduction)
  hermes -z "ACK" -t slack      : 5.5s wall (was 67s — 92% reduction)
  hermes -z "ACK"  (no -t)      : 75s     (unchanged — backwards-compat)
  SIGINT mid-flight             : exit 130 ✓
  SIGTERM mid-flight            : exit 143 ✓
  Orphan accumulation           : 0 new PPID=1 across 10+ runs

Related issues:
- Fixes the MCP subprocess component of #18438 (gateway memory leak)
- Supersedes the startup-drag portion of #18523 (closed unmerged)
- Extends toolset-gating pattern from #18166 and #5788 (memory) to MCPs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

2026-09-03 03:16:04 +05:30

..

computer_use

fix(computer-use): stop launching retired browser-grant runtimes

2026-08-29 18:35:17 -07:00

environments

fix(docker): keep forwarded secret values out of world-readable argv

2026-08-31 11:29:17 -07:00

neutts_samples

…

wakewords

feat(voice): bundle the trained "hey hermes" model as the out-of-the-box default

2026-07-28 07:58:16 -07:00

__init__.py

…

annotate_preview_tool.py

polish(tool-search): stub-optimized openers for deferred tools — trigger+verb in the first ~60 chars (the catalog stub is the only ambient hint a deferred tool exists)

2026-08-29 18:13:20 -07:00

ansi_strip.py

Port from block/goose#10746: strip invisible Unicode TAG chars from MCP content

2026-08-16 22:08:05 -07:00

apply_layout_tool.py

refactor(desktop-tools): consolidate preview + project, diet the desktop_ui suite (3,861 → 2,293 tok/call, −41%) (#97659)

2026-08-28 23:10:01 -07:00

approval.py

feat(bot-mode): add scoped cross-gateway Group Chat transport

2026-08-31 01:04:11 -07:00

async_delegation.py

fix(delegation): expose state durability barriers

2026-08-27 13:48:51 -07:00

audio_container.py

refactor: extract shared audio container sniffer to tools/audio_container.py

2026-07-28 11:52:44 -07:00

binary_extensions.py

fix: cover remaining anydoc-extracted container formats

2026-08-15 02:51:59 +05:30

blueprints.py

fix(cron): surface initial scheduler registration failures

2026-08-07 17:45:06 +05:30

bot_failure_reasons.py

feat(bots): retry session policy — resume transient turns, compress-and-resume on context overflow (#93091 item 5)

2026-08-23 20:00:18 -07:00

bot_mode_dm.py

fix(bot-mode): DMs to a Desktop-owned Bot Chat land in the live session instead of being dropped (#100523)

2026-09-02 06:18:55 -07:00

bot_mode_probe.py

feat(bot-mode): bots on every Desktop connection can message each other

2026-08-23 02:16:11 -07:00

bot_relay.py

perf(bot-mode): cold DM hops skip the live /models probe; relay replies land within 250ms

2026-09-02 03:42:01 -07:00

browser_camofox_state.py

…

browser_camofox.py

feat(browser): make snapshot threshold configurable

2026-08-24 21:51:44 -07:00

browser_cdp_tool.py

fix(browser): bind CDP binary exemptions to exact method result paths

2026-08-28 04:57:52 -07:00

browser_dialog_tool.py

…

browser_extension_router.py

fix(browser): bind the extension lane at controller registration, not transport auth

2026-08-21 22:33:45 +05:30

browser_lightpanda.py

fix(browser): lightpanda review follow-ups for #99312

2026-08-31 21:59:11 +05:30

browser_supervisor.py

perf(imports): lazy-load heavy SDKs off the cold-start waterfall

2026-07-29 10:54:04 -07:00

browser_tool.py

perf(mcp): one parent-death supervisor per process, not one per stdio server

2026-09-03 02:24:06 +05:30

browser_use_cli.py

feat(browser): honor browser.engine=lightpanda in Browser Use mode

2026-08-31 21:59:11 +05:30

budget_config.py

fix: read tool_budget config via load_config_readonly (config read guard)

2026-08-19 16:31:16 -07:00

checkpoint_manager.py

fix(checkpoints): display failed deletes to users and stabilize result keys

2026-08-26 18:02:17 +05:30

clarify_gateway.py

fix(gateway): cancel native clarify only on free prose

2026-08-14 21:24:36 -07:00

clarify_tool.py

refactor(clarify): schema diet + single questions[] interface (880 → 335 tok/call, −62%) (#95907)

2026-08-26 16:42:44 -07:00

close_preview_tool.py

refactor(desktop-tools): consolidate preview + project, diet the desktop_ui suite (3,861 → 2,293 tok/call, −41%) (#97659)

2026-08-28 23:10:01 -07:00

close_terminal_tool.py

polish(tool-search): stub-optimized openers for deferred tools — trigger+verb in the first ~60 chars (the catalog stub is the only ambient hint a deferred tool exists)

2026-08-29 18:13:20 -07:00

code_execution_tool.py

fix(terminal): scope terminal config per turn under profile multiplexing

2026-09-02 05:34:28 -07:00

code_kernel_remote.py

feat(code-execution): remote kernel host — session persistence for docker/ssh/modal backends (closes #96873) (#96991)

2026-08-28 01:39:33 -07:00

code_kernel.py

feat(execute_code): stdout spillover — truncated output's full text saved to cache/exec (host) or kernel tmpdir (cells), path + read_file recipe in the result (#97043)

2026-08-28 03:05:03 -07:00

computer_use_tool.py

feat(computer_use): align cua-driver 0.10 permission modes

2026-07-29 12:19:37 -07:00

credential_files.py

fix(credential_files): apply the same exclusions to the symlink-safe mount copy

2026-09-03 01:33:18 +05:30

cronjob_tools.py

fix(cron): delivery bookkeeping reads the failure lane it actually routed through

2026-09-02 20:16:14 +05:30

daemon_pool.py

fix(gateway): hygiene compaction keeps the profile secret scope under multiplexing

2026-09-01 22:28:52 -07:00

debug_helpers.py

…

delegate_tool.py

feat: delegation batch tags read "set N" instead of a hex id slice

2026-09-02 10:12:54 -07:00

delegation_live_log.py

feat(delegation): record model/provider in live-transcript manifest (#telemetry)

2026-08-16 20:14:51 -07:00

delegation_output_schema.py

feat(delegation): optional structured-output schema on delegate_task

2026-08-07 09:07:42 -07:00

desktop_ui.py

feat(tools): withdraw tip and tour when the user switches them off

2026-08-31 21:11:11 -05:00

discord_tool.py

fix(tools): isolate model tools by multiplex profile

2026-08-02 00:11:50 -07:00

drive_preview_tool.py

refactor(desktop-tools): consolidate preview + project, diet the desktop_ui suite (3,861 → 2,293 tok/call, −41%) (#97659)

2026-08-28 23:10:01 -07:00

env_passthrough.py

fix(security): scope passthrough env to routed profile

2026-08-02 00:36:03 -07:00

env_probe.py

fix(terminal): scope terminal config per turn under profile multiplexing

2026-09-02 05:34:28 -07:00

fal_common.py

…

feishu_doc_tool.py

…

feishu_drive_tool.py

…

file_operations.py

perf(file-ops): count the native read's tail with memchr; reuse the local-env gate

2026-09-03 02:27:52 +05:30

file_state.py

…

file_tools.py

fix(files): allow one full read after compaction

2026-09-03 03:07:37 +05:30

focus_pane_tool.py

refactor(desktop-tools): consolidate preview + project, diet the desktop_ui suite (3,861 → 2,293 tok/call, −41%) (#97659)

2026-08-28 23:10:01 -07:00

fuzzy_match.py

refactor(tools): extract IDENTICAL_STRINGS_ERROR constant

2026-08-12 15:21:47 +05:30

homeassistant_tool.py

fix(tools): isolate model tools by multiplex profile

2026-08-02 00:11:50 -07:00

hook_output_spill.py

fix(tools): symlink-safe exclusive creation for all spill/cache writers

2026-08-13 11:09:51 -07:00

image_generation_tool.py

refactor(image_generate): capability-gated dynamic schema (554 → 317 tok/call, −43%) (#97057)

2026-08-28 03:58:52 -07:00

image_source.py

fix(image_gen): confine generation source images to the terminal backend

2026-08-08 04:19:38 -07:00

interpreter_shutdown.py

fix: quitting the CLI no longer spams shutdown-race API errors onto the shell

2026-08-23 16:04:41 -07:00

interrupt.py

fix(terminal): bound env.execute wait so a wedged poll cannot disable every timer

2026-08-31 10:42:39 -07:00

kanban_tools.py

fix(loops): pause /loop --until on a blocked verdict; trim redundant gate condition and duplicate test

2026-09-02 05:32:01 -07:00

lazy_deps.py

fix(lazy-deps): pass --compile-bytecode on the uv tier and skip metadata dirs in the warm

2026-09-02 00:03:55 -07:00

managed_tool_gateway.py

fix(gateway): read auth.json as UTF-8 in _read_nous_provider_state

2026-08-08 12:32:23 -07:00

mcp_dashboard_oauth.py

…

mcp_death_supervisor.py

fix(mcp): wait() the released supervisor so it does not linger as a zombie

2026-09-03 02:24:06 +05:30

mcp_oauth_manager.py

fix(tools): narrow MCP OAuth lock scope

2026-08-28 20:16:26 -07:00

mcp_oauth.py

docs: update secure_parent_dir docstring and caller comments for the install-tree exclusion

2026-08-25 10:55:53 +10:00

mcp_schema_cache.py

feat(mcp): speak the 2026-07-28 stateless protocol

2026-08-17 03:03:35 -07:00

mcp_tool.py

feat(cli): filter MCP server spawning by -t/--toolsets flag + fix orphan subprocess leak

2026-09-03 03:16:04 +05:30

memory_tool.py

fix(memory): bound invalid-target error and restore recovery hint

2026-08-20 20:20:23 -07:00

microsoft_graph_auth.py

…

microsoft_graph_client.py

fix(teams): request supported transcript content format

2026-08-26 02:54:35 +05:30

neutts_synth.py

fix(voice): reconcile NeuTTS backbone/codec GPU device strings

2026-07-28 14:07:21 -07:00

open_preview_tool.py

refactor(desktop-tools): consolidate preview + project, diet the desktop_ui suite (3,861 → 2,293 tok/call, −41%) (#97659)

2026-08-28 23:10:01 -07:00

openrouter_client.py

fix(secrets): scope-aware credential reads in core tool/gateway/web-server paths

2026-08-02 10:02:33 -07:00

osv_check.py

refactor(tools): collapse the OSV disk-cache load except ladder

2026-09-03 02:05:42 +05:30

patch_parser.py

fix(tools): skip degenerate identical hunks in V4A validation

2026-08-12 15:21:47 +05:30

path_security.py

refactor: migrate hand-rolled error envelopes to shared tool_error()

2026-07-29 10:14:00 -07:00

plugin_guard.py

fix(skills): catch sed flag variants; exempt content-contract prose in plugin code

2026-08-28 03:24:43 -07:00

preview_tool.py

polish(tool-search): stub-optimized openers for deferred tools — trigger+verb in the first ~60 chars (the catalog stub is the only ambient hint a deferred tool exists)

2026-08-29 18:13:20 -07:00

process_registry.py

fix(process): keep the sandbox log poller from splitting a UTF-8 character across polls

2026-09-03 02:20:46 +05:30

project_tools.py

polish(tool-search): stub-optimized openers for deferred tools — trigger+verb in the first ~60 chars (the catalog stub is the only ambient hint a deferred tool exists)

2026-08-29 18:13:20 -07:00

react_to_message_tool.py

fix(state): consolidate gateway SessionDB writers via process-wide shared registry

2026-09-01 20:55:35 +05:30

read_extract.py

refactor(read_file): schema diet + bundle anydoc 0.2.4 + typed NeedsOcrError/hosted-OCR wiring (#97195)

2026-08-28 08:46:11 -07:00

read_preview_tool.py

refactor(desktop-tools): consolidate preview + project, diet the desktop_ui suite (3,861 → 2,293 tok/call, −41%) (#97659)

2026-08-28 23:10:01 -07:00

read_terminal_tool.py

refactor(desktop-tools): consolidate preview + project, diet the desktop_ui suite (3,861 → 2,293 tok/call, −41%) (#97659)

2026-08-28 23:10:01 -07:00

read_window_tool.py

refactor(desktop-tools): consolidate preview + project, diet the desktop_ui suite (3,861 → 2,293 tok/call, −41%) (#97659)

2026-08-28 23:10:01 -07:00

registry.py

fix(gateway): discover and reload MCP servers per profile under multiplex

2026-09-02 07:00:13 -07:00

schema_sanitizer.py

feat(mcp): collapse const-only anyOf/oneOf unions to property enums

2026-08-07 08:58:25 -07:00

self_repo_guard.py

fix: make the self-repo git guard Windows-only

2026-08-17 10:03:36 -07:00

send_message_tool.py

fix(buzz): complete media-only delivery reporting

2026-08-31 10:06:34 -07:00

session_search_tool.py

Merge origin/main into core-tool-deferral (resolve show_tip test seam onto the check_tips_enabled gate)

2026-09-01 21:49:14 -07:00

setup_mcp_tool.py

fix(tools): restore setup_mcp's never-hand-edit instruction

2026-08-29 17:58:51 -07:00

shell_heredoc.py

perf(tools): linear-time masking rebuild + last-opener early exit

2026-08-12 13:57:59 +05:30

skill_ledger.py

fix(curator): restore complete skill packages on ledger rollback (#96962)

2026-08-31 10:08:13 -07:00

skill_linter.py

fix: suppress windows-footgun false positives in linter pattern list

2026-08-08 11:12:27 -07:00

skill_manager_tool.py

feat(skills): skills.create_dir routes agent-created skills to a configured directory

2026-09-01 07:32:45 -07:00

skill_provenance.py

…

skill_usage.py

fix(curator): restore complete skill packages on ledger rollback (#96962)

2026-08-31 10:08:13 -07:00

skillevaluator_scan.py

fix: address second-round SkillEvaluator review feedback

2026-08-17 17:04:40 -07:00

skills_ast_audit.py

…

skills_guard.py

fix(security): widen the exfil substring-suffix fix to the skills-guard sibling patterns

2026-08-29 20:39:31 -07:00

skills_hub.py

feat(desktop): built-in optional-skills catalog in Capabilities → Skills with one-click install

2026-09-01 01:39:59 -07:00

skills_sync_client.py

fix(sync): read org state from the org endpoints, not the personal ones (#75237)

2026-07-30 22:31:42 -07:00

skills_sync.py

fix: system prompt no longer references tools/skills the session can't use; hermes-agent skill is always kept

2026-08-24 20:25:10 -07:00

skills_tool.py

fix(skills): skill_view directory file_path + skill_manage categorized name resolution

2026-08-30 20:04:40 +05:30

slash_confirm.py

…

spill_safety.py

fix(tools): symlink-safe exclusive creation for all spill/cache writers

2026-08-13 11:09:51 -07:00

subagent_worktree.py

fix(security): close GitSpawn RCE class — malicious repo .git/config no longer executes on context gathering (GHSA-7x36-8jrh-v4pw)

2026-09-02 10:33:43 -07:00

terminal_hints.py

fix(terminal): warn when exit_code 0 masks a piped build/test failure

2026-08-15 23:48:15 -07:00

terminal_scope.py

fix(terminal): scope terminal config per turn under profile multiplexing

2026-09-02 05:34:28 -07:00

terminal_tool.py

refactor(terminal): share the force_remove-aware env teardown between cleanup_vm and the probe

2026-09-03 02:07:42 +05:30

thread_context.py

…

threat_patterns.py

fix(security): widen the exfil substring-suffix fix to the skills-guard sibling patterns

2026-08-29 20:39:31 -07:00

tip_tool.py

Merge origin/main into core-tool-deferral (resolve show_tip test seam onto the check_tips_enabled gate)

2026-09-01 21:49:14 -07:00

tirith_security.py

fix(secrets): scope tier-3 credential reads (teams_pipeline, deepinfra models, FAL/XAI/VERCEL/DAYTONA/GITHUB presence, HERMES_API_KEY display)

2026-08-02 10:04:48 -07:00

todo_tool.py

Merge origin/main — resolve todo-state seam onto the todo_list rename (accept legacy alias)

2026-08-29 18:55:29 -07:00

tool_backend_helpers.py

fix(web): drop tavily from the removed-backend registry after the restore

2026-09-01 10:56:49 -07:00

tool_output_limits.py

…

tool_result_storage.py

feat: identical re-calls enter context as reference stubs, not duplicate payloads

2026-08-20 00:16:22 -07:00

tool_search.py

fix(tool-search): validate deferred tool_call arguments against the concrete schema before dispatch

2026-09-01 23:30:33 -07:00

tour_tool.py

Merge origin/main into core-tool-deferral (resolve show_tip test seam onto the check_tips_enabled gate)

2026-09-01 21:49:14 -07:00

transcription_tools.py

fix(stt): surface the selection-specific error for explicit openai STT

2026-08-23 18:25:35 -07:00

tts_streaming.py

fix(tts): route streaming-provider secrets through resolve_provider_secret; bound per-sentence stream bodies at 16 MiB

2026-07-28 22:31:40 -07:00

tts_text_normalize.py

fix(tts): unify TTS text preprocessing behind one shared cleaner

2026-07-28 11:55:01 -07:00

tts_tool.py

fix(tts): resolve default output dir from the active profile

2026-09-02 06:48:31 -07:00

url_safety.py

feat(web): add Tavily web search and extract provider

2026-09-01 10:56:49 -07:00

video_generation_tool.py

refactor(video_generate): capability-gated dynamic schema (~814 → 458/377 tok/call) (#97095)

2026-08-28 05:10:33 -07:00

vision_tools.py

feat: local models — managed llama.cpp runtime with one-click desktop setup

2026-09-01 16:01:53 -04:00

voice_client_config.py

feat(desktop): client-direct voice — use the active profile's STT/TTS keys from the desktop, no audio relay

2026-08-23 03:54:52 -07:00

voice_mode.py

feat(plugins): add pre_transcription hook and STT prompt threading

2026-08-12 19:01:30 -07:00

wake_word.py

fix(wake-word): capture at native input rate

2026-08-08 13:49:24 +05:30

web_result_cache.py

feat(web): cache_exempt_hosts — always-live fetches for staging/tunnel sites

2026-08-25 04:21:45 -07:00

web_tools.py

fix(tavily): update Tavily provider documentation

2026-09-01 10:56:49 -07:00

website_policy.py

…

working_diff.py

fix(security): close GitSpawn RCE class — malicious repo .git/config no longer executes on context gathering (GHSA-7x36-8jrh-v4pw)

2026-09-02 10:33:43 -07:00

write_approval.py

…

x_search_tool.py

refactor(xai): lift API-key precedence into resolve_xai_http_credentials behind prefer_api_key

2026-08-16 21:20:29 -07:00

xai_http.py

refactor(xai): lift API-key precedence into resolve_xai_http_credentials behind prefer_api_key

2026-08-16 21:20:29 -07:00

xai_video_tools.py

…

yuanbao_tools.py

…