c7d0f6c35f
Follow-up to the salvaged CommandCode signature fix: accepting base_url but ignoring it left custom endpoints (user-configured model.base_url / COMMANDCODE_BASE_URL proxies) fetching the public catalog instead of the configured one. Reviewer dansigma flagged this on PR #88851. Class-wide fix, not a CommandCode patch: - providers/base.py: a caller base_url that DIFFERS from the profile's default now wins over models_url. Equality with the default means "not customised" (callers pass base_url unconditionally, defaulting to the profile's own URL) and keeps models_url as the endpoint, preserving the OpenRouter-style split-catalog behavior. - commandcode: _fetch_commandcode_models() takes the endpoint override; both profile overrides forward base_url. - Tests: base-class precedence (custom beats models_url, default does not), CommandCode redirect via live local HTTP server incl. claude-* filter, and default-echo hitting the canonical endpoint. All verified to fail against the pre-fix implementation (sabotage run).
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.