beardthelion
b3c1b3b3f3
fix(kanban): address review feedback on goal_mode judge gate
...
Apply naqerl's review comments on PR #38388 :
- Hoist `from hermes_cli.goals import judge_goal` to module-level
imports so an import failure surfaces at module init, not lazily
on the first goal-mode completion (no circular import: hermes_cli
package init is trivial and does not load tools.kanban_tools).
- Narrow the fail-open `try` to wrap only the judge_goal() call.
The verdict check and its rejection `return tool_error(...)` now
live outside the handler, so a failure there can no longer be
swallowed by the broad except.
- Pass `exc_info=True` to the logger.warning call per CONTRIBUTING.md.
Update the test mock target to tools.kanban_tools.judge_goal, since
the hoisted import rebinds the name into this module's namespace.
2026-06-29 22:20:19 -07:00
..
2026-06-27 15:59:00 -07:00
2026-06-29 11:01:08 +10:00
2026-06-28 19:04:18 -07:00
2026-06-20 11:27:12 -07:00
2026-06-11 10:49:47 -07:00
2026-06-29 01:26:24 -07:00
2026-06-15 12:44:44 -04:00
2026-05-19 22:34:05 -07:00
2026-05-30 07:31:25 -07:00
2026-06-29 04:25:26 -07:00
2026-06-21 17:46:38 +05:30
2026-06-28 17:44:47 -05:00
2026-06-28 04:13:19 -07:00
2026-06-19 07:34:02 -07:00
2026-06-28 21:15:14 -05:00
2026-06-29 10:00:49 -07:00
2026-06-22 06:42:30 -07:00
2026-06-29 10:00:49 -07:00
2026-06-26 01:11:11 -07:00
2026-06-25 13:52:06 -07:00
2026-06-27 03:59:36 +05:30
2026-05-07 05:11:09 -07:00
2026-06-28 02:05:43 -07:00
2026-06-08 22:46:57 -07:00
2026-05-22 04:10:45 -07:00
2026-05-08 16:39:32 -07:00
2026-05-08 16:39:32 -07:00
2026-06-20 23:23:47 -07:00
2026-06-29 15:32:20 +10:00
2026-06-26 01:55:27 +05:30
2026-06-25 12:38:33 -07:00
2026-06-29 22:20:19 -07:00
2026-06-29 00:25:36 -07:00
2026-05-30 07:58:08 -07:00
2026-06-26 00:35:27 -07:00
2026-06-27 04:59:23 +05:30
2026-06-28 04:47:39 -07:00
2026-06-25 00:51:12 +05:30
2026-05-08 09:27:26 -07:00
2026-05-08 09:27:26 -07:00
2026-06-06 18:30:39 -07:00
2026-05-20 01:46:40 -05:00
2026-06-28 21:15:14 -05:00
2026-06-25 16:40:27 -05:00
2026-06-13 14:42:51 -07:00
2026-06-09 23:15:20 -05:00
2026-06-27 19:29:00 -07:00
2026-06-12 00:30:51 -05:00
2026-06-28 12:48:08 +05:30
2026-06-27 04:41:22 -07:00
2026-06-27 20:45:57 -07:00
2026-05-04 02:42:16 -07:00
2026-06-25 22:03:02 -07:00
2026-05-23 17:47:26 -07:00
2026-06-01 01:58:48 -07:00
2026-06-28 21:14:01 -07:00
2026-06-27 21:07:53 -07:00
2026-06-28 18:53:00 -07:00
2026-05-15 14:00:01 -07:00
2026-06-29 11:35:41 +10:00
2026-05-29 03:44:49 -07:00
2026-06-26 00:36:01 -07:00
2026-06-26 15:26:08 +05:30
2026-06-25 23:42:42 +05:30
2026-06-01 06:32:48 +05:30
2026-05-31 00:50:19 -07:00
2026-05-09 18:44:58 -07:00
2026-05-29 02:04:12 -07:00
2026-06-28 10:19:21 -05:00
2026-06-28 10:19:21 -05:00
2026-06-21 13:56:35 -07:00
2026-06-29 21:11:58 -07:00
2026-06-29 01:27:10 -07:00
2026-06-08 22:46:57 -07:00
2026-06-29 10:00:49 -07:00
2026-05-28 04:52:42 -07:00
2026-06-10 02:57:15 -07:00
2026-05-28 22:26:25 -07:00
2026-06-29 21:11:58 -07:00
2026-06-29 21:11:58 -07:00
2026-05-23 01:40:35 -07:00