Brooklyn Nicholson
b3f6218aa5
fix(desktop): a checkbox reports whether it is ticked, not the string "on"
...
An unset checkbox's `.value` is "on" per the HTML spec, and the inventory read
the value before the state — so a ticked box and an empty one both came back as
`value: "on"`, and the agent had no way to tell them apart. Anything built on
reading a form back ("is the newsletter box already checked?") was answering
from a coin flip.
The state check now runs first, gated on the input's type rather than on
`checked` being defined — it is defined, as false, on every input including
text fields, which is what made the original ordering look reasonable. ARIA
checkboxes and switches built out of divs read `aria-checked`, which the old
branch would have missed anyway since a div has no `.checked`.
Found by putting the extracted helper under a direct test. It was unreachable
before: the only way to observe it was to run a whole action against a whole
document.
2026-08-20 05:26:37 -05:00
..
2026-08-20 05:26:37 -05:00
2026-08-18 07:51:43 -05:00
2026-08-20 05:26:37 -05:00
2026-08-19 06:13:16 +00:00
2026-07-26 19:29:25 -07:00
2026-07-26 19:29:25 -07:00
2026-08-19 10:50:52 -05:00
2026-07-27 21:23:46 -05:00
2026-07-28 03:43:07 +00:00
2026-08-19 10:51:12 -05:00
2026-08-17 12:12:24 -07:00
2026-08-15 01:04:19 -07:00
2026-08-15 01:04:19 -07:00
2026-08-15 13:31:35 -07:00
2026-07-03 13:48:44 -05:00
2026-08-19 10:50:52 -05:00
2026-07-15 07:39:42 -07:00
2026-07-16 01:42:02 +05:30
2026-08-19 05:11:57 +00:00
2026-08-18 22:03:25 -07:00
2026-08-16 23:33:14 +00:00
2026-08-18 14:45:23 -07:00
2026-08-18 14:45:23 -07:00
2026-08-15 01:03:57 -07:00
2026-08-15 01:03:57 -07:00
2026-08-16 20:53:44 -07:00
2026-08-19 10:50:52 -05:00
2026-07-24 18:14:17 +00:00
2026-07-24 12:55:06 -05:00
2026-07-29 14:04:21 -06:00
2026-08-14 13:40:19 -07:00
2026-08-01 02:32:28 -05:00
2026-08-01 02:32:28 -05:00
2026-07-26 19:29:25 -07:00
2026-08-09 09:51:41 +00:00
2026-07-15 03:13:33 -04:00
2026-08-03 18:37:31 +05:30
2026-08-03 18:37:31 +05:30
2026-07-13 17:57:54 -04:00
2026-07-13 17:57:54 -04:00
2026-08-18 06:16:29 -05:00
2026-08-18 23:53:07 -04:00
2026-08-18 20:40:02 +00:00
2026-08-15 09:33:47 +00:00
2026-08-15 09:33:47 +00:00
2026-07-26 17:48:05 -07:00
2026-07-03 05:08:13 -05:00
2026-08-14 20:40:24 -07:00
2026-08-14 20:40:24 -07:00
2026-07-08 16:52:10 +02:00
2026-08-19 10:50:52 -05:00
2026-07-20 20:54:36 -04:00
2026-08-10 04:52:19 -05:00
2026-08-18 14:26:28 -07:00
2026-08-18 21:38:17 +00:00
2026-08-19 19:25:37 -07:00
2026-08-15 01:03:57 -07:00
2026-08-15 01:03:57 -07:00
2026-07-26 02:56:08 -05:00
2026-08-03 18:17:24 +05:30
2026-08-14 21:10:13 -07:00
2026-08-14 21:10:13 -07:00
2026-07-28 02:27:11 -05:00
2026-07-28 02:27:11 -05:00
2026-07-03 05:08:13 -05:00
2026-07-03 05:08:13 -05:00
2026-08-16 09:32:26 +00:00
2026-08-19 10:50:52 -05:00
2026-07-03 13:48:44 -05:00
2026-08-05 10:26:48 -06:00
2026-08-05 10:26:48 -06:00
2026-07-18 18:53:41 -04:00
2026-07-26 17:02:59 -05:00
2026-08-13 03:33:45 +00:00
2026-08-12 11:08:55 -07:00
2026-08-13 13:36:54 -05:00
2026-08-13 13:36:54 -05:00
2026-08-18 20:40:02 +00:00
2026-08-18 14:19:39 -07:00
2026-08-19 23:10:25 -05:00
2026-08-13 17:41:47 -05:00
2026-08-16 02:24:32 -07:00
2026-08-16 02:24:32 -07:00
2026-07-17 14:30:29 +00:00
2026-08-13 01:06:51 -05:00
2026-08-16 02:25:14 -07:00
2026-08-16 09:32:26 +00:00
2026-08-15 02:03:24 -07:00
2026-08-16 17:16:57 +00:00
2026-08-19 10:50:52 -05:00
2026-08-16 02:36:54 -07:00
2026-08-16 02:36:54 -07:00
2026-08-19 10:50:52 -05:00
2026-07-03 05:08:28 -05:00
2026-07-03 05:08:28 -05:00
2026-08-15 09:33:47 +00:00
2026-08-18 14:09:01 -07:00
2026-07-30 21:43:14 -05:00
2026-08-01 02:15:02 -05:00
2026-08-15 07:46:57 +00:00
2026-08-15 00:35:28 -07:00
2026-07-27 07:00:22 +00:00
2026-07-25 21:20:54 -05:00
2026-07-25 21:20:54 -05:00
2026-08-08 14:50:43 -05:00
2026-08-08 14:50:43 -05:00
2026-08-15 01:21:40 -07:00
2026-08-15 01:21:40 -07:00
2026-08-09 10:33:58 -07:00
2026-08-19 10:50:51 -05:00
2026-08-18 14:45:23 -07:00
2026-08-18 14:45:23 -07:00
2026-08-19 10:50:52 -05:00
2026-08-18 08:52:36 -05:00
2026-08-18 08:52:36 -05:00
2026-07-23 00:18:21 -05:00
2026-07-23 00:18:21 -05:00
2026-07-18 19:15:57 -04:00
2026-07-18 19:15:57 -04:00
2026-07-19 22:38:57 -05:00
2026-08-06 22:02:46 -05:00
2026-08-06 22:02:46 -05:00
2026-07-25 20:51:18 -05:00
2026-07-25 20:51:18 -05:00
2026-08-03 18:10:30 +05:30
2026-08-03 18:10:30 +05:30
2026-07-31 22:28:43 -07:00
2026-07-31 22:28:43 -07:00
2026-08-07 02:42:42 +00:00
2026-08-06 21:20:41 -05:00
2026-08-15 03:31:07 +00:00
2026-08-14 20:23:07 -07:00
2026-07-13 17:57:54 -04:00
2026-08-19 10:51:12 -05:00
2026-07-27 07:00:22 +00:00
2026-08-19 10:51:12 -05:00
2026-08-09 06:21:15 -05:00
2026-08-08 13:36:08 +05:30
2026-07-25 19:11:39 +00:00
2026-07-24 22:52:45 -05:00
2026-08-12 22:24:37 -05:00
2026-07-24 23:30:25 -05:00
2026-07-24 23:30:25 -05:00
2026-07-15 15:37:12 -04:00
2026-07-15 15:37:12 -04:00
2026-08-14 20:24:51 -07:00
2026-08-14 20:24:51 -07:00
2026-07-29 01:49:23 +00:00
2026-07-31 13:53:04 -05:00
2026-07-30 04:52:06 -05:00
2026-07-28 21:55:38 +00:00
2026-07-28 11:58:03 -07:00
2026-08-19 02:56:55 -05:00
2026-08-19 02:56:55 -05:00
2026-08-08 16:26:48 -05:00
2026-08-15 00:32:53 -07:00
2026-08-16 23:43:53 +00:00
2026-07-13 17:57:54 -04:00
2026-08-20 05:49:39 +00:00
2026-08-20 00:31:43 -05:00
2026-08-19 10:50:52 -05:00
2026-07-29 08:24:00 -07:00
2026-08-19 10:50:52 -05:00
2026-08-08 20:29:52 +00:00
2026-07-24 16:36:59 +00:00
2026-08-13 01:06:51 -05:00
2026-07-03 13:48:44 -05:00
2026-08-15 01:04:19 -07:00
2026-06-30 00:54:21 -05:00
2026-08-17 15:12:53 -05:00
2026-08-17 15:12:53 -05:00
2026-07-27 19:54:47 -05:00
2026-07-27 19:54:47 -05:00
2026-07-26 14:21:34 -05:00
2026-08-14 13:09:44 -07:00
2026-08-14 13:09:44 -07:00
2026-07-29 12:52:42 -07:00
2026-07-29 01:49:23 +00:00
2026-07-29 00:01:06 -07:00
2026-07-29 00:01:06 -07:00
2026-08-05 16:51:56 +00:00
2026-08-01 14:30:11 -07:00
2026-08-01 14:30:11 -07:00
2026-07-29 01:49:23 +00:00
2026-08-19 10:50:52 -05:00
2026-07-30 02:41:34 -05:00