alt-glitch
b6e2a54a94
fix(mcp): address adversarial review round 1 (cache parity, gates, races)
...
Consolidated findings from three independent reviewers (Codex, Claude Code, a
Hermes subagent w/ the hermes-agent-dev skill):
- BLOCKING: refresh_agent_mcp_tools rebuilt only the registry subset, silently
dropping post-build-injected memory-provider (mem0/honcho/…) and context-
engine (lcm_*) tools on every refresh. Now additive-preserving: re-applies
the same injectors agent_init uses, staged on locals and published atomically.
- Re-injection now honors the #5544 enabled_toolsets gate for context-engine
tools, so a restricted-toolset platform can't get lcm_* leaked back in.
- Atomic read-diff-publish under one lock: the returned `added` set and the
(tools, valid_tool_names) pair are consistent even under concurrent callers
(no half-swap, no TOCTOU).
- background_review fork opts out (_skip_mcp_refresh) so its byte-identical
tools[] cache parity with the parent is preserved.
- CLI /reload-mcp routed through the shared helper (was a 4th divergent copy
with the same clobber bug + missing disabled_toolsets).
- Explicit reloads (TUI RPC + CLI) pass enabled_override so a server the user
just enabled in config this session is picked up; automatic paths reuse the
agent's build-time selection.
- mcp_discovery_timeout default 5.0 -> 1.5s: correctness now comes from the
between-turns refresh, so the startup wait is only a small turn-1 UX bump
rather than a heavy dead-server latency penalty.
- has_registered_mcp_tools checks registered TOOLS (not connected servers) so a
zero-tool/prompt-only server doesn't make the per-turn hook fire forever.
- Tests: rewrote the thread-safety test to actually exercise the write path
(alternating tool sets), added the #5544-gate regression, the memory/context
preservation regression, and a "callable next turn via valid_tool_names"
contract; removed a dead monkeypatch line.
2026-06-19 11:57:43 -07:00
..
2026-05-22 03:33:01 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-13 14:35:27 -07:00
2026-06-15 13:33:12 -07:00
2026-05-28 22:26:25 -07:00
2026-06-11 10:49:47 -07:00
2026-05-28 22:26:25 -07:00
2026-05-29 15:43:55 +10:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-29 03:58:56 -07:00
2026-05-28 22:26:25 -07:00
2026-05-30 07:31:25 -07:00
2026-06-15 07:46:34 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-07 11:42:26 -06:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-19 06:31:08 -07:00
2026-05-28 22:26:25 -07:00
2026-05-29 03:44:49 -07:00
2026-06-13 21:57:15 -07:00
2026-06-18 12:48:36 +10:00
2026-06-09 23:21:24 -07:00
2026-06-07 02:09:20 -07:00
2026-06-18 08:53:31 -07:00
2026-05-28 22:26:25 -07:00
2026-06-13 03:33:27 -07:00
2026-05-28 22:26:25 -07:00
2026-06-10 14:39:03 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-16 14:30:11 -04:00
2026-05-28 22:26:25 -07:00
2026-06-16 14:30:11 -04:00
2026-05-28 22:26:25 -07:00
2026-06-06 18:43:20 -07:00
2026-06-08 22:46:57 -07:00
2026-05-29 11:49:54 +10:00
2026-06-18 14:14:41 +10:00
2026-06-18 09:09:21 +10:00
2026-06-10 19:23:06 +10:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:09 -07:00
2026-06-04 19:40:30 -07:00
2026-05-30 07:01:22 -07:00
2026-06-17 13:45:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-15 14:00:42 +05:30
2026-06-15 14:00:42 +05:30
2026-05-28 22:26:25 -07:00
2026-06-01 03:29:48 -07:00
2026-05-30 06:25:50 -07:00
2026-05-28 03:27:20 -07:00
2026-06-01 16:55:04 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-21 16:40:04 +05:30
2026-06-18 22:13:07 -07:00
2026-06-18 22:13:07 -07:00
2026-06-18 22:13:07 -07:00
2026-05-30 07:28:11 -07:00
2026-06-18 14:10:51 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-09 02:21:12 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-11 19:50:08 -05:00
2026-06-07 03:57:21 -07:00
2026-05-29 22:26:24 +05:30
2026-05-28 22:26:25 -07:00
2026-05-30 07:58:08 -07:00
2026-05-28 22:26:25 -07:00
2026-06-11 17:34:49 -07:00
2026-05-28 22:26:25 -07:00
2026-06-19 11:46:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-11 04:37:01 -07:00
2026-06-15 04:22:07 -07:00
2026-06-15 04:22:07 -07:00
2026-06-15 04:22:07 -07:00
2026-06-01 19:49:50 -07:00
2026-06-14 02:09:45 -07:00
2026-06-14 02:09:45 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-17 07:11:23 -07:00
2026-05-28 22:26:25 -07:00
2026-06-18 10:19:33 -07:00
2026-06-18 10:19:33 -07:00
2026-05-28 22:26:25 -07:00
2026-05-27 00:43:32 -07:00
2026-06-15 07:08:24 -07:00
2026-06-06 18:30:39 -07:00
2026-05-25 15:18:45 -07:00
2026-05-20 01:46:40 -05:00
2026-05-25 06:13:36 -07:00
2026-06-15 07:08:24 -07:00
2026-06-13 14:42:51 -07:00
2026-06-17 13:45:25 -07:00
2026-06-19 11:57:43 -07:00
2026-05-28 22:26:25 -07:00
2026-06-12 00:30:51 -05:00
2026-06-13 14:35:21 -07:00
2026-06-05 17:44:52 -07:00
2026-05-28 22:26:25 -07:00
2026-06-06 11:46:24 -07:00
2026-06-12 01:07:38 -07:00
2026-06-15 05:51:47 -07:00
2026-05-18 22:19:50 -07:00
2026-06-15 05:51:47 -07:00
2026-06-04 19:41:51 -05:00
2026-06-07 23:04:54 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-15 17:14:59 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-17 06:04:03 -07:00
2026-06-06 18:29:52 -07:00
2026-05-28 22:26:25 -07:00
2026-06-01 01:58:48 -07:00
2026-05-19 14:17:38 -07:00
2026-06-11 18:03:11 -04:00
2026-06-09 23:22:54 -07:00
2026-06-18 12:26:20 +05:30
2026-06-18 08:53:35 -07:00
2026-06-16 13:08:34 -07:00
2026-06-04 18:06:21 -07:00
2026-06-03 15:11:15 +10:00
2026-06-18 09:09:21 +10:00
2026-06-18 14:14:41 +10:00
2026-06-15 13:47:05 +10:00
2026-06-04 11:11:27 +10:00
2026-06-01 14:38:08 +10:00
2026-06-04 12:38:24 +10:00
2026-06-04 10:51:51 +10:00
2026-06-08 22:46:57 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-09 02:11:46 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-04 23:39:34 -07:00
2026-05-27 00:43:32 -07:00
2026-06-11 19:50:08 -05:00
2026-05-25 14:52:24 -07:00
2026-05-28 22:26:25 -07:00
2026-06-07 18:06:27 -07:00
2026-05-29 13:35:39 +10:00
2026-05-31 00:50:19 -07:00
2026-05-28 22:26:25 -07:00
2026-06-03 06:36:46 -07:00
2026-05-28 22:26:25 -07:00
2026-05-31 17:46:56 -05:00
2026-05-25 01:41:19 -07:00
2026-05-31 17:46:56 -05:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-10 02:57:39 -07:00
2026-06-10 02:57:39 -07:00
2026-05-29 13:24:12 -07:00
2026-05-18 22:29:45 -07:00
2026-05-25 05:15:55 -07:00
2026-06-19 07:04:58 -07:00
2026-05-24 18:04:54 -07:00
2026-06-19 07:26:56 -07:00
2026-06-07 11:42:26 -06:00
2026-05-28 22:26:25 -07:00
2026-06-01 19:00:30 -07:00
2026-05-31 00:12:09 -07:00
2026-06-04 18:04:47 -07:00
2026-05-28 22:26:25 -07:00
2026-05-31 00:11:52 -07:00
2026-05-28 22:26:25 -07:00
2026-06-04 18:04:47 -07:00
2026-06-14 16:47:57 -07:00
2026-06-14 16:47:57 -07:00
2026-05-28 04:52:42 -07:00
2026-06-14 16:47:57 -07:00
2026-06-14 16:47:57 -07:00
2026-05-28 04:52:42 -07:00
2026-06-04 18:04:47 -07:00
2026-06-09 02:21:12 -07:00
2026-06-10 02:57:15 -07:00
2026-06-14 02:07:32 -07:00
2026-05-21 02:38:45 +05:30
2026-05-25 03:35:33 -07:00
2026-05-28 22:26:25 -07:00