24af6685b0
The dashboard maps Ctrl+Delete to ESC d for delete-word-forward, but the composer had no binding for it: hermes-ink decodes ESC d as meta+'d', which fell through to the printable path and typed a literal "d" instead of deleting the next word. Add a meta+d branch that mirrors the existing Ctrl+W delete-word-backward, sharing a deleteWordForward helper with the Delete+word path. The new cut() wrote the clipboard fire-and-forget and removed the selected text immediately, so on a headless/SSH box with no clipboard backend the write fails and the text is lost with no copy to paste back. Make cut transactional via cutSelection(): await the write and only remove the selection when it succeeds; on failure the selection stays intact. The removal also re-checks the selection to avoid slicing with stale offsets after the awaited write.
55 lines
2.0 KiB
TypeScript
55 lines
2.0 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import { InputEvent } from '../../packages/hermes-ink/src/ink/events/input-event.js'
|
|
import { INITIAL_STATE, parseMultipleKeypresses } from '../../packages/hermes-ink/src/ink/parse-keypress.js'
|
|
import { deleteWordForward } from '../components/textInput.js'
|
|
|
|
function parseOne(sequence: string) {
|
|
const [keys] = parseMultipleKeypresses(INITIAL_STATE, sequence)
|
|
expect(keys).toHaveLength(1)
|
|
|
|
return keys[0]!
|
|
}
|
|
|
|
// The web dashboard maps Ctrl+Delete to ESC d (see
|
|
// web/src/lib/pty-keyboard-shortcuts.ts). hermes-ink decodes that bare
|
|
// meta-letter form via META_KEY_CODE_RE. If this contract ever changes the
|
|
// `wordMod && inp === 'd'` binding in textInput.tsx stops firing and
|
|
// Ctrl+Delete regresses to typing a literal "d".
|
|
describe('Ctrl+Delete → ESC d decode contract', () => {
|
|
it('decodes ESC d as meta+"d" so the composer binding is reached', () => {
|
|
const event = new InputEvent(parseOne('\x1bd'))
|
|
|
|
expect(event.key.meta).toBe(true)
|
|
expect(event.key.ctrl).toBe(false)
|
|
expect(event.input).toBe('d')
|
|
})
|
|
})
|
|
|
|
describe('deleteWordForward', () => {
|
|
it('deletes the word to the right of the cursor', () => {
|
|
// cursor before "hello" → removes "hello" and the trailing space.
|
|
expect(deleteWordForward('foo hello world', 4)).toEqual({ cursor: 4, value: 'foo world' })
|
|
})
|
|
|
|
it('deletes from mid-word to the next word boundary', () => {
|
|
// cursor inside "hello" (after "he") → removes "llo" + trailing space.
|
|
expect(deleteWordForward('foo hello world', 6)).toEqual({ cursor: 6, value: 'foo heworld' })
|
|
})
|
|
|
|
it('keeps the cursor fixed while removing text', () => {
|
|
const result = deleteWordForward('alpha beta', 0)
|
|
|
|
expect(result.cursor).toBe(0)
|
|
expect(result.value).toBe('beta')
|
|
})
|
|
|
|
it('is a no-op when the cursor is already at the end', () => {
|
|
expect(deleteWordForward('foo bar', 7)).toEqual({ cursor: 7, value: 'foo bar' })
|
|
})
|
|
|
|
it('handles an empty string', () => {
|
|
expect(deleteWordForward('', 0)).toEqual({ cursor: 0, value: '' })
|
|
})
|
|
})
|