Files
hermes-agent/apps/shared/src/slash.ts
T
teknium1 057c2c85fc refactor(slash): delete the dead web slash re-implementation; one slash parser + command.dispatch narrowing in @hermes/shared
web/src/lib/slashExec.ts and web/src/components/SlashPopover.tsx had zero
importers since the React composer was replaced by the PTY-embedded TUI
(f49afd3122) — exactly what web/AGENTS.md forbids, now orphaned. Their
parseSlash still carried the `(.*)` newline bug and lacked the `prefill`
variant. Desktop and the TUI each hand-rolled the same slash split and the
same command.dispatch narrowing; the multi-line fix (#41323, #55510) had to
be applied to each copy separately.

Sites:
  web/src/lib/slashExec.ts::executeSlash/parseSlash/parseCommandDispatch  -> deleted
  web/src/components/SlashPopover.tsx::SlashPopover                        -> deleted
  apps/desktop/src/lib/chat-runtime.ts::parseSlashCommand                  -> apps/shared/src/slash.ts::parseSlashCommand
  apps/desktop/src/lib/chat-runtime.ts::parseCommandDispatch               -> apps/shared/src/slash.ts::parseCommandDispatch
  apps/desktop/src/lib/chat-runtime.ts::SLASH_COMMAND_RE                   -> apps/shared/src/slash.ts::SLASH_COMMAND_RE
  apps/desktop/src/app/types.ts::*CommandDispatchResponse (5 interfaces)   -> apps/shared/src/slash.ts
  ui-tui/src/domain/slash.ts::parseSlashCommand/looksLikeSlashCommand      -> apps/shared/src/slash.ts
  ui-tui/src/lib/rpc.ts::asCommandDispatch                                 -> apps/shared/src/slash.ts::parseCommandDispatch
  ui-tui/src/gatewayTypes.ts::CommandDispatchResponse                      -> apps/shared/src/slash.ts
  9 desktop importers + 3 TUI importers repointed.

Behavior change: desktop `parseSlashCommand` now lower-cases the command
name like the TUI, backend `resolve_command` and `slash.exec` already do
(`/Help` resolved before via the case-insensitive backend; local desktop
action lookups were case-sensitive). TUI's parsed result no longer carries
the redundant `cmd` echo (no consumer read it).

Tests: apps/shared/src/slash.test.ts (parseSlashCommand multi-line /
newline-boundary / degenerate cases; parseCommandDispatch every variant +
malformed rejection). Sabotage: restoring `(.*)` in SLASH_PARTS_RE fails
2 tests; restored -> 7 pass. Desktop chat-runtime.test.ts and TUI
asCommandDispatch.test.ts cases moved here; slashParity.test.ts repointed.
2026-09-13 06:50:57 -07:00

118 lines
4.1 KiB
TypeScript

/**
* The slash-command wire contract every TypeScript surface shares: how a typed
* line splits into `name` + `arg`, and the `command.dispatch` response union
* (`tui_gateway/methods_tools.py::command.dispatch`). One parser, so a fix such
* as the multi-line argument bug (#41323, #55510) reaches desktop and TUI at
* once instead of landing in whichever copy the reporter happened to use.
*/
/** A slash COMMAND invocation: `/` at position 0, a bare name, then whitespace
* or end. `/usr/local` (second slash) and `run /clean` (not at 0) are prose. */
export const SLASH_COMMAND_RE = /^\/[^\s/]*(?:\s|$)/
export const looksLikeSlashCommand = (text: string): boolean => SLASH_COMMAND_RE.test(text)
// `[\s\S]*` (not `.*`): the arg may span newlines — `/goal <multi-line text>`
// or a skill command with a long pasted context. A `.*$` regex fails the
// whole match on any newline, so every multiline slash command parsed as an
// empty name and got swallowed. The backend and CLI both split on any
// whitespace (`split(maxsplit=1)`), so `\S+` for the name is the parity rule.
// Only the separator between name and argument is whitespace the parser owns;
// the argument's interior (runs of spaces, indentation, blank lines) survives
// verbatim — flattening it once turned every pasted diff into one line.
const SLASH_PARTS_RE = /^(\S+)([\s\S]*)$/
export interface ParsedSlashCommand {
/** Argument text with the outer whitespace removed; interior kept verbatim. */
arg: string
/** Lower-cased command name without the slash; '' for `/`, `/ `, `/ words`. */
name: string
}
/** Split `/name arg…` the way the backend does. The name is lower-cased because
* every consumer (`hermes_cli.commands.resolve_command`, `slash.exec`) is
* case-insensitive; keeping the typed case only made surfaces disagree. */
export function parseSlashCommand(command: string): ParsedSlashCommand {
const match = SLASH_PARTS_RE.exec(command.replace(/^\/+/, ''))
return match ? { arg: match[2]!.trim(), name: match[1]!.toLowerCase() } : { arg: '', name: '' }
}
export interface ExecCommandDispatchResponse {
output?: string
type: 'exec' | 'plugin'
}
export interface AliasCommandDispatchResponse {
target: string
type: 'alias'
}
export interface SkillCommandDispatchResponse {
/** The invocation the UI renders (`/work fix the leak`). `message` is the
* expanded skill body — model-facing scaffolding no surface may show. */
display?: string
message?: string
name: string
type: 'skill'
}
export interface SendCommandDispatchResponse {
/** Set for a skill-bundle send: see SkillCommandDispatchResponse.display. */
display?: string
message: string
notice?: string
type: 'send'
}
export interface PrefillCommandDispatchResponse {
message: string
notice?: string
type: 'prefill'
}
export type CommandDispatchResponse =
| AliasCommandDispatchResponse
| ExecCommandDispatchResponse
| PrefillCommandDispatchResponse
| SendCommandDispatchResponse
| SkillCommandDispatchResponse
const str = (value: unknown) => (typeof value === 'string' ? value : undefined)
/** Narrow a raw `command.dispatch` result to the union, or null when the
* payload is malformed (missing required field, unknown `type`). */
export function parseCommandDispatch(raw: unknown): CommandDispatchResponse | null {
if (!raw || typeof raw !== 'object' || Array.isArray(raw)) {
return null
}
const row = raw as Record<string, unknown>
switch (row.type) {
case 'alias':
return typeof row.target === 'string' ? { target: row.target, type: 'alias' } : null
case 'exec':
case 'plugin':
return { output: str(row.output), type: row.type }
case 'prefill':
return typeof row.message === 'string' ? { message: row.message, notice: str(row.notice), type: 'prefill' } : null
case 'send':
return typeof row.message === 'string'
? { display: str(row.display), message: row.message, notice: str(row.notice), type: 'send' }
: null
case 'skill':
return typeof row.name === 'string'
? { display: str(row.display), message: str(row.message), name: row.name, type: 'skill' }
: null
default:
return null
}
}