Frowtek
c8882c141c
fix(credentials): never mount master credential stores into skill sandboxes
...
register_credential_file() takes a skill-declared relative path from
required_credential_files frontmatter and bind-mounts it read-only into the
remote sandbox the skill's own code runs in. It validates that the resolved
path stays inside HERMES_HOME — the docstring names the threat directly:
so that a malicious skill cannot declare
required_credential_files: ['../../.ssh/id_rsa'] and exfiltrate
sensitive host files into a container sandbox
Containment is the wrong boundary on its own, because HERMES_HOME is exactly
where the master credential stores live. Traversal is blocked; asking for the
keys by name is not:
skill declares mounted? agent may read it?
.env YES DENIED
auth.json YES DENIED
.anthropic_oauth.json YES DENIED
cache/bws_cache.json YES DENIED
mcp-tokens/srv.json YES DENIED
google_token.json YES allowed
../../.ssh/id_rsa no n/a
Every row marked DENIED is refused by the canonical read guard
(agent.file_safety.get_read_block_error) — the agent cannot read_file them —
yet one line of hub-installed skill frontmatter gets them bind-mounted where
that skill can cat them. .env alone is every provider API key.
Reuse the canonical deny-list as the mount bar: what the agent is forbidden
to read is not mountable either, so the mount surface cannot hand a skill
what the read surface denies it. Fails CLOSED — if the guard can't be
consulted the mount is refused rather than risked.
The module keeps doing its job: a skill still mounts its own service token
(google_token.json, skills/*), and a refused entry is reported back through
register_credential_files' missing list instead of failing the batch.
The three prior PRs here (#3946 , #3951 , #4316 ) all hardened traversal; this
closes the half that traversal validation never covered.
2026-07-20 06:50:26 -07:00
..
2026-05-22 03:33:01 -07:00
2026-05-28 22:26:25 -07:00
2026-07-17 04:53:38 -07:00
2026-07-05 14:48:40 -07:00
2026-05-28 22:26:25 -07:00
2026-07-12 22:43:57 -07:00
2026-07-13 04:31:55 -07:00
2026-07-17 04:53:04 -07:00
2026-07-06 04:58:42 -07:00
2026-07-14 23:36:37 -07:00
2026-07-16 01:28:24 -07:00
2026-06-11 10:49:47 -07:00
2026-06-29 01:26:24 -07:00
2026-06-29 01:26:24 -07:00
2026-06-29 01:26:24 -07:00
2026-07-03 03:27:47 -07:00
2026-05-28 22:26:25 -07:00
2026-06-29 01:26:24 -07:00
2026-06-25 22:02:22 -07:00
2026-07-01 05:09:35 -07:00
2026-07-03 03:27:47 -07:00
2026-06-28 12:25:15 -05:00
2026-06-28 13:49:08 -07:00
2026-05-28 22:26:25 -07:00
2026-06-29 02:24:57 -07:00
2026-07-01 05:23:17 -07:00
2026-07-16 23:41:26 -07:00
2026-07-16 23:41:26 -07:00
2026-07-02 13:10:30 +05:30
2026-05-30 07:31:25 -07:00
2026-06-28 14:25:10 -07:00
2026-07-16 23:41:26 -07:00
2026-07-18 10:07:46 -07:00
2026-06-28 13:49:08 -07:00
2026-07-01 05:04:41 -07:00
2026-06-28 12:14:21 -05:00
2026-06-21 15:23:47 -07:00
2026-07-01 20:01:55 +03:00
2026-07-01 05:04:41 -07:00
2026-06-28 02:42:01 -07:00
2026-06-21 07:26:18 -07:00
2026-05-28 22:26:25 -07:00
2026-06-25 22:02:22 -07:00
2026-06-21 17:46:38 +05:30
2026-05-28 22:26:25 -07:00
2026-07-17 20:55:24 +00:00
2026-06-19 06:31:08 -07:00
2026-05-28 22:26:25 -07:00
2026-07-16 04:24:07 -07:00
2026-05-29 03:44:49 -07:00
2026-07-16 04:25:19 -07:00
2026-06-18 12:48:36 +10:00
2026-06-22 06:42:30 -07:00
2026-07-18 15:07:04 -07:00
2026-07-04 02:37:33 -07:00
2026-06-07 02:09:20 -07:00
2026-07-16 00:34:20 +05:30
2026-07-14 02:59:39 +05:30
2026-07-16 00:18:38 -07:00
2026-07-20 06:50:26 -07:00
2026-06-30 17:29:03 -07:00
2026-07-01 00:13:36 -07:00
2026-06-26 01:11:11 -07:00
2026-06-21 13:28:04 +05:30
2026-07-01 14:23:01 +05:30
2026-05-28 22:26:25 -07:00
2026-07-02 04:20:43 -07:00
2026-06-28 14:33:03 -07:00
2026-05-28 22:26:25 -07:00
2026-06-16 14:30:11 -04:00
2026-06-30 03:07:40 -07:00
2026-06-30 03:16:22 -07:00
2026-07-18 01:30:17 -07:00
2026-07-19 10:29:14 -07:00
2026-07-09 15:38:32 +05:30
2026-07-07 02:40:04 -07:00
2026-06-29 11:01:08 +10:00
2026-06-24 15:23:23 +10:00
2026-07-17 20:55:24 +00:00
2026-07-05 14:41:51 -07:00
2026-05-29 11:49:54 +10:00
2026-07-16 08:52:47 +10:00
2026-06-26 19:15:18 -07:00
2026-06-18 09:09:21 +10:00
2026-06-10 19:23:06 +10:00
2026-07-01 14:37:22 +05:30
2026-07-20 06:50:11 -07:00
2026-07-13 04:31:55 -07:00
2026-07-17 20:55:24 +00:00
2026-05-30 07:01:22 -07:00
2026-07-13 01:59:58 -04:00
2026-05-28 22:26:25 -07:00
2026-07-05 14:42:05 -07:00
2026-07-16 00:18:38 -07:00
2026-05-28 22:26:25 -07:00
2026-07-06 01:55:58 -07:00
2026-07-20 02:25:53 -07:00
2026-06-15 14:00:42 +05:30
2026-07-16 00:18:38 -07:00
2026-05-28 22:26:25 -07:00
2026-07-16 00:18:38 -07:00
2026-07-16 00:18:38 -07:00
2026-07-14 17:09:40 +05:30
2026-07-16 22:46:46 -04:00
2026-07-01 17:48:32 +05:30
2026-06-01 16:55:04 -07:00
2026-06-30 17:32:28 -07:00
2026-07-05 02:24:00 -07:00
2026-05-28 22:26:25 -07:00
2026-07-01 14:37:22 +05:30
2026-05-28 22:26:25 -07:00
2026-05-21 16:40:04 +05:30
2026-07-05 13:51:26 -07:00
2026-06-18 22:13:07 -07:00
2026-06-19 16:59:54 -07:00
2026-07-14 02:59:39 +05:30
2026-06-25 12:38:33 -07:00
2026-07-04 15:30:50 -07:00
2026-07-17 20:55:24 +00:00
2026-06-21 12:02:30 -07:00
2026-07-20 05:38:25 -07:00
2026-06-25 09:20:13 +10:00
2026-07-16 12:48:48 -07:00
2026-05-28 22:26:25 -07:00
2026-06-25 13:52:06 -07:00
2026-07-17 20:55:24 +00:00
2026-07-17 06:54:51 -07:00
2026-07-02 02:13:30 -07:00
2026-07-16 01:28:24 -07:00
2026-07-16 01:28:13 -07:00
2026-07-01 15:42:19 +05:30
2026-07-16 01:28:24 -07:00
2026-07-17 20:55:24 +00:00
2026-06-11 19:50:08 -05:00
2026-06-07 03:57:21 -07:00
2026-07-03 05:30:16 -05:00
2026-05-28 22:26:25 -07:00
2026-05-30 07:58:08 -07:00
2026-07-17 20:55:24 +00:00
2026-06-21 16:02:56 +05:30
2026-07-17 20:55:24 +00:00
2026-05-28 22:26:25 -07:00
2026-07-17 04:50:47 -07:00
2026-07-05 13:40:21 -07:00
2026-06-19 11:46:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-07-17 04:57:12 -07:00
2026-06-11 04:37:01 -07:00
2026-06-15 04:22:07 -07:00
2026-07-17 04:50:47 -07:00
2026-07-17 04:50:47 -07:00
2026-07-17 20:55:24 +00:00
2026-07-18 18:49:56 -04:00
2026-07-05 21:36:19 -07:00
2026-06-14 02:09:45 -07:00
2026-07-17 20:55:24 +00:00
2026-07-05 21:48:36 -07:00
2026-07-14 13:59:38 -07:00
2026-07-05 02:06:39 -07:00
2026-07-17 20:55:24 +00:00
2026-07-07 15:16:00 -07:00
2026-07-18 04:15:13 -07:00
2026-07-07 15:16:00 -07:00
2026-07-05 21:48:36 -07:00
2026-07-18 18:40:34 -04:00
2026-05-28 22:26:25 -07:00
2026-07-09 15:38:32 +05:30
2026-06-18 10:19:33 -07:00
2026-07-07 02:10:43 -07:00
2026-05-28 22:26:25 -07:00
2026-07-09 20:03:11 -07:00
2026-06-21 11:11:23 -07:00
2026-06-06 18:30:39 -07:00
2026-05-25 15:18:45 -07:00
2026-07-13 02:42:18 -07:00
2026-05-25 06:13:36 -07:00
2026-07-17 20:55:24 +00:00
2026-06-13 14:42:51 -07:00
2026-06-17 13:45:25 -07:00
2026-06-19 11:57:43 -07:00
2026-07-17 20:55:24 +00:00
2026-07-07 15:14:30 -07:00
2026-07-16 00:18:38 -07:00
2026-07-14 22:14:10 -07:00
2026-07-07 02:52:17 -07:00
2026-06-13 14:35:21 -07:00
2026-06-20 23:23:47 -07:00
2026-05-28 22:26:25 -07:00
2026-06-20 10:26:45 -07:00
2026-06-12 01:07:38 -07:00
2026-06-15 05:51:47 -07:00
2026-05-18 22:19:50 -07:00
2026-07-09 15:38:32 +05:30
2026-07-16 00:18:38 -07:00
2026-06-27 04:41:22 -07:00
2026-06-07 23:04:54 -07:00
2026-07-01 01:39:10 -07:00
2026-06-20 10:26:45 -07:00
2026-07-12 02:59:27 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-07-18 20:17:22 +05:30
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-25 22:03:02 -07:00
2026-06-06 18:29:52 -07:00
2026-05-28 22:26:25 -07:00
2026-07-05 13:42:46 -07:00
2026-05-19 14:17:38 -07:00
2026-06-11 18:03:11 -04:00
2026-07-05 22:21:05 -07:00
2026-06-18 12:26:20 +05:30
2026-06-27 21:07:53 -07:00
2026-07-09 15:38:14 +05:30
2026-07-07 05:14:00 -07:00
2026-07-17 04:52:02 -07:00
2026-06-21 16:39:48 -07:00
2026-06-20 23:23:47 -07:00
2026-06-04 18:06:21 -07:00
2026-06-26 12:09:52 +10:00
2026-06-26 12:09:52 +10:00
2026-06-08 22:46:57 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-07-09 15:38:32 +05:30
2026-05-28 22:26:25 -07:00
2026-06-22 15:41:23 +10:00
2026-07-16 08:55:10 -07:00
2026-05-28 22:26:25 -07:00
2026-07-14 22:00:28 -07:00
2026-05-28 22:26:25 -07:00
2026-07-16 00:18:38 -07:00
2026-06-27 19:29:00 -07:00
2026-07-04 14:17:11 +05:30
2026-07-01 01:05:28 -07:00
2026-06-26 15:26:08 +05:30
2026-06-25 23:42:42 +05:30
2026-06-07 18:06:27 -07:00
2026-05-29 13:35:39 +10:00
2026-05-31 00:50:19 -07:00
2026-06-30 16:39:41 -07:00
2026-06-03 06:36:46 -07:00
2026-05-28 22:26:25 -07:00
2026-07-14 02:59:39 +05:30
2026-05-31 17:46:56 -05:00
2026-05-25 01:41:19 -07:00
2026-05-31 17:46:56 -05:00
2026-05-28 22:26:25 -07:00
2026-07-14 02:59:39 +05:30
2026-07-14 02:59:39 +05:30
2026-07-14 02:59:39 +05:30
2026-07-13 22:26:19 -07:00
2026-06-10 02:57:39 -07:00
2026-07-14 02:59:39 +05:30
2026-05-18 22:29:45 -07:00
2026-05-25 05:15:55 -07:00
2026-07-14 02:59:39 +05:30
2026-05-24 18:04:54 -07:00
2026-07-03 05:30:16 -05:00
2026-06-19 07:26:56 -07:00
2026-07-07 02:39:36 -07:00
2026-07-05 00:47:54 -07:00
2026-06-29 21:11:58 -07:00
2026-07-14 02:59:39 +05:30
2026-06-29 21:11:58 -07:00
2026-07-04 15:30:50 -07:00
2026-07-05 00:47:54 -07:00
2026-07-17 20:55:24 +00:00
2026-07-17 20:55:24 +00:00
2026-05-28 22:26:25 -07:00
2026-06-30 00:19:49 -07:00
2026-06-04 18:04:47 -07:00
2026-06-25 01:45:06 +05:30
2026-06-14 16:47:57 -07:00
2026-07-17 11:37:25 +05:30
2026-07-06 04:38:17 -07:00
2026-07-09 20:28:44 -07:00
2026-07-10 19:14:06 +05:30
2026-06-29 10:00:49 -07:00
2026-06-29 10:00:49 -07:00
2026-07-01 00:49:38 -07:00
2026-07-09 15:38:32 +05:30
2026-06-27 03:08:41 +05:30
2026-06-27 15:59:00 -07:00
2026-07-08 06:17:56 -07:00
2026-06-14 02:07:32 -07:00
2026-07-07 22:14:33 -07:00
2026-07-19 23:58:33 -07:00
2026-06-29 21:11:58 -07:00
2026-05-25 03:35:33 -07:00
2026-06-21 11:35:09 -07:00