Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
87 lines
2.8 KiB
Python
87 lines
2.8 KiB
Python
"""Unit tests for relay channel-context consumption (design relay-channel-context).
|
|
|
|
Covers:
|
|
- CapabilityDescriptor.supports_context: default False + JSON round-trip +
|
|
forward-compat (older gateway ignores it / newer connector sends it).
|
|
- _event_from_wire mapping the connector's read-only `context` array into the
|
|
existing MessageEvent.channel_context injection field, and leaving it unset
|
|
(byte-identical to today) when absent/empty/malformed.
|
|
- The trigger text is never affected by context (read-only invariant).
|
|
|
|
Pure unit tests: no socket, no websockets dependency.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from gateway.relay.descriptor import CapabilityDescriptor
|
|
from gateway.relay.ws_transport import _event_from_wire, _render_relay_context
|
|
|
|
|
|
def _descriptor_kwargs(**overrides):
|
|
base = dict(
|
|
contract_version=1,
|
|
platform="discord",
|
|
label="Discord",
|
|
max_message_length=2000,
|
|
supports_draft_streaming=False,
|
|
supports_edit=True,
|
|
supports_threads=True,
|
|
markdown_dialect="discord",
|
|
len_unit="chars",
|
|
)
|
|
base.update(overrides)
|
|
return base
|
|
|
|
|
|
class TestDescriptorSupportsContext:
|
|
|
|
|
|
def test_from_json_ignores_unknown_keys(self):
|
|
# Forward-compat: a newer connector sending extra keys must not break.
|
|
payload = (
|
|
'{"contract_version":1,"platform":"discord","label":"Discord",'
|
|
'"max_message_length":2000,"supports_draft_streaming":false,'
|
|
'"supports_edit":true,"supports_threads":true,'
|
|
'"markdown_dialect":"discord","len_unit":"chars",'
|
|
'"supports_context":true,"some_future_field":123}'
|
|
)
|
|
d = CapabilityDescriptor.from_json(payload)
|
|
assert d.supports_context is True
|
|
|
|
|
|
class TestRenderRelayContext:
|
|
def test_none_and_empty_return_none(self):
|
|
assert _render_relay_context(None) is None
|
|
assert _render_relay_context([]) is None
|
|
assert _render_relay_context("not a list") is None
|
|
|
|
|
|
class TestEventFromWireContext:
|
|
def _wire(self, **overrides):
|
|
base = {
|
|
"text": "@bot repeat what they said above",
|
|
"message_type": "text",
|
|
"source": {
|
|
"platform": "discord",
|
|
"chat_id": "chan-1",
|
|
"chat_type": "channel",
|
|
"user_id": "author-1",
|
|
},
|
|
"message_id": "m-100",
|
|
}
|
|
base.update(overrides)
|
|
return base
|
|
|
|
def test_context_maps_into_channel_context(self):
|
|
ev = _event_from_wire(
|
|
self._wire(
|
|
context=[
|
|
{"text": "earlier", "source": {"user_name": "alice"}},
|
|
]
|
|
)
|
|
)
|
|
assert ev.channel_context is not None
|
|
assert "alice: earlier" in ev.channel_context
|
|
|
|
|